From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id CM50BQWE/Wbz2gAA62LTzQ:P1 (envelope-from ) for ; Wed, 02 Oct 2024 17:33:57 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id CM50BQWE/Wbz2gAA62LTzQ (envelope-from ) for ; Wed, 02 Oct 2024 19:33:57 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=k0gutGAZ; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1727890436; a=rsa-sha256; cv=none; b=bvCzVjQN5x8PuEtFiZAmoYYym6g/7YGrHibugU9rk/34695OawgGlrLX4ab5QFDhcqhgYU XA/EQBuwA+9QttTIjM69t8mvche94GtwnbPcS+j+gCEELYFExiwL8PXSKl0jaWAei2yZ7o oGNomEu84MIUKGUahuJMSSiTCWHYi36e34sNwAetBQnsrzaxrWyxp4cvR/WGp78hLuRorY JS9BFvX6fhiUzsN81gnwnHFfy3hIj1qMkX3x04hcoLP5Ry6fV6nUddf010kevpUeRHUlO7 kzEAyrgpTpyXlsq83o/Mo9MwOcM3HAbDJ3M8UrPJ8qPFjCmxeQms+2ClvKIMOQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=k0gutGAZ; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1727890436; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=94b/pXcLEmcVck8TpUgWq6h5IkzI6NLmKIVcIXaYq8s=; b=JpDvgBbP4flYnZKxT3ui/udLf9hMctrVVy5uHDA90TM4BuEYYBOCOBTA/VHOUQXX82kYDl xgT5twb2Pq5WqShMZq5En72Eng738Q0/DiZzGn+wr07MtfVCiTbeAIwGQrhD1zfGNhrenE 9Vw/D4oxi0Y/M1wGMCKo0SD2+dqlPju/3VLP5Wjl5Rpr2wkuBw32Cp738l4n8RCDg10eup AaYBHUEraimyMPWOoKOGtAl3zXeRSK5DA09wRTCKk5qK4zC0lE0PBl2nEGxOcqDEVxMUfq I/xq68fknXzfUPIIWxN4BDwYAwVOoVCA+R7w/Kzq0aht6IZd102SUAj4R/cFMQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4F3EC62755 for ; Wed, 02 Oct 2024 19:33:56 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sw3Dv-0003aq-3G; Wed, 02 Oct 2024 13:33:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sw3Dt-0003ab-Lr for emacs-orgmode@gnu.org; Wed, 02 Oct 2024 13:33:13 -0400 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sw3Dr-0000Nc-Mc for emacs-orgmode@gnu.org; Wed, 02 Oct 2024 13:33:13 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 03D71240101 for ; Wed, 2 Oct 2024 19:33:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1727890388; bh=pIgtZ0zibBsdTf8dYsoJ+r4t5LvkSq4eP1KMqid4TNw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=k0gutGAZfx4MPmc0u+ffuFcL8cQHcyVdWcQGnI8VljIjptfl1CnjAsCe1JwirWjP+ GCmzO4eZrCre0YS9yIWqsPWdCPtER1/+T+fYUkBVbkvr4aFesSYTXwJhSMIEf9IbYg 69Wn4ROz35vhzWT20xpZS2OF9sf6A0NVtYUXNFS44j7X89wQkWjQhjcYIuHZZD1PBV K3+HBusrXvHuvsnyCXCNpDHkMSB809t+p8gDI2bzsR7IaEAiOBNUdlTElC0ngaVO/L hMeTNNhuMo8hcD1cIj18bn5kvEelA9SKNEHa44fHBIXl6IVXaXBOFmsRjmjHnWiohk I/mX3p2SKLBHQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4XJhjH02fmz9rxB; Wed, 2 Oct 2024 19:33:06 +0200 (CEST) From: Ihor Radchenko To: Karthik Chikmagalur Cc: lra@phdk.org, Emacs Orgmode Subject: Re: [PATCH] Fixing a regression in org-persists ability to handle non-list container arguments. In-Reply-To: <87r09bwary.fsf@gmail.com> References: <87zfo0qchb.fsf@localhost> <87r09bwary.fsf@gmail.com> Date: Wed, 02 Oct 2024 17:34:57 +0000 Message-ID: <87ikuaqugu.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -1.40 X-Spam-Score: -1.40 X-Migadu-Queue-Id: 4F3EC62755 X-Migadu-Scanner: mx12.migadu.com X-TUID: MjywJ0yaQ+ci Karthik Chikmagalur writes: > LRA, thanks for the fix. > > Ihor, `org-persist--find-index' is singularly confusing. I've been over > it with edebug a few times and still can't figure out what it's doing, > because `container' means different things at different points in the > function because of the macro `org-persist-collection-let'. Could it be > simplified in some way? This dichotomy is indeed confusing. I think that it will make things easier to change :container field into :containers - always storing container list. One needs to go through org-persist.el and change this convention everywhere. Then, bump `org-persist--storage-version'. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at