From: Ihor Radchenko <yantar92@posteo.net>
To: Karthik Chikmagalur <karthikchikmagalur@gmail.com>
Cc: lra@phdk.org, Emacs Orgmode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Fixing a regression in org-persists ability to handle non-list container arguments.
Date: Wed, 02 Oct 2024 17:34:57 +0000 [thread overview]
Message-ID: <87ikuaqugu.fsf@localhost> (raw)
In-Reply-To: <87r09bwary.fsf@gmail.com>
Karthik Chikmagalur <karthikchikmagalur@gmail.com> writes:
> LRA, thanks for the fix.
>
> Ihor, `org-persist--find-index' is singularly confusing. I've been over
> it with edebug a few times and still can't figure out what it's doing,
> because `container' means different things at different points in the
> function because of the macro `org-persist-collection-let'. Could it be
> simplified in some way?
This dichotomy is indeed confusing.
I think that it will make things easier to change :container field into
:containers - always storing container list.
One needs to go through org-persist.el and change this convention
everywhere. Then, bump `org-persist--storage-version'.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
next prev parent reply other threads:[~2024-10-02 17:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-18 0:24 [PATCH] Fixing a regression in org-persists ability to handle non-list container arguments lra
[not found] ` <O71W8io--B-9@phdk.org-O71WWax----9>
2024-09-18 0:29 ` lra
2024-09-22 9:11 ` Ihor Radchenko
2024-09-22 23:04 ` Karthik Chikmagalur
2024-10-02 17:34 ` Ihor Radchenko [this message]
2024-10-03 18:00 ` lra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ikuaqugu.fsf@localhost \
--to=yantar92@posteo.net \
--cc=emacs-orgmode@gnu.org \
--cc=karthikchikmagalur@gmail.com \
--cc=lra@phdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).