From: Phil Jackson <phil@shellarchive.co.uk>
To: Bastien <bzg@altern.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: Bug? Installing from git master
Date: Mon, 03 Mar 2008 11:01:46 +0000 [thread overview]
Message-ID: <87hcfof4v9.fsf@shellarchive.co.uk> (raw)
In-Reply-To: <87tzjoxfik.fsf@bzg.ath.cx> (Bastien's message of "Mon, 03 Mar 2008 10:34:27 +0000")
Bastien <bzg@altern.org> writes:
> Carsten Dominik <dominik@science.uva.nl> writes:
>
>> I did not realize that erc is not supported on all Emacs versions,
>> to we clearly need to cater for this. Wither by taking it out
>> of that variable, of my making the require fail silently.
>> We could, for example, wrap the require into condition-case and only
>> pus out a message, not raise a signal.
>
> I have pushed a commit taking this later route.
Slow down... :)
As mentioned orc-irc is meant to be generic so it's still not quite
right. I sent an email to you and Carsten about having a loadablep (bad
name?) function exposed by the module which would give it a chance to
do some requires and setting up too. Might be interesting to look at the
ERC code and check how they do it...
Here is my (rough) suggestion again:
--8<---------------cut here---------------start------------->8---
(defun org-load-module (module-name)
(let ((sym (intern (concat module-name "-loadablep"))))
(if (fboundp sym)
(when (funcall sym)
(require (intern module-name)))
(error "org modules must have a -loadablep defun."))))
--8<---------------cut here---------------end--------------->8---
Cheers,
Phil
--
Phil Jackson
http://www.shellarchive.co.uk
next prev parent reply other threads:[~2008-03-03 11:01 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-29 20:41 Bug? Installing from git master Sebastian
2008-02-29 20:44 ` Carsten Dominik
2008-02-29 21:11 ` Manish
2008-02-29 21:34 ` Carsten Dominik
2008-02-29 21:45 ` Manish
2008-02-29 22:09 ` Bastien
2008-02-29 22:30 ` Manish
2008-02-29 22:49 ` Bastien
2008-02-29 23:05 ` Manish
2008-02-29 23:12 ` Bastien
2008-03-02 23:34 ` Adam Spiers
2008-03-03 0:13 ` Bastien Guerry
2008-03-03 8:13 ` Carsten Dominik
2008-03-03 9:15 ` Phil Jackson
2008-03-03 10:34 ` Bastien
2008-03-03 11:01 ` Phil Jackson [this message]
2008-03-03 9:17 ` Phil Jackson
2008-03-03 10:36 ` Bastien
2008-03-01 2:36 ` Bernt Hansen
2008-02-29 21:18 ` Sebastian
2008-02-29 21:27 ` Sebastian
2008-03-03 10:33 ` Bastien
2008-03-05 0:39 ` Sebastian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87hcfof4v9.fsf@shellarchive.co.uk \
--to=phil@shellarchive.co.uk \
--cc=bzg@altern.org \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).