Please test links

Please test links

[Carsten Dominik]

Hi,

I have been busy and have split out most of the linking code
in org.el into separate files.  As I am not using most of
the link types myself, I would appreciate if people could systematically
test all link types they are using:  The following link types are
in separate files now:

org-bbdb.el
org-gnus.el
org-info.el
org-irc.el
org-mac-message.el
org-mhe.el
org-rmail.el
org-vm.el
org-wl.el


Please report back which of these link types you are using, and
if they are still working after a pull in your it repo.
If not, I'd appreciate detailed backtraces so that this remaining
issues can be fixed.

Thanks!

- Carsten

P.S. if things are really broken, you can always switch back to an
earlier version in the repo, for example using

git checkout release_5.23a

Re: Please test links

[Leo]

On 2008-03-15 08:24 +0000, Carsten Dominik wrote:
> Please report back which of these link types you are using, and
> if they are still working after a pull in your it repo.
> If not, I'd appreciate detailed backtraces so that this remaining
> issues can be fixed.

The repo is not on orgmode.org. Where to find it?

-- 
.:  Leo  :.  [ sdl.web AT gmail.com ]  .:  [ GPG Key: 9283AA3F ]  :.

          Use the best OS -- http://www.fedoraproject.org/

Re: Re: Please test links

[Bastien]

Leo <sdl.web@gmail.com> writes:

> On 2008-03-15 08:24 +0000, Carsten Dominik wrote:
>> Please report back which of these link types you are using, and
>> if they are still working after a pull in your it repo.
>> If not, I'd appreciate detailed backtraces so that this remaining
>> issues can be fixed.
>
> The repo is not on orgmode.org. Where to find it?

It is here: http://repo.or.cz/w/org-mode.git

But that's right, we should mention it on the http://orgmode.org page.

-- 
Bastien

Re: Re: Please test links

[Carsten Dominik]

On Mar 15, 2008, at 10:48 AM, Bastien wrote:

> Leo <sdl.web@gmail.com> writes:
>
>> On 2008-03-15 08:24 +0000, Carsten Dominik wrote:
>>> Please report back which of these link types you are using, and
>>> if they are still working after a pull in your it repo.
>>> If not, I'd appreciate detailed backtraces so that this remaining
>>> issues can be fixed.
>>
>> The repo is not on orgmode.org. Where to find it?
>
> It is here: http://repo.or.cz/w/org-mode.git
>
> But that's right, we should mention it on the http://orgmode.org page.
>

For those of you who want to do some testing, but don't want to use  
the git repo,
I have put files org-5.23a-test.zip and org-5.23a-test-tag-gz on  
orgmode.org.

- Carsten

Re: Please test links

[Thomas Baumann]

Hi Carsten,

I just had a quick look at the following link types

bbdb: works ok both ways

mh-e: links already present work.
setting links is broken and the format of the description is weird

Below is the result from debugging org-mhe-store-link. It seems that the
function is ok, but then the link is stored as "file link".

Cheers
Thomas


Result: mh-folder-mode

Result: t

Result: t
 [3 times]
Result: "Carsten Dominik <dominik@science.uva.nl>"
 [2 times]
Result: "thomas.baumann@ch.tum.de"
 [2 times]
Result: "<E5638AFA-6420-4581-B714-C77FA67FB575@science.uva.nl>"
 [2 times]
Result: "Re: Copyright mh support org-mode "
 [2 times]
Result: "Carsten Dominik <dominik@science.uva.nl>"

Result: "thomas.baumann@ch.tum.de"

Result: "Re: Copyright mh support org-mode "

Result: "<E5638AFA-6420-4581-B714-C77FA67FB575@science.uva.nl>"

Result: (:type "mh" :from "Carsten Dominik <dominik@science.uva.nl>" :to "thomas.baumann@ch.tum.de" :subject "Re: Copyright mh support org-mode " :message-id "<E5638AFA-6420-4581-B714-C77FA67FB575@science.uva.nl>" :fromname "Carsten Dominik" :fromaddress "dominik@science.uva.nl" :toname "thomas baumann" :toaddress "thomas.baumann@ch.tum.de" :fromto "from %f")
 [3 times]
Result: "Email from Carsten Dominik: Re: Copyright mh support org-m"

Result: "Email from Carsten Dominik: Re: Copyright mh support org-m"
 [4 times]
Result: "+iwc"
 [2 times]
Result: "<E5638AFA-6420-4581-B714-C77FA67FB575@science.uva.nl>"

Result: "E5638AFA-6420-4581-B714-C77FA67FB575@science.uva.nl"

Result: "mhe:+iwc#E5638AFA-6420-4581-B714-C77FA67FB575@science.uva.nl"

Result: "mhe:+iwc#E5638AFA-6420-4581-B714-C77FA67FB575@science.uva.nl"
 [2 times]
Result: "mhe:+iwc#E5638AFA-6420-4581-B714-C77FA67FB575@science.uva.nl"

Result: "Email from Carsten Dominik: Re: Copyright mh support org-m"

Result: nil

Result: nil

Result: nil

Stored: file:~/GMXmail/iwc/::11108 t03 14 Carsten Dominik Re Copyright
mh support org mode Apple Mail 1 453904482 Conte

Re: Re: Please test links

[Carsten Dominik]

Hi Thomas, thanks so much for trying.

I have pushed an attempt to fix this to the git repo,
can you give it another try?

Thanks.

- Carsten

On Mar 15, 2008, at 5:36 PM, Thomas Baumann wrote:

> Hi Carsten,
>
> I just had a quick look at the following link types
>
> bbdb: works ok both ways
>
> mh-e: links already present work.
> setting links is broken and the format of the description is weird
>
> Below is the result from debugging org-mhe-store-link. It seems that  
> the
> function is ok, but then the link is stored as "file link".
>
> Cheers
> Thomas
>
>
> Result: mh-folder-mode
>
> Result: t
>
> Result: t
> [3 times]
> Result: "Carsten Dominik <dominik@science.uva.nl>"
> [2 times]
> Result: "thomas.baumann@ch.tum.de"
> [2 times]
> Result: "<E5638AFA-6420-4581-B714-C77FA67FB575@science.uva.nl>"
> [2 times]
> Result: "Re: Copyright mh support org-mode "
> [2 times]
> Result: "Carsten Dominik <dominik@science.uva.nl>"
>
> Result: "thomas.baumann@ch.tum.de"
>
> Result: "Re: Copyright mh support org-mode "
>
> Result: "<E5638AFA-6420-4581-B714-C77FA67FB575@science.uva.nl>"
>
> Result: (:type "mh" :from "Carsten Dominik  
> <dominik@science.uva.nl>" :to "thomas.baumann@ch.tum.de" :subject  
> "Re: Copyright mh support org-mode " :message-id "<E5638AFA-6420-4581-B714-C77FA67FB575@science.uva.nl 
> >" :fromname "Carsten Dominik" :fromaddress  
> "dominik@science.uva.nl" :toname "thomas baumann" :toaddress "thomas.baumann@ch.tum.de 
> " :fromto "from %f")
> [3 times]
> Result: "Email from Carsten Dominik: Re: Copyright mh support org-m"
>
> Result: "Email from Carsten Dominik: Re: Copyright mh support org-m"
> [4 times]
> Result: "+iwc"
> [2 times]
> Result: "<E5638AFA-6420-4581-B714-C77FA67FB575@science.uva.nl>"
>
> Result: "E5638AFA-6420-4581-B714-C77FA67FB575@science.uva.nl"
>
> Result: "mhe:+iwc#E5638AFA-6420-4581-B714-C77FA67FB575@science.uva.nl"
>
> Result: "mhe:+iwc#E5638AFA-6420-4581-B714-C77FA67FB575@science.uva.nl"
> [2 times]
> Result: "mhe:+iwc#E5638AFA-6420-4581-B714-C77FA67FB575@science.uva.nl"
>
> Result: "Email from Carsten Dominik: Re: Copyright mh support org-m"
>
> Result: nil
>
> Result: nil
>
> Result: nil
>
> Stored: file:~/GMXmail/iwc/::11108 t03 14 Carsten Dominik Re Copyright
> mh support org mode Apple Mail 1 453904482 Conte
>
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

Re: Please test links

[Bernt Hansen]

Carsten Dominik <dominik@science.uva.nl> writes:

> Please report back which of these link types you are using, and
> if they are still working after a pull in your it repo.
> If not, I'd appreciate detailed backtraces so that this remaining
> issues can be fixed.

I use bbdb and gnus links.

Attempting to org-store-link in a gnus mail message

Debugger entered--Lisp error: (error "Cannot link to a buffer which is not visiting a file")
  signal(error ("Cannot link to a buffer which is not visiting a file"))
  error("Cannot link to a buffer which is not visiting a file")
  (cond ((run-hook-with-args-until-success ...) (setq link ... desc ...)) ((eq major-mode ...) (let ... ... ...)) ((eq major-mode ...) (setq cpltxt ... link ...) (org-store-link-props :type "w3" :url ...)) ((eq major-mode ...) (setq cpltxt ... link ...) (org-store-link-props :type "w3m" :url ...)) ((setq search ...) (setq link ...) (setq cpltxt ...)) ((eq major-mode ...) (setq cpltxt ... link ...) (org-store-link-props :type "image" :file buffer-file-name)) ((eq major-mode ...) (setq cpltxt ... link ...)) ((and buffer-file-name ...) (setq cpltxt ...) (when ... ...) (if ... ...) (setq link ...)) ((buffer-file-name ...) (setq cpltxt ...) (when ... ... ...) (setq link ...)) ((interactive-p) (error "Cannot link to a buffer which is not visiting a file")) (t (setq link nil)))
  (let (link cpltxt desc description search txt) (cond (... ...) (... ...) (... ... ...) (... ... ...) (... ... ...) (... ... ...) (... ...) (... ... ... ... ...) (... ... ... ...) (... ...) (t ...)) (if (consp link) (setq cpltxt ... link ...)) (setq link (or link cpltxt) desc (or desc cpltxt)) (if (equal desc "NONE") (setq desc nil)) (if (and ... link) (progn ... ...) (and link ...)))
  org-store-link(nil)
  call-interactively(org-store-link)
  execute-extended-command(nil)
  call-interactively(execute-extended-command)

Regards,
Bernt

Re: Please test links

[Thomas Baumann]

quickly installing and learning git....
... and mhe-links still failing

I guess the error comes from 

(defun org-add-link-props (&rest plist)
  "Add these properties to the link property list."
  (let (key value)
    (while plist
      (setq key (pop plist) value (pop plist))
      (setq org-store-link-plist
	    (plist-put org-store-link-plist key value)))))

returning always nil because of (while plist ...

thus

(defun org-mhe-store-link ()
  "Store a link to an MHE folder or message."
  (when (or (equal major-mode 'mh-folder-mode)
	    (equal major-mode 'mh-show-mode))
    (let ((from (org-mhe-get-header "From:"))
	  (to (org-mhe-get-header "To:"))
	  (message-id (org-mhe-get-header "Message-Id:"))
	  (subject (org-mhe-get-header "Subject:"))
	  link desc)
      (org-store-link-props :type "mh" :from from :to to
			    :subject subject :message-id message-id)
      (setq desc (org-email-link-description))
      (setq link (org-make-link "mhe:" (org-mhe-get-message-real-folder) "#"
				(org-remove-angle-brackets message-id)))
      (org-add-link-props :link link :description desc))))

returns nil and therefore org-store-link will not recognize the
successful mhe-link.

Cheers
Thomas

Re: Please test links

[Thomas Baumann]

Forgot to add:

(defun org-add-link-props (&rest plist)
  "Add these properties to the link property list."
  (let (key value)
    (while plist
      (setq key (pop plist) value (pop plist))
      (setq org-store-link-plist
	    (plist-put org-store-link-plist key value)))
    t))

does the trick but might be what we call "Jungbauernmethode" :-)

Re: Re: Please test links

[Carsten Dominik]

At least we got you to learn git! :-)


Thanks for the analysis, I have fixed this problem for all link
packages, thanks a lot!!!


Please, everyone, git it another shot.

Ahh, I don't know what I would do without all this help.

- Carsten

On Mar 15, 2008, at 9:17 PM, Thomas Baumann wrote:

> quickly installing and learning git....
> ... and mhe-links still failing
>
> I guess the error comes from
>
> (defun org-add-link-props (&rest plist)
>  "Add these properties to the link property list."
>  (let (key value)
>    (while plist
>      (setq key (pop plist) value (pop plist))
>      (setq org-store-link-plist
> 	    (plist-put org-store-link-plist key value)))))
>
> returning always nil because of (while plist ...
>
> thus
>
> (defun org-mhe-store-link ()
>  "Store a link to an MHE folder or message."
>  (when (or (equal major-mode 'mh-folder-mode)
> 	    (equal major-mode 'mh-show-mode))
>    (let ((from (org-mhe-get-header "From:"))
> 	  (to (org-mhe-get-header "To:"))
> 	  (message-id (org-mhe-get-header "Message-Id:"))
> 	  (subject (org-mhe-get-header "Subject:"))
> 	  link desc)
>      (org-store-link-props :type "mh" :from from :to to
> 			    :subject subject :message-id message-id)
>      (setq desc (org-email-link-description))
>      (setq link (org-make-link "mhe:" (org-mhe-get-message-real- 
> folder) "#"
> 				(org-remove-angle-brackets message-id)))
>      (org-add-link-props :link link :description desc))))
>
> returns nil and therefore org-store-link will not recognize the
> successful mhe-link.
>
> Cheers
> Thomas
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

Re: Please test links

[Bernt Hansen]

Bernt Hansen <bernt@norang.ca> writes:

> Carsten Dominik <dominik@science.uva.nl> writes:
>
>> Please report back which of these link types you are using, and
>> if they are still working after a pull in your it repo.
>> If not, I'd appreciate detailed backtraces so that this remaining
>> issues can be fixed.
>
> I use bbdb and gnus links.
>
> Attempting to org-store-link in a gnus mail message
>
> Debugger entered--Lisp error: (error "Cannot link to a buffer which is not visiting a file")
>   signal(error ("Cannot link to a buffer which is not visiting a file"))
>   error("Cannot link to a buffer which is not visiting a file")
>   (cond ((run-hook-with-args-until-success ...) (setq link ... desc ...)) ((eq major-mode ...) (let ... ... ...)) ((eq major-mode ...) (setq cpltxt ... link ...) (org-store-link-props :type "w3" :url ...)) ((eq major-mode ...) (setq cpltxt ... link ...) (org-store-link-props :type "w3m" :url ...)) ((setq search ...) (setq link ...) (setq cpltxt ...)) ((eq major-mode ...) (setq cpltxt ... link ...) (org-store-link-props :type "image" :file buffer-file-name)) ((eq major-mode ...) (setq cpltxt ... link ...)) ((and buffer-file-name ...) (setq cpltxt ...) (when ... ...) (if ... ...) (setq link ...)) ((buffer-file-name ...) (setq cpltxt ...) (when ... ... ...) (setq link ...)) ((interactive-p) (error "Cannot link to a buffer which is not visiting a file")) (t (setq link nil)))
>   (let (link cpltxt desc description search txt) (cond (... ...) (... ...) (... ... ...) (... ... ...) (... ... ...) (... ... ...) (... ...) (... ... ... ... ...) (... ... ... ...) (... ...) (t ...)) (if (consp link) (setq cpltxt ... link ...)) (setq link (or link cpltxt) desc (or desc cpltxt)) (if (equal desc "NONE") (setq desc nil)) (if (and ... link) (progn ... ...) (and link ...)))
>   org-store-link(nil)
>   call-interactively(org-store-link)
>   execute-extended-command(nil)
>   call-interactively(execute-extended-command)

This works now.  Thanks.

-Bernt

Re: Please test links

[Thomas Baumann]

tested ok:

mhe,
bbdb,
info

Re: Re: Please test links

[Joel J. Adamson]

Bernt Hansen <bernt@norang.ca> writes:

> Bernt Hansen <bernt@norang.ca> writes:
>
>> Carsten Dominik <dominik@science.uva.nl> writes:
>>
>>> Please report back which of these link types you are using, and
>>> if they are still working after a pull in your it repo.
>>> If not, I'd appreciate detailed backtraces so that this remaining
>>> issues can be fixed.
>>
>> I use bbdb and gnus links.
>>
>> Attempting to org-store-link in a gnus mail message
>>

Howdy,

I updated from git this morning and

gnus
bbdb
hypertext (www)

all work just fine for me.

Joel
-- 
Joel J. Adamson
Biostatistician
Pediatric Psychopharmacology Research Unit
Massachusetts General Hospital
Boston, MA  02114
(617) 643-1432
(303) 880-3109
Public key: http://pgp.mit.edu

The information transmitted in this electronic communication is intended only
for the person or entity to whom it is addressed and may contain confidential
and/or privileged material. Any review, retransmission, dissemination or other
use of or taking of any action in reliance upon this information by persons or
entities other than the intended recipient is prohibited. If you received this
information in error, please contact the Compliance HelpLine at 800-856-1983 and
properly dispose of this information.

Re: Re: Please test links

[Carsten Dominik]

Excellent, thanks.

- Carsten

On Mar 17, 2008, at 4:28 PM, Joel J. Adamson wrote:

> Bernt Hansen <bernt@norang.ca> writes:
>
>> Bernt Hansen <bernt@norang.ca> writes:
>>
>>> Carsten Dominik <dominik@science.uva.nl> writes:
>>>
>>>> Please report back which of these link types you are using, and
>>>> if they are still working after a pull in your it repo.
>>>> If not, I'd appreciate detailed backtraces so that this remaining
>>>> issues can be fixed.
>>>
>>> I use bbdb and gnus links.
>>>
>>> Attempting to org-store-link in a gnus mail message
>>>
>
> Howdy,
>
> I updated from git this morning and
>
> gnus
> bbdb
> hypertext (www)
>
> all work just fine for me.
>
> Joel
> --  
> Joel J. Adamson
> Biostatistician
> Pediatric Psychopharmacology Research Unit
> Massachusetts General Hospital
> Boston, MA  02114
> (617) 643-1432
> (303) 880-3109
> Public key: http://pgp.mit.edu
>
> The information transmitted in this electronic communication is  
> intended only
> for the person or entity to whom it is addressed and may contain  
> confidential
> and/or privileged material. Any review, retransmission,  
> dissemination or other
> use of or taking of any action in reliance upon this information by  
> persons or
> entities other than the intended recipient is prohibited. If you  
> received this
> information in error, please contact the Compliance HelpLine at  
> 800-856-1983 and
> properly dispose of this information.
>
>
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode