* [PATCH] org-mode typos
@ 2008-12-16 17:41 Bernt Hansen
2008-12-17 6:42 ` Carsten Dominik
2008-12-17 8:09 ` Carsten Dominik
0 siblings, 2 replies; 8+ messages in thread
From: Bernt Hansen @ 2008-12-16 17:41 UTC (permalink / raw)
To: Carsten Dominik; +Cc: emacs-orgmode
Hi Carsten,
I decided to scour the org-mode code today and fix up all the typos I
could find easily.
I've pushed the result to my 'fix-typos' branch at
git://git.norang.ca/org-mode.
I also fixed up some whitespace changes as separate commits (which you
can drop if you don't like them).
Let me know if you want me to rework any of this. Most of the typos are
in comments and docstrings but there are a few that affect logic in
org.el and the commit message reflects that.
Please review. I'll tweak this series anyway you like so you can
include it easily including rebasing it on newer work that you may have
in progress.
Hope this helps!
Bernt Hansen (34):
Fix typos in org-agenda.el
Fix typos in org-archive.el
Fix typo in org-attach.el
Fix typo in org-bibtex.el comments
Fix typos in org-clock.el comments
Fix typos in org-colview.el
Fix typos on org-colview-xemacs.el
Fix typos in org.el
Fix typos in logic for org.el
Whitespace
Fix typos in org-exp.el
Whitespace
Fix typos in org-export-latex.el and whitespace
Whitespace
Fix comment typo in org-faces.el
Fix typos in description of org-id.el
Fix comment typo in org-irc.el
Whitespace
Fix typos in org-jsinfo.el
Whitespace
Fix typos in org-list.el
Fix typo in org-macs.el
Whitespace
Whitespace
Fix typos in org-mouse.el
Whitespace
Fix typo in org-plot.el
Whitespace
Fix typo in org-publish.el
Fix typos in org-remember.el
Whitespace
Fix typos in org-table.el
Fix typos in org-timer.el
Fix typos and whitespace in org-w3m.el
Diffstat follows:
lisp/org-agenda.el | 36 +++---
lisp/org-archive.el | 4 +-
lisp/org-attach.el | 2 +-
lisp/org-bibtex.el | 2 +-
lisp/org-clock.el | 4 +-
lisp/org-colview-xemacs.el | 12 +-
lisp/org-colview.el | 10 +-
lisp/org-exp.el | 268 ++++++++++++++++++++++----------------------
lisp/org-export-latex.el | 34 +++---
lisp/org-faces.el | 2 +-
lisp/org-id.el | 16 ++--
lisp/org-irc.el | 180 +++++++++++++++---------------
lisp/org-jsinfo.el | 4 +-
lisp/org-list.el | 224 ++++++++++++++++++------------------
lisp/org-macs.el | 2 +-
lisp/org-mhe.el | 62 +++++-----
lisp/org-mouse.el | 32 +++---
lisp/org-plot.el | 52 +++++-----
lisp/org-publish.el | 66 ++++++------
lisp/org-remember.el | 12 +-
lisp/org-table.el | 116 ++++++++++----------
lisp/org-timer.el | 6 +-
lisp/org-w3m.el | 12 +-
lisp/org.el | 98 ++++++++--------
24 files changed, 628 insertions(+), 628 deletions(-)
I can post the 34 patches here but decided that's probably not worth
flooding the list with this. If you are interested the patches are
available for viewing here:
http://git.norang.ca/?p=org-mode;a=shortlog;h=refs/heads/fix-typos
Cheers!
Bernt
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] org-mode typos
2008-12-16 17:41 [PATCH] org-mode typos Bernt Hansen
@ 2008-12-17 6:42 ` Carsten Dominik
2008-12-17 11:28 ` Bernt Hansen
2008-12-17 8:09 ` Carsten Dominik
1 sibling, 1 reply; 8+ messages in thread
From: Carsten Dominik @ 2008-12-17 6:42 UTC (permalink / raw)
To: Bernt Hansen; +Cc: emacs-orgmode
Hi Bernt,
wow, what a great job, and how well it reflects my being a terrible
typist. Thanks so much.
I'll take a look at them and then install. Did you change any code at
all, or only docstrings?
- Carsten
On Dec 16, 2008, at 6:41 PM, Bernt Hansen wrote:
> Hi Carsten,
>
> I decided to scour the org-mode code today and fix up all the typos I
> could find easily.
>
> I've pushed the result to my 'fix-typos' branch at
> git://git.norang.ca/org-mode.
>
> I also fixed up some whitespace changes as separate commits (which you
> can drop if you don't like them).
>
> Let me know if you want me to rework any of this. Most of the typos
> are
> in comments and docstrings but there are a few that affect logic in
> org.el and the commit message reflects that.
>
> Please review. I'll tweak this series anyway you like so you can
> include it easily including rebasing it on newer work that you may
> have
> in progress.
>
> Hope this helps!
>
> Bernt Hansen (34):
> Fix typos in org-agenda.el
> Fix typos in org-archive.el
> Fix typo in org-attach.el
> Fix typo in org-bibtex.el comments
> Fix typos in org-clock.el comments
> Fix typos in org-colview.el
> Fix typos on org-colview-xemacs.el
> Fix typos in org.el
> Fix typos in logic for org.el
> Whitespace
> Fix typos in org-exp.el
> Whitespace
> Fix typos in org-export-latex.el and whitespace
> Whitespace
> Fix comment typo in org-faces.el
> Fix typos in description of org-id.el
> Fix comment typo in org-irc.el
> Whitespace
> Fix typos in org-jsinfo.el
> Whitespace
> Fix typos in org-list.el
> Fix typo in org-macs.el
> Whitespace
> Whitespace
> Fix typos in org-mouse.el
> Whitespace
> Fix typo in org-plot.el
> Whitespace
> Fix typo in org-publish.el
> Fix typos in org-remember.el
> Whitespace
> Fix typos in org-table.el
> Fix typos in org-timer.el
> Fix typos and whitespace in org-w3m.el
>
> Diffstat follows:
>
> lisp/org-agenda.el | 36 +++---
> lisp/org-archive.el | 4 +-
> lisp/org-attach.el | 2 +-
> lisp/org-bibtex.el | 2 +-
> lisp/org-clock.el | 4 +-
> lisp/org-colview-xemacs.el | 12 +-
> lisp/org-colview.el | 10 +-
> lisp/org-exp.el | 268 +++++++++++++++++++++
> +----------------------
> lisp/org-export-latex.el | 34 +++---
> lisp/org-faces.el | 2 +-
> lisp/org-id.el | 16 ++--
> lisp/org-irc.el | 180 +++++++++++++++---------------
> lisp/org-jsinfo.el | 4 +-
> lisp/org-list.el | 224 ++++++++++++++++++------------------
> lisp/org-macs.el | 2 +-
> lisp/org-mhe.el | 62 +++++-----
> lisp/org-mouse.el | 32 +++---
> lisp/org-plot.el | 52 +++++-----
> lisp/org-publish.el | 66 ++++++------
> lisp/org-remember.el | 12 +-
> lisp/org-table.el | 116 ++++++++++----------
> lisp/org-timer.el | 6 +-
> lisp/org-w3m.el | 12 +-
> lisp/org.el | 98 ++++++++--------
> 24 files changed, 628 insertions(+), 628 deletions(-)
>
> I can post the 34 patches here but decided that's probably not worth
> flooding the list with this. If you are interested the patches are
> available for viewing here:
>
> http://git.norang.ca/?p=org-mode;a=shortlog;h=refs/heads/fix-typos
>
> Cheers!
> Bernt
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] org-mode typos
2008-12-16 17:41 [PATCH] org-mode typos Bernt Hansen
2008-12-17 6:42 ` Carsten Dominik
@ 2008-12-17 8:09 ` Carsten Dominik
1 sibling, 0 replies; 8+ messages in thread
From: Carsten Dominik @ 2008-12-17 8:09 UTC (permalink / raw)
To: Bernt Hansen; +Cc: emacs-orgmode
I just applied the patch. Thanks again.
- Carsten
On Dec 16, 2008, at 6:41 PM, Bernt Hansen wrote:
> Hi Carsten,
>
> I decided to scour the org-mode code today and fix up all the typos I
> could find easily.
>
> I've pushed the result to my 'fix-typos' branch at
> git://git.norang.ca/org-mode.
>
> I also fixed up some whitespace changes as separate commits (which you
> can drop if you don't like them).
>
> Let me know if you want me to rework any of this. Most of the typos
> are
> in comments and docstrings but there are a few that affect logic in
> org.el and the commit message reflects that.
>
> Please review. I'll tweak this series anyway you like so you can
> include it easily including rebasing it on newer work that you may
> have
> in progress.
>
> Hope this helps!
>
> Bernt Hansen (34):
> Fix typos in org-agenda.el
> Fix typos in org-archive.el
> Fix typo in org-attach.el
> Fix typo in org-bibtex.el comments
> Fix typos in org-clock.el comments
> Fix typos in org-colview.el
> Fix typos on org-colview-xemacs.el
> Fix typos in org.el
> Fix typos in logic for org.el
> Whitespace
> Fix typos in org-exp.el
> Whitespace
> Fix typos in org-export-latex.el and whitespace
> Whitespace
> Fix comment typo in org-faces.el
> Fix typos in description of org-id.el
> Fix comment typo in org-irc.el
> Whitespace
> Fix typos in org-jsinfo.el
> Whitespace
> Fix typos in org-list.el
> Fix typo in org-macs.el
> Whitespace
> Whitespace
> Fix typos in org-mouse.el
> Whitespace
> Fix typo in org-plot.el
> Whitespace
> Fix typo in org-publish.el
> Fix typos in org-remember.el
> Whitespace
> Fix typos in org-table.el
> Fix typos in org-timer.el
> Fix typos and whitespace in org-w3m.el
>
> Diffstat follows:
>
> lisp/org-agenda.el | 36 +++---
> lisp/org-archive.el | 4 +-
> lisp/org-attach.el | 2 +-
> lisp/org-bibtex.el | 2 +-
> lisp/org-clock.el | 4 +-
> lisp/org-colview-xemacs.el | 12 +-
> lisp/org-colview.el | 10 +-
> lisp/org-exp.el | 268 +++++++++++++++++++++
> +----------------------
> lisp/org-export-latex.el | 34 +++---
> lisp/org-faces.el | 2 +-
> lisp/org-id.el | 16 ++--
> lisp/org-irc.el | 180 +++++++++++++++---------------
> lisp/org-jsinfo.el | 4 +-
> lisp/org-list.el | 224 ++++++++++++++++++------------------
> lisp/org-macs.el | 2 +-
> lisp/org-mhe.el | 62 +++++-----
> lisp/org-mouse.el | 32 +++---
> lisp/org-plot.el | 52 +++++-----
> lisp/org-publish.el | 66 ++++++------
> lisp/org-remember.el | 12 +-
> lisp/org-table.el | 116 ++++++++++----------
> lisp/org-timer.el | 6 +-
> lisp/org-w3m.el | 12 +-
> lisp/org.el | 98 ++++++++--------
> 24 files changed, 628 insertions(+), 628 deletions(-)
>
> I can post the 34 patches here but decided that's probably not worth
> flooding the list with this. If you are interested the patches are
> available for viewing here:
>
> http://git.norang.ca/?p=org-mode;a=shortlog;h=refs/heads/fix-typos
>
> Cheers!
> Bernt
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] org-mode typos
2008-12-17 6:42 ` Carsten Dominik
@ 2008-12-17 11:28 ` Bernt Hansen
2008-12-17 11:37 ` Bernt Hansen
0 siblings, 1 reply; 8+ messages in thread
From: Bernt Hansen @ 2008-12-17 11:28 UTC (permalink / raw)
To: Carsten Dominik; +Cc: emacs-orgmode
Carsten Dominik <dominik@science.uva.nl> writes:
> wow, what a great job, and how well it reflects my being a terrible
> typist. Thanks so much.
> I'll take a look at them and then install. Did you change any code at
> all, or only docstrings?
The only one that changes code is
323c9cd36c1c87fa58c22b156cddc9694fa7b47f
so I put that in a separate commit.
-Bernt
>
> - Carsten
>
> On Dec 16, 2008, at 6:41 PM, Bernt Hansen wrote:
>
>> Hi Carsten,
>>
>> I decided to scour the org-mode code today and fix up all the typos I
>> could find easily.
>>
>> I've pushed the result to my 'fix-typos' branch at
>> git://git.norang.ca/org-mode.
>>
>> I also fixed up some whitespace changes as separate commits (which you
>> can drop if you don't like them).
>>
>> Let me know if you want me to rework any of this. Most of the typos
>> are
>> in comments and docstrings but there are a few that affect logic in
>> org.el and the commit message reflects that.
>>
>> Please review. I'll tweak this series anyway you like so you can
>> include it easily including rebasing it on newer work that you may
>> have
>> in progress.
>>
>> Hope this helps!
>>
>> Bernt Hansen (34):
>> Fix typos in org-agenda.el
>> Fix typos in org-archive.el
>> Fix typo in org-attach.el
>> Fix typo in org-bibtex.el comments
>> Fix typos in org-clock.el comments
>> Fix typos in org-colview.el
>> Fix typos on org-colview-xemacs.el
>> Fix typos in org.el
>> Fix typos in logic for org.el
>> Whitespace
>> Fix typos in org-exp.el
>> Whitespace
>> Fix typos in org-export-latex.el and whitespace
>> Whitespace
>> Fix comment typo in org-faces.el
>> Fix typos in description of org-id.el
>> Fix comment typo in org-irc.el
>> Whitespace
>> Fix typos in org-jsinfo.el
>> Whitespace
>> Fix typos in org-list.el
>> Fix typo in org-macs.el
>> Whitespace
>> Whitespace
>> Fix typos in org-mouse.el
>> Whitespace
>> Fix typo in org-plot.el
>> Whitespace
>> Fix typo in org-publish.el
>> Fix typos in org-remember.el
>> Whitespace
>> Fix typos in org-table.el
>> Fix typos in org-timer.el
>> Fix typos and whitespace in org-w3m.el
>>
>> Diffstat follows:
>>
>> lisp/org-agenda.el | 36 +++---
>> lisp/org-archive.el | 4 +-
>> lisp/org-attach.el | 2 +-
>> lisp/org-bibtex.el | 2 +-
>> lisp/org-clock.el | 4 +-
>> lisp/org-colview-xemacs.el | 12 +-
>> lisp/org-colview.el | 10 +-
>> lisp/org-exp.el | 268 +++++++++++++++++++++
>> +----------------------
>> lisp/org-export-latex.el | 34 +++---
>> lisp/org-faces.el | 2 +-
>> lisp/org-id.el | 16 ++--
>> lisp/org-irc.el | 180 +++++++++++++++---------------
>> lisp/org-jsinfo.el | 4 +-
>> lisp/org-list.el | 224 ++++++++++++++++++------------------
>> lisp/org-macs.el | 2 +-
>> lisp/org-mhe.el | 62 +++++-----
>> lisp/org-mouse.el | 32 +++---
>> lisp/org-plot.el | 52 +++++-----
>> lisp/org-publish.el | 66 ++++++------
>> lisp/org-remember.el | 12 +-
>> lisp/org-table.el | 116 ++++++++++----------
>> lisp/org-timer.el | 6 +-
>> lisp/org-w3m.el | 12 +-
>> lisp/org.el | 98 ++++++++--------
>> 24 files changed, 628 insertions(+), 628 deletions(-)
>>
>> I can post the 34 patches here but decided that's probably not worth
>> flooding the list with this. If you are interested the patches are
>> available for viewing here:
>>
>> http://git.norang.ca/?p=org-mode;a=shortlog;h=refs/heads/fix-typos
>>
>> Cheers!
>> Bernt
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] org-mode typos
2008-12-17 11:28 ` Bernt Hansen
@ 2008-12-17 11:37 ` Bernt Hansen
2008-12-17 11:48 ` Carsten Dominik
0 siblings, 1 reply; 8+ messages in thread
From: Bernt Hansen @ 2008-12-17 11:37 UTC (permalink / raw)
To: Carsten Dominik; +Cc: emacs-orgmode
Bernt Hansen <bernt@norang.ca> writes:
> Carsten Dominik <dominik@science.uva.nl> writes:
>
>> wow, what a great job, and how well it reflects my being a terrible
>> typist. Thanks so much.
>> I'll take a look at them and then install. Did you change any code at
>> all, or only docstrings?
>
> The only one that changes code is
> 323c9cd36c1c87fa58c22b156cddc9694fa7b47f
> so I put that in a separate commit.
and this one:
e0403e49eec371bd9817844ca8ece6760632de36
-Bernt
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] org-mode typos
2008-12-17 11:37 ` Bernt Hansen
@ 2008-12-17 11:48 ` Carsten Dominik
2008-12-17 11:53 ` Carsten Dominik
0 siblings, 1 reply; 8+ messages in thread
From: Carsten Dominik @ 2008-12-17 11:48 UTC (permalink / raw)
To: Bernt Hansen; +Cc: emacs-orgmode
On Dec 17, 2008, at 12:37 PM, Bernt Hansen wrote:
> Bernt Hansen <bernt@norang.ca> writes:
>
>> Carsten Dominik <dominik@science.uva.nl> writes:
>>
>>> wow, what a great job, and how well it reflects my being a terrible
>>> typist. Thanks so much.
>>> I'll take a look at them and then install. Did you change any
>>> code at
>>> all, or only docstrings?
>>
>> The only one that changes code is
>> 323c9cd36c1c87fa58c22b156cddc9694fa7b47f
>> so I put that in a separate commit.
>
> and this one:
> e0403e49eec371bd9817844ca8ece6760632de36
Hmm, how is the easiest way to look at what this particular commit does?
Stupid question?
- Carsten
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] org-mode typos
2008-12-17 11:48 ` Carsten Dominik
@ 2008-12-17 11:53 ` Carsten Dominik
2008-12-17 12:40 ` Bernt Hansen
0 siblings, 1 reply; 8+ messages in thread
From: Carsten Dominik @ 2008-12-17 11:53 UTC (permalink / raw)
To: Carsten Dominik; +Cc: Bernt Hansen, emacs-orgmode
I figured it out: gitk <commit>
Thanks, yes, these are fixes I definitely want in.
- Carsten
On Dec 17, 2008, at 12:48 PM, Carsten Dominik wrote:
>
> On Dec 17, 2008, at 12:37 PM, Bernt Hansen wrote:
>
>> Bernt Hansen <bernt@norang.ca> writes:
>>
>>> Carsten Dominik <dominik@science.uva.nl> writes:
>>>
>>>> wow, what a great job, and how well it reflects my being a terrible
>>>> typist. Thanks so much.
>>>> I'll take a look at them and then install. Did you change any
>>>> code at
>>>> all, or only docstrings?
>>>
>>> The only one that changes code is
>>> 323c9cd36c1c87fa58c22b156cddc9694fa7b47f
>>> so I put that in a separate commit.
>>
>> and this one:
>> e0403e49eec371bd9817844ca8ece6760632de36
>
> Hmm, how is the easiest way to look at what this particular commit
> does?
>
> Stupid question?
>
> - Carsten
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] org-mode typos
2008-12-17 11:53 ` Carsten Dominik
@ 2008-12-17 12:40 ` Bernt Hansen
0 siblings, 0 replies; 8+ messages in thread
From: Bernt Hansen @ 2008-12-17 12:40 UTC (permalink / raw)
To: Carsten Dominik; +Cc: emacs-orgmode
or git show SHA1
Carsten Dominik <dominik@science.uva.nl> writes:
> I figured it out: gitk <commit>
>
> Thanks, yes, these are fixes I definitely want in.
>
> - Carsten
>
> On Dec 17, 2008, at 12:48 PM, Carsten Dominik wrote:
>
>>
>> On Dec 17, 2008, at 12:37 PM, Bernt Hansen wrote:
>>
>>> Bernt Hansen <bernt@norang.ca> writes:
>>>
>>>> Carsten Dominik <dominik@science.uva.nl> writes:
>>>>
>>>>> wow, what a great job, and how well it reflects my being a terrible
>>>>> typist. Thanks so much.
>>>>> I'll take a look at them and then install. Did you change any
>>>>> code at
>>>>> all, or only docstrings?
>>>>
>>>> The only one that changes code is
>>>> 323c9cd36c1c87fa58c22b156cddc9694fa7b47f
>>>> so I put that in a separate commit.
>>>
>>> and this one:
>>> e0403e49eec371bd9817844ca8ece6760632de36
>>
>> Hmm, how is the easiest way to look at what this particular commit
>> does?
>>
>> Stupid question?
>>
>> - Carsten
>>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2008-12-17 12:40 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-16 17:41 [PATCH] org-mode typos Bernt Hansen
2008-12-17 6:42 ` Carsten Dominik
2008-12-17 11:28 ` Bernt Hansen
2008-12-17 11:37 ` Bernt Hansen
2008-12-17 11:48 ` Carsten Dominik
2008-12-17 11:53 ` Carsten Dominik
2008-12-17 12:40 ` Bernt Hansen
2008-12-17 8:09 ` Carsten Dominik
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).