suggestion for a fix to org-clock-in

suggestion for a fix to org-clock-in

[Nicolas Goaziou]

[-- Attachment #1: Type: text/plain, Size: 289 bytes --]

Hello,

For some time zone reason, my time-stamps look like this [2009-07-28
mar.]. Notice the dot after the name of the day.

This prevents the regexp inside org-clock-in to recognize it as a valid
clock format as thus to resume any started clock.

I suggest the following simple patch.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch to org-clock.el --]
[-- Type: text/x-diff, Size: 1090 bytes --]

From 0f149d1e515d017fed78fc5038127970843f9e81 Mon Sep 17 00:00:00 2001
From: Nicolas Goaziou <nicolas@Misty.(none)>
Date: Tue, 28 Jul 2009 20:55:06 +0200
Subject: [PATCH] Teach org-clock-in about other date formats

Depending on your time zone, the timestamps can have somewhat differents formats (ex.: [2009-07-28 mar. 21:00]).
This kind of format is now recognized as a valid clock time when it comes to resuming it.
---
 lisp/org-clock.el |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lisp/org-clock.el b/lisp/org-clock.el
index 7fa15e0..48a0741 100644
--- a/lisp/org-clock.el
+++ b/lisp/org-clock.el
@@ -558,7 +558,7 @@ the clocking selection, associated with the letter `d'."
 		   (looking-at
 		    (concat "^[ \t]* " org-clock-string
 			    " \\[\\([0-9]\\{4\\}-[0-9]\\{2\\}-[0-9]\\{2\\}"
-			    " +\\sw+ +[012][0-9]:[0-5][0-9]\\)\\][ \t]*$")))
+			    " +\\sw+\.? +[012][0-9]:[0-5][0-9]\\)\\][ \t]*$")))
 	      (message "Matched %s" (match-string 1))
 	      (setq ts (concat "[" (match-string 1) "]"))
 	      (goto-char (match-end 1))
-- 
1.6.0.4


[-- Attachment #3: Type: text/plain, Size: 44 bytes --]


Comments are welcome.

-- 
Nicolas Goaziou

[-- Attachment #4: Type: text/plain, Size: 204 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Remember: use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

Re: suggestion for a fix to org-clock-in

[Bastien]

Nicolas Goaziou <n.goaziou@neuf.fr> writes:

> For some time zone reason, my time-stamps look like this [2009-07-28
> mar.]. Notice the dot after the name of the day.

It's because Emacs recently changed the format for abbreviated days.  
If you could track when this change appeared, that'd be nice.

> This prevents the regexp inside org-clock-in to recognize it as a valid
> clock format as thus to resume any started clock.
>
> I suggest the following simple patch.

Applied, thanks!

-- 
 Bastien

Re: suggestion for a fix to org-clock-in

[Sébastien Vauban]

Hello,

Bastien wrote:
> Nicolas Goaziou <n.goaziou-8puV8OjpVw0@public.gmane.org> writes:
>
>> For some time zone reason, my time-stamps look like this [2009-07-28
>> mar.]. Notice the dot after the name of the day.
>
> It's because Emacs recently changed the format for abbreviated days.
> If you could track when this change appeared, that'd be nice.

Isn't it simply the way it always has been for French abbreviations of
weekdays?

Seb

-- 
Sébastien Vauban



_______________________________________________
Emacs-orgmode mailing list
Remember: use `Reply All' to send replies to the list.
Emacs-orgmode-mXXj517/zsQ@public.gmane.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

Re: Re: suggestion for a fix to org-clock-in

[Bastien]

Sébastien Vauban <wxhgmqzgwmuf@spammotel.com> writes:

> Isn't it simply the way it always has been for French abbreviations of
> weekdays?

I might be wrong but I don't think so.  

I even remember I found this weird to have this dot after the
abbreviation - I thought: "Gee, this will break things in Org."
I looked for broken functions and couldn't find some.  

I'm nearly glad someone found one :)

-- 
 Bastien

Re: suggestion for a fix to org-clock-in

[Sébastien Vauban]

Hello,

> Bastien wrote:
>> Nicolas Goaziou <n.goaziou-8puV8OjpVw0@public.gmane.org> writes:
>>
>>> For some time zone reason, my time-stamps look like this [2009-07-28
>>> mar.]. Notice the dot after the name of the day.
>>
>> It's because Emacs recently changed the format for abbreviated days.
>> If you could track when this change appeared, that'd be nice.
>
> Isn't it simply the way it always has been for French abbreviations of
> weekdays?

I confirm you, having tested it, that the point is there when under EmacsW32
and French regional settings for Windows.

Seb

-- 
Sébastien Vauban



_______________________________________________
Emacs-orgmode mailing list
Remember: use `Reply All' to send replies to the list.
Emacs-orgmode-mXXj517/zsQ@public.gmane.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

Re: suggestion for a fix to org-clock-in

[Carsten Dominik]

Hi,

I think the dot after the abbreviated month should be considered a bug.
What locales are doing this?  Maybe send a bug report to Emacs?

- Carsten

On Jul 28, 2009, at 9:48 PM, Nicolas Goaziou wrote:

> Hello,
>
> For some time zone reason, my time-stamps look like this [2009-07-28
> mar.]. Notice the dot after the name of the day.
>
> This prevents the regexp inside org-clock-in to recognize it as a  
> valid
> clock format as thus to resume any started clock.
>
> I suggest the following simple patch.
>
> From 0f149d1e515d017fed78fc5038127970843f9e81 Mon Sep 17 00:00:00 2001
> From: Nicolas Goaziou <nicolas@Misty.(none)>
> Date: Tue, 28 Jul 2009 20:55:06 +0200
> Subject: [PATCH] Teach org-clock-in about other date formats
>
> Depending on your time zone, the timestamps can have somewhat  
> differents formats (ex.: [2009-07-28 mar. 21:00]).
> This kind of format is now recognized as a valid clock time when it  
> comes to resuming it.
> ---
> lisp/org-clock.el |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/lisp/org-clock.el b/lisp/org-clock.el
> index 7fa15e0..48a0741 100644
> --- a/lisp/org-clock.el
> +++ b/lisp/org-clock.el
> @@ -558,7 +558,7 @@ the clocking selection, associated with the  
> letter `d'."
> 		   (looking-at
> 		    (concat "^[ \t]* " org-clock-string
> 			    " \\[\\([0-9]\\{4\\}-[0-9]\\{2\\}-[0-9]\\{2\\}"
> -			    " +\\sw+ +[012][0-9]:[0-5][0-9]\\)\\][ \t]*$")))
> +			    " +\\sw+\.? +[012][0-9]:[0-5][0-9]\\)\\][ \t]*$")))
> 	      (message "Matched %s" (match-string 1))
> 	      (setq ts (concat "[" (match-string 1) "]"))
> 	      (goto-char (match-end 1))
> -- 
> 1.6.0.4
>
>
> Comments are welcome.
>
> -- 
> Nicolas Goaziou
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

Re: suggestion for a fix to org-clock-in

[Nicolas Goaziou]

Carsten Dominik <carsten.dominik@gmail.com> writes:

> Hi,
>
> I think the dot after the abbreviated month should be considered a bug.
> What locales are doing this?  Maybe send a bug report to Emacs?
>
> - Carsten

Hello,

Actually, the dot is after the abbreviated day. The locale is
fr_FR.UTF-8.

I'm not sure it is a bug as it is typographically correct and because
'date +%a' gives me the same result.

-- 
Nicolas Goaziou

Re: suggestion for a fix to org-clock-in

[Carsten Dominik]

On Aug 3, 2009, at 10:34 AM, Nicolas Goaziou wrote:

> Carsten Dominik <carsten.dominik@gmail.com> writes:
>
>> Hi,
>>
>> I think the dot after the abbreviated month should be considered a  
>> bug.
>> What locales are doing this?  Maybe send a bug report to Emacs?
>>
>> - Carsten
>
> Hello,
>
> Actually, the dot is after the abbreviated day. The locale is
> fr_FR.UTF-8.
>
> I'm not sure it is a bug as it is typographically correct and because
> 'date +%a' gives me the same result.

But it seems to be like this only in this specific locale....

- Carsten