From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: Re: Bug: #+ATTR_LaTeX broken in LaTeX export [6.36trans (release_6.36.461.g798e)] Date: Thu, 01 Jul 2010 00:22:16 +0200 Message-ID: <87hbkkgnzb.wl%n.goaziou@gmail.com> References: <878w5w2w5y.fsf@thinkpad.tsdh.de> <87fx04qp9x.fsf@mundaneum.com> <871vbouu7f.fsf@gmail.com> <87iq50griq.wl%n.goaziou@gmail.com> <8739w4tdo9.fsf@gmail.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: Received: from [140.186.70.92] (port=39686 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OU5fl-0002vD-Th for emacs-orgmode@gnu.org; Wed, 30 Jun 2010 18:22:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OU5fk-00088z-Qo for emacs-orgmode@gnu.org; Wed, 30 Jun 2010 18:22:25 -0400 Received: from mail-wy0-f169.google.com ([74.125.82.169]:41105) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OU5fk-00088v-Kx for emacs-orgmode@gnu.org; Wed, 30 Jun 2010 18:22:24 -0400 Received: by wyb39 with SMTP id 39so1460931wyb.0 for ; Wed, 30 Jun 2010 15:22:23 -0700 (PDT) In-Reply-To: <8739w4tdo9.fsf@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Eric Schulte Cc: =?UTF-8?B?U8OpYmFzdGllbg==?= Vauban , emacs-orgmode@gnu.org I don't know about #+BEGIN_changemargin (but as far as I understand, it's coming from org-exp-blocks and should be handled during preprocess-hook, so it is beyond the scope of this patch). There is some design choice involved here. Until recently, there was a catch-all function called org-export-handle-comments that was called at the end of the export process and removed any line starting with a #. It was certainly useful, but made things hard to debug : had the #+ATTR_LaTeX line been misinterpreted or just silently deleted ? At the moment, org-export-handle-comments only handles... comments. But everything that is not comments has to be taken care of somewhere else. For example, org-export-attach-captions-and-attributes deletes #+CAPTIONS and #+ATTR_backend in the process, and org-export-select-backend-specific-text deletes #+backend and #+ATTR_backend not used (that's what my patch do, actually). If you want to apply my patch (v. 2), we have to define a function to remove #+TBLFM and #+TBLNAME lines because there is none at the moment. It could be org-export-special-table-lines but it doesn't look like it's the purpose of that function. Otherwise, you can just ignore the patch and bring back the full power to org-export-handle-comments. I personally prefer avoiding do-it-all functions. But I'm not a maintainer. Regards, -- Nicolas