From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Eric Schulte" <schulte.eric@gmail.com>
Subject: Re: [Babel] Better messages for code block execution
Date: Mon, 06 Dec 2010 08:05:43 -0700
Message-ID: <87hberuejp.fsf@gmail.com>
References: <80aakjynwr.fsf@missioncriticalit.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from [140.186.70.92] (port=39045 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PPceS-00082c-Kb
	for emacs-orgmode@gnu.org; Mon, 06 Dec 2010 10:06:53 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <schulte.eric@gmail.com>) id 1PPceR-0002SU-6D
	for emacs-orgmode@gnu.org; Mon, 06 Dec 2010 10:06:52 -0500
Received: from mail-vw0-f41.google.com ([209.85.212.41]:56243)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <schulte.eric@gmail.com>) id 1PPceR-0002SH-3P
	for emacs-orgmode@gnu.org; Mon, 06 Dec 2010 10:06:51 -0500
Received: by vws10 with SMTP id 10so5128575vws.0
	for <emacs-orgmode@gnu.org>; Mon, 06 Dec 2010 07:06:50 -0800 (PST)
In-Reply-To: <80aakjynwr.fsf@missioncriticalit.com> (=?utf-8?Q?=22S=C3=A9b?=
	=?utf-8?Q?astien?= Vauban"'s
	message of "Mon, 06 Dec 2010 15:30:12 +0100")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: =?utf-8?Q?S=C3=A9bastien?= Vauban <wxhgmqzgwmuf@spammotel.com>
Cc: emacs-orgmode@gnu.org

Hi Seb,

Thanks for the suggestion, I've just applied a slight alteration of
these improved messages.

#+begin_src diff
  diff --git a/lisp/ob.el b/lisp/ob.el
  index dd285db..fe392d9 100644
  --- a/lisp/ob.el
  +++ b/lisp/ob.el
  @@ -1504,9 +1504,9 @@ code ---- the results are extracted in the syntax o=
f the source
            (indent-rigidly beg end indent))))
       (if (=3D (length result) 0)
          (if (member "value" result-params)
  -	    (message "No result returned by source block")
  -	  (message "Source block produced no output"))
  -      (message "finished"))))
  +	    (message "Code block returned no value.")
  +	  (message "Code block produced no output."))
  +      (message "Code block evaluation complete."))))

   (defun org-babel-remove-result (&optional info)
     "Remove the result of the current source block."
#+end_src

Best -- Eric

S=C3=A9bastien Vauban <wxhgmqzgwmuf@spammotel.com> writes:

> Hi,
>
> Here are a couple of better (IMHO) messages for what occurs during source
> block execution:
>
> diff --git a/lisp/ob.el b/lisp/ob.el
> index dd285db..05bb320 100644
> --- a/lisp/ob.el
> +++ b/lisp/ob.el
> @@ -1504,9 +1504,9 @@ code ---- the results are extracted in the syntax o=
f the source
>  	  (indent-rigidly beg end indent))))
>      (if (=3D (length result) 0)
>  	(if (member "value" result-params)
> -	    (message "No result returned by source block")
> -	  (message "Source block produced no output"))
> -      (message "finished"))))
> +	    (message "Source block returned no value.")
> +	  (message "Source block produced no output."))
> +      (message "Inserted results of source block execution."))))
>=20=20
>  (defun org-babel-remove-result (&optional info)
>    "Remove the result of the current source block."
>
> Best regards,
>   Seb