emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: "Eric Schulte" <schulte.eric@gmail.com>
To: "Sébastien Vauban" <wxhgmqzgwmuf@spammotel.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [Babel] Better messages for code block execution
Date: Mon, 06 Dec 2010 08:05:43 -0700	[thread overview]
Message-ID: <87hberuejp.fsf@gmail.com> (raw)
In-Reply-To: <80aakjynwr.fsf@missioncriticalit.com> ("Sébastien Vauban"'s message of "Mon, 06 Dec 2010 15:30:12 +0100")

Hi Seb,

Thanks for the suggestion, I've just applied a slight alteration of
these improved messages.

#+begin_src diff
  diff --git a/lisp/ob.el b/lisp/ob.el
  index dd285db..fe392d9 100644
  --- a/lisp/ob.el
  +++ b/lisp/ob.el
  @@ -1504,9 +1504,9 @@ code ---- the results are extracted in the syntax of the source
            (indent-rigidly beg end indent))))
       (if (= (length result) 0)
          (if (member "value" result-params)
  -	    (message "No result returned by source block")
  -	  (message "Source block produced no output"))
  -      (message "finished"))))
  +	    (message "Code block returned no value.")
  +	  (message "Code block produced no output."))
  +      (message "Code block evaluation complete."))))

   (defun org-babel-remove-result (&optional info)
     "Remove the result of the current source block."
#+end_src

Best -- Eric

Sébastien Vauban <wxhgmqzgwmuf@spammotel.com> writes:

> Hi,
>
> Here are a couple of better (IMHO) messages for what occurs during source
> block execution:
>
> diff --git a/lisp/ob.el b/lisp/ob.el
> index dd285db..05bb320 100644
> --- a/lisp/ob.el
> +++ b/lisp/ob.el
> @@ -1504,9 +1504,9 @@ code ---- the results are extracted in the syntax of the source
>  	  (indent-rigidly beg end indent))))
>      (if (= (length result) 0)
>  	(if (member "value" result-params)
> -	    (message "No result returned by source block")
> -	  (message "Source block produced no output"))
> -      (message "finished"))))
> +	    (message "Source block returned no value.")
> +	  (message "Source block produced no output."))
> +      (message "Inserted results of source block execution."))))
>  
>  (defun org-babel-remove-result (&optional info)
>    "Remove the result of the current source block."
>
> Best regards,
>   Seb

  reply	other threads:[~2010-12-06 15:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-06 14:30 [Babel] Better messages for code block execution Sébastien Vauban
2010-12-06 15:05 ` Eric Schulte [this message]
  -- strict thread matches above, loose matches on Subject: below --
2010-12-06 14:31 Sébastien Vauban

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87hberuejp.fsf@gmail.com \
    --to=schulte.eric@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=wxhgmqzgwmuf@spammotel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).