[PATCH] Adding features to contrib/lisp/org-collector.el (propview)

[PATCH] Adding features to contrib/lisp/org-collector.el (propview)

[Jonathan BISSON]

[-- Attachment #1: Type: text/plain, Size: 1468 bytes --]

Hi there,


I did a small patch for org-collector.

Here are the changes :
- Adding a :colnames property, allowing to give the column names
(instead of displaying the function used to populate the table)
- Adding a :noquote property, allowing to remove the double quotes
around strings

I hope some of you would find it useful.

121a122,123
> 	    (noquote (plist-get params :noquote))
> 	    (colnames (plist-get params :colnames))
132a135
> 	  (setq stringformat (if noquote "%s" "%S"))
134c137,138
< 		       (org-propview-collect cols conds match scope inherit)))
---
> 		       (org-propview-collect cols stringformat conds match scope
inherit
> 					     (if colnames colnames cols)) stringformat))
170c174
< (defun org-propview-collect (cols &optional conds match scope inherit)
---
> (defun org-propview-collect (cols stringformat &optional conds match
scope inherit colnames)
194,195c198,199
<       (mapcar (lambda (el) (format "%S" el)) cols) ;; output headers
<       'hline) ;; ------------------------------------------------
---
>       (if colnames colnames (mapcar (lambda (el) (format stringformat
el)) cols))
>        'hline) ;; ------------------------------------------------
214c218
< (defun org-propview-to-table (results)
---
> (defun org-propview-to-table (results stringformat)
221c225
< 	(mapcar (lambda (el) (format "%S" el)) row)))
---
> 	(mapcar (lambda (el) (format stringformat el)) row)))


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 230 bytes --]

Re: [PATCH] Adding features to contrib/lisp/org-collector.el (propview)

[Bastien]

Hi Jonathan,

Jonathan BISSON <bissonjonathan@gmail.com> writes:

> I did a small patch for org-collector.

Thanks for this -- can you resend the patch by attaching 
it, instead of inserting it in the body of the email?  It 
is not readable here.

Thanks!

-- 
 Bastien

Re: [PATCH] Adding features to contrib/lisp/org-collector.el (propview)

[Eric Schulte]

Hi Jonathan,

This does sound useful.  Unfortunately your email client seems to have
mangled the patch, could you resend with the patch attached rather than
pasted inline?

Thanks -- Eric

Jonathan BISSON <bissonjonathan@gmail.com> writes:

> Hi there,
>
>
> I did a small patch for org-collector.
>
> Here are the changes :
> - Adding a :colnames property, allowing to give the column names
> (instead of displaying the function used to populate the table)
> - Adding a :noquote property, allowing to remove the double quotes
> around strings
>
> I hope some of you would find it useful.
>
> 121a122,123
>> 	    (noquote (plist-get params :noquote))
>> 	    (colnames (plist-get params :colnames))
> 132a135
>> 	  (setq stringformat (if noquote "%s" "%S"))
> 134c137,138
> < 		       (org-propview-collect cols conds match scope inherit)))
> ---
>> 		       (org-propview-collect cols stringformat conds match scope
> inherit
>> 					     (if colnames colnames cols)) stringformat))
> 170c174
> < (defun org-propview-collect (cols &optional conds match scope inherit)
> ---
>> (defun org-propview-collect (cols stringformat &optional conds match
> scope inherit colnames)
> 194,195c198,199
> <       (mapcar (lambda (el) (format "%S" el)) cols) ;; output headers
> <       'hline) ;; ------------------------------------------------
> ---
>>       (if colnames colnames (mapcar (lambda (el) (format stringformat
> el)) cols))
>>        'hline) ;; ------------------------------------------------
> 214c218
> < (defun org-propview-to-table (results)
> ---
>> (defun org-propview-to-table (results stringformat)
> 221c225
> < 	(mapcar (lambda (el) (format "%S" el)) row)))
> ---
>> 	(mapcar (lambda (el) (format stringformat el)) row)))
>

-- 
Eric Schulte
http://cs.unm.edu/~eschulte/

Re: [PATCH] Adding features to contrib/lisp/org-collector.el (propview)

[Jonathan BISSON]

[-- Attachment #1.1: Type: text/plain, Size: 349 bytes --]

On 10/28/2011 04:32 PM, Bastien wrote:
> Hi Jonathan,
> 
> Jonathan BISSON <bissonjonathan@gmail.com> writes:
> 
>> I did a small patch for org-collector.
> 
> Thanks for this -- can you resend the patch by attaching 
> it, instead of inserting it in the body of the email?  It 
> is not readable here.
> 
> Thanks!
> 

Here it is,


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: bjonnh.patch --]
[-- Type: text/x-patch; name="bjonnh.patch", Size: 1122 bytes --]

121a122,123
> 	    (noquote (plist-get params :noquote))
> 	    (colnames (plist-get params :colnames))
132a135
> 	  (setq stringformat (if noquote "%s" "%S"))
134c137,138
< 		       (org-propview-collect cols conds match scope inherit)))
---
> 		       (org-propview-collect cols stringformat conds match scope inherit 
> 					     (if colnames colnames cols)) stringformat))
170c174
< (defun org-propview-collect (cols &optional conds match scope inherit)
---
> (defun org-propview-collect (cols stringformat &optional conds match scope inherit colnames)
194,195c198,199
<       (mapcar (lambda (el) (format "%S" el)) cols) ;; output headers
<       'hline) ;; ------------------------------------------------
---
>       (if colnames colnames (mapcar (lambda (el) (format stringformat el)) cols))
>        'hline) ;; ------------------------------------------------
214c218
< (defun org-propview-to-table (results)
---
> (defun org-propview-to-table (results stringformat)
221c225
< 	(mapcar (lambda (el) (format "%S" el)) row)))
---
> 	(mapcar (lambda (el) (format stringformat el)) row)))

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 230 bytes --]

Re: [PATCH] Adding features to contrib/lisp/org-collector.el (propview)

[Bastien]

Jonathan BISSON <bissonjonathan@gmail.com> writes:

> Here it is,

Thanks for the quick reply -- since Eric also replied, I let 
him decide about this!

Best,

-- 
 Bastien

Re: [PATCH] Adding features to contrib/lisp/org-collector.el (propview)

[Eric Schulte]

Bastien <bzg@altern.org> writes:

> Jonathan BISSON <bissonjonathan@gmail.com> writes:
>
>> Here it is,
>
> Thanks for the quick reply -- since Eric also replied, I let 
> him decide about this!
>

[Eric] touches his nose only to realize it is already too late...

Hi Jonathan,

Sorry to ask for yet another re-submission, but would you mind
regenerating this patch using git diff, i.e.,

  cd org-mode/
  git diff > new-patch.patch

or even better you could commit your changes with git, and then generate
the patch using the git format-patch utility, with something like

  cd org-mode/
  git add contrib/lisp/org-collector.el
  git commit -m "your commit message"
  git format-patch -o /tmp/ HEAD~1

and then attaching the resulting patch file in your /tmp/ directory.
The reason I ask is that I'm unable to apply your current patch with
either the `git' or `patch' commands.

Thanks! -- Eric

-- 
Eric Schulte
http://cs.unm.edu/~eschulte/