From mboxrd@z Thu Jan 1 00:00:00 1970 From: Erik Hetzner Subject: Bug in org-log-into-drawer Date: Fri, 26 Oct 2012 23:09:35 -0700 Message-ID: <87hapgv42o.wl%egh@e6h.org> Reply-To: Erik Hetzner Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: multipart/mixed; boundary="Multipart_Fri_Oct_26_23:09:35_2012-1" Return-path: Received: from eggs.gnu.org ([208.118.235.92]:36844) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TRzaW-0007oQ-8j for emacs-orgmode@gnu.org; Sat, 27 Oct 2012 02:09:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TRzaU-0001pZ-O6 for emacs-orgmode@gnu.org; Sat, 27 Oct 2012 02:09:40 -0400 Received: from mail-ia0-f169.google.com ([209.85.210.169]:54855) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TRzaU-0001pU-J9 for emacs-orgmode@gnu.org; Sat, 27 Oct 2012 02:09:38 -0400 Received: by mail-ia0-f169.google.com with SMTP id h37so3375819iak.0 for ; Fri, 26 Oct 2012 23:09:37 -0700 (PDT) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode --Multipart_Fri_Oct_26_23:09:35_2012-1 Content-Type: text/plain; charset=US-ASCII Hi, Current the org-log-into-drawer function does not honor the value of the LOG_INTO_DRAWER property if the property has the value nil. For example, if the org-log-into-drawer variable is set to t, but we have the file: * Foo :PROPERTIES: :LOG_INTO_DRAWER: nil :END: ** TODO Bar org-mode will log changes to the TODO entry into a drawer. The attached patch fixes the issue, allowing a nil value of the LOG_INTO_DRAWER property to override a t value of the org-log-into-drawer variable. best, Erik --Multipart_Fri_Oct_26_23:09:35_2012-1 Content-Type: text/plain; type=patch; charset=US-ASCII Content-Disposition: attachment; filename="org-log-into-drawer-prop.diff" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2xpc3Avb3JnLmVsIGIvbGlzcC9vcmcuZWwKaW5kZXggNGU3OTEyNS4uMmFh NzBiZCAxMDA2NDQKLS0tIGEvbGlzcC9vcmcuZWwKKysrIGIvbGlzcC9vcmcuZWwKQEAgLTI1MTks OSArMjUxOSwxMCBAQCBhIHN1YnRyZWUuIgogICAiUmV0dXJuIHRoZSB2YWx1ZSBvZiBgb3JnLWxv Zy1pbnRvLWRyYXdlcicsIGJ1dCBsZXQgcHJvcGVydGllcyBvdmVycnVsZS4KIElmIHRoZSBjdXJy ZW50IGVudHJ5IGhhcyBvciBpbmhlcml0cyBhIExPR19JTlRPX0RSQVdFUiBwcm9wZXJ0eSwgaXQg d2lsbCBiZQogdXNlZCBpbnN0ZWFkIG9mIHRoZSBkZWZhdWx0IHZhbHVlLiIKLSAgKGxldCAoKHAg KG9yZy1lbnRyeS1nZXQgbmlsICJMT0dfSU5UT19EUkFXRVIiICdpbmhlcml0KSkpCisgIChsZXQg KChwIChvcmctZW50cnktZ2V0IG5pbCAiTE9HX0lOVE9fRFJBV0VSIiAnaW5oZXJpdCB0KSkpCiAg ICAgKGNvbmQKLSAgICAgKChvciAobm90IHApIChlcXVhbCBwICJuaWwiKSkgb3JnLWxvZy1pbnRv LWRyYXdlcikKKyAgICAgKChub3QgcCkgb3JnLWxvZy1pbnRvLWRyYXdlcikKKyAgICAgKChlcXVh bCBwICJuaWwiKSBuaWwpCiAgICAgICgoZXF1YWwgcCAidCIpICJMT0dCT09LIikKICAgICAgKHQg cCkpKSkKIAo= --Multipart_Fri_Oct_26_23:09:35_2012-1 Content-Type: text/plain; charset=US-ASCII Sent from my free software system . --Multipart_Fri_Oct_26_23:09:35_2012-1--