emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [PATCH] Nicer fontification for org-todo-list
@ 2012-11-02 17:47 Ingo Lohmar
  2012-11-02 17:50 ` Ingo Lohmar
  0 siblings, 1 reply; 7+ messages in thread
From: Ingo Lohmar @ 2012-11-02 17:47 UTC (permalink / raw)
  To: emacs-orgmode

Hi all,

recently I was bothered by a very minor thing in my custom agenda:
the headline showing the keywords is always using the "warning" face
for the selected keyword(s), instead of the proper faces used to
display to them everywhere else.  Attached is a patch that changes
this that should work under all conditions as far as I can see (and
tested).  Do you think this is useful?  I feel it is the right thing
(TM) to do.

I used a separate function for the propertization (is that a word?),
in case it might become useful elsewhere --- feel free to refactor
this to your liking.  I would be happy to see this change applied.

Standard disclaimer: Not using the git version, but works in the elpa
version from last night.

Regards,
Ingo

-----

--- org-agenda-orig.el	2012-11-02 18:26:43.848678550 +0100
+++ org-agenda.el	2012-11-02 18:43:23.377778537 +0100
@@ -4490,6 +4490,17 @@
 
 ;;; Agenda TODO list
 
+(defun org-propertize-todo-keyword-list (keywords)
+  (concat
+   (if (or (equal keywords "ALL") (not keywords))
+       (propertize "ALL" 'face 'warning)
+     (mapconcat
+      (lambda (kw)
+        (propertize kw 'face (org-get-todo-face kw)))
+      (org-split-string keywords "|")
+      "|"))
+   "\n"))
+
 (defvar org-select-this-todo-keyword nil)
 (defvar org-last-arg nil)
 
@@ -4550,9 +4561,7 @@
 				   (concat "ToDo: "
 					   (or org-select-this-todo-keyword "ALL"))))
 	(org-agenda-mark-header-line (point-min))
-	(setq pos (point))
-	(insert (or org-select-this-todo-keyword "ALL") "\n")
-	(add-text-properties pos (1- (point)) (list 'face 'org-warning))
+	(insert (org-propertize-todo-keyword-list org-select-this-todo-keyword))
 	(setq pos (point))
 	(unless org-agenda-multi
 	  (insert "Available with `N r': (0)[ALL]")

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2012-12-18 17:52 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-02 17:47 [PATCH] Nicer fontification for org-todo-list Ingo Lohmar
2012-11-02 17:50 ` Ingo Lohmar
2012-12-04 14:01   ` Ingo Lohmar
2012-12-04 14:39     ` Bastien
2012-12-06 20:14       ` Ingo Lohmar
2012-12-18 17:23         ` Ingo Lohmar
2012-12-18 17:51           ` Bastien

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).