From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: bug#10125: RFE: require and load-path-shadowing Date: Sat, 12 Jan 2013 14:34:29 +0100 Message-ID: <87hamm8qze.fsf@bzg.ath.cx> References: <87sj68eogm.fsf@Rainer.invalid> <87wqvjd7qa.fsf@Rainer.invalid> <87bocvcx9f.fsf__44551.6247455545$1357934081$gmane$org@Rainer.invalid> <87ip72n1v7.fsf@Rainer.invalid> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([208.118.235.92]:35097) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tu1Ec-0007bG-R0 for emacs-orgmode@gnu.org; Sat, 12 Jan 2013 08:35:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tu1EY-0004Qt-3d for emacs-orgmode@gnu.org; Sat, 12 Jan 2013 08:34:54 -0500 Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-Message-ID: In-Reply-To: <87ip72n1v7.fsf@Rainer.invalid> (Achim Gratz's message of "Sat, 12 Jan 2013 11:15:40 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Achim Gratz Cc: 10125@debbugs.gnu.org Achim Gratz writes: > Achim Gratz writes: >> Stefan Monnier writes: >>> Yes, this subroutine is never directly called from C, so placing an >>> advice should work just fine. I thought coding conventions prevented advising primitives? I does not look clean to advise `require' here, just for Org. > "Check whether a required feature has been shadowed by changing > `load-path' after it has been loaded and reload that feature from > current load-path in this case." I don't understand why we need this. This is at best a workaround to fix dirty installations. I updated Org's installation process yesterday: http://orgmode.org/org.html#Installation I made it clear that the user, if she wants to install Org on top of the pre-bundled version, must choose between on of the three methods. For each method, I explain how to set up the load-path (if needed) and org.el will load the correct org-loaddefs.el, resetting autoloads correctly. In org.el, no Org package is required before org-loaddefs.el is loaded. > This takes care of a situation when Org is activated after some parts of > it have already been loaded (maybe via autoload) and the load-path has > been changed inbetween. I don't see why this should happen. Setting the correct load-paths is the first thing user should do in their .emacs.el. -- Bastien