From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Lawrence Subject: [PATCH] tiny fixes in ox-ascii.el [was: Re: Bug: Footnotes break iCalendar export] Date: Sun, 21 Apr 2013 12:12:39 -0700 Message-ID: <87haiz1yvs.fsf_-_@berkeley.edu> References: <87li8c9a6f.fsf@berkeley.edu> <877gjwowok.fsf@bzg.ath.cx> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([208.118.235.92]:34345) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UTzeN-0006Gm-Rv for emacs-orgmode@gnu.org; Sun, 21 Apr 2013 15:10:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UTzeM-00013N-Va for emacs-orgmode@gnu.org; Sun, 21 Apr 2013 15:10:11 -0400 Received: from plane.gmane.org ([80.91.229.3]:42864) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UTzeM-00013C-OX for emacs-orgmode@gnu.org; Sun, 21 Apr 2013 15:10:10 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1UTzeM-0003b8-0Y for emacs-orgmode@gnu.org; Sun, 21 Apr 2013 21:10:10 +0200 Received: from c-67-164-33-170.hsd1.ca.comcast.net ([67.164.33.170]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 21 Apr 2013 21:10:10 +0200 Received: from richard.lawrence by c-67-164-33-170.hsd1.ca.comcast.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 21 Apr 2013 21:10:10 +0200 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org --=-=-= Here is a patch for a couple of tiny issues I encountered in ox-ascii.el while debugging ox-icalendar.el. Explanation: 1) There is no function called `org-ascii-footnote-definition' (though it looks like maybe there once was?), so I changed a reference to it to `ignore' to be more explicit. I'm not sure if this is the right thing to do -- maybe the point was to let the user define such a function if she wishes? That however would be inconsistent with the comment that such definitions are ignored (see below). 2) A tiny change to the comment explaining why there is no such function: footnote definitions are ignored because they are compiled by `org-ascii-inner-template', not `org-ascii-template'. Best, Richard --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=ox-ascii.el.patch diff --git a/lisp/ox-ascii.el b/lisp/ox-ascii.el index 2191539..4543c34 100644 --- a/lisp/ox-ascii.el +++ b/lisp/ox-ascii.el @@ -68,7 +68,7 @@ (export-block . org-ascii-export-block) (export-snippet . org-ascii-export-snippet) (fixed-width . org-ascii-fixed-width) - (footnote-definition . org-ascii-footnote-definition) + (footnote-definition . ignore) (footnote-reference . org-ascii-footnote-reference) (headline . org-ascii-headline) (horizontal-rule . org-ascii-horizontal-rule) @@ -1147,7 +1147,7 @@ CONTENTS is nil. INFO is a plist holding contextual information." ;;;; Footnote Definition ;; Footnote Definitions are ignored. They are compiled at the end of -;; the document, by `org-ascii-template'. +;; the document, by `org-ascii-inner-template'. ;;;; Footnote Reference --=-=-=--