emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <n.goaziou@gmail.com>
To: "R. Michael Weylandt" <michael.weylandt@gmail.com>
Cc: "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>
Subject: Re: Prepare release 8.2.6
Date: Mon, 07 Apr 2014 12:19:41 +0200	[thread overview]
Message-ID: <87ha65jvb6.fsf@gmail.com> (raw)
In-Reply-To: <CAAmySGM1D0reyx=o6U=vFS+pMbErfzDPk5ZiVp3hXXOEMYX5dQ@mail.gmail.com> (R. Michael Weylandt's message of "Sun, 6 Apr 2014 21:48:59 -0400")

Hello,

"R. Michael Weylandt" <michael.weylandt@gmail.com> writes:

> I'm not as familiar with org-element-context, but I think the attached
> is what you had in mind.

Thanks. Comments follow.

>> Another option for the problem at hand is to simply remove newline
>> characters in inline source blocks before executing them.
>
> That might be better but would require a bit more work:

It would require more work, but adding functions to
`fill-nobreak-predicate' has a cost, too.

It needs to be discussed, but I tend to think that it would be better to
allow newlines characters in macros and inline babel calls, even if it
means replacing them with a space when needed.

> at present,
> inline source blocks can't extend over multiple lines so org wouldn't
> recognize a construct like
>
> src_python[:exports results]{1 + 2 +
> 3 + 4}
>
> as an inline source block in the first place. Looking at
> org-inline-src-block-regexp I'm not sure why though.

Because there is everywhere [^...\n...], which means "no newline
characters, please". The same goes for ".*?", as "." cannot match
a newline character.

> +(defun org-fill-element-nobreak-p ()

Technically, it is about "objects", not elements.  So the function could
be named `org-fill-objects-nobreak-p'.

> +  "Non-nil when a new line at point would break an element which
> +  cannot be split over multiple lines."

Ditto. Also the first sentence in the docstring cannot be split into two
lines.

> +  (member (car (org-element-context))
> +	  '(inline-src-block macro)))

  (memq (org-element-type (org-element-context))
        ...)


Regards,

-- 
Nicolas Goaziou

  reply	other threads:[~2014-04-07 10:19 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-03  6:37 Prepare release 8.2.6 Bastien
2014-04-04  9:05 ` Sebastien Vauban
2014-04-04 11:51 ` Michael Weylandt
2014-04-05 16:41   ` R. Michael Weylandt
2014-04-05 19:18     ` Nicolas Goaziou
2014-04-07  1:48       ` R. Michael Weylandt
2014-04-07 10:19         ` Nicolas Goaziou [this message]
2014-04-17 19:58           ` Bastien
2014-04-04 14:32 ` Michael Weylandt
2014-04-05 16:45   ` R. Michael Weylandt
2014-04-05 19:27     ` Nicolas Goaziou
2014-04-05 21:48       ` York Zhao
2014-04-06 17:51       ` R. Michael Weylandt
2014-04-06 18:03         ` Nicolas Goaziou
2014-04-11  2:43         ` Eric Schulte
2014-04-13 17:02           ` R. Michael Weylandt
2014-04-17  6:26             ` Bastien
  -- strict thread matches above, loose matches on Subject: below --
2014-04-03  7:53 Bastien
2014-04-03  9:17 ` Alan Schmitt
2014-04-03 10:13 ` KDr2
2014-04-03 11:47 ` Rainer M Krug
2014-04-18 12:04   ` Bastien
2014-04-28 13:40     ` Rainer M Krug
2014-04-03 11:47 ` Rainer M Krug

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ha65jvb6.fsf@gmail.com \
    --to=n.goaziou@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=michael.weylandt@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).