From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bastien <bzg@gnu.org>
Subject: Re: [PATCH] Fix: Capture abort: (error: The mark is not set now, so
 there is no region)
Date: Fri, 23 May 2014 19:28:11 +0200
Message-ID: <87ha4gv1zo.fsf@bzg.ath.cx>
References: <CAHD9_tRzBRPy6LFem9zDFrqKf9Qzb4egvTg60FOpm+sTDuk21w@mail.gmail.com>
	<877g681jma.fsf@bzg.ath.cx>
	<CAHD9_tT9HN9K_N2CJU1+Fsxz2fyqAA8dwpLUA1gZGqMA7uGv9Q@mail.gmail.com>
	<87zji88vye.fsf@bzg.ath.cx>
	<CAHD9_tQSRupfv1ZaUH_6AZtuOBMo8ca+DxocjLfWTR-T0hmAsw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33178)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1WntGY-0000l3-E1
	for emacs-orgmode@gnu.org; Fri, 23 May 2014 13:28:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1WntGQ-0002Lw-Um
	for emacs-orgmode@gnu.org; Fri, 23 May 2014 13:28:22 -0400
Received: from mail-wg0-x22a.google.com ([2a00:1450:400c:c00::22a]:40812)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1WntGQ-0002Lr-Mi
	for emacs-orgmode@gnu.org; Fri, 23 May 2014 13:28:14 -0400
Received: by mail-wg0-f42.google.com with SMTP id y10so5032621wgg.13
	for <emacs-orgmode@gnu.org>; Fri, 23 May 2014 10:28:13 -0700 (PDT)
In-Reply-To: <CAHD9_tQSRupfv1ZaUH_6AZtuOBMo8ca+DxocjLfWTR-T0hmAsw@mail.gmail.com>
	(Alex Kosorukoff's message of "Fri, 23 May 2014 09:37:48 -0700")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Alex Kosorukoff <alex@3form.com>
Cc: emacs-orgmode@gnu.org

Hi Alex,

Alex Kosorukoff <alex@3form.com> writes:

> Excluding mark-active will work, the result will be the same as after
> my patch, except performance will not be the same. Excluding variable
> requires filtering the list of variables which takes O(n) whereas my
> patch takes O(1). Mark-active is nil before
> org-capture-steal-local-variables because this is a new buffer. It
> seems in this case setting it back to nil is faster than trying to
> preserve its original value nil.

I see what you mean but there is no performance issue here and not
copying the value of mark-active is cleaner than setting it back to
nil -- we never want to copy the value of the mark at all.

-- 
 Bastien