emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Samuel Wales <samologist@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: three bugs/misfeatures in org-reveal (or is org-reveal the wrong way to reveal around point?)
Date: Sat, 17 Jan 2015 09:54:53 +0100	[thread overview]
Message-ID: <87h9vpss6a.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CAJcAo8sS0h8E6eudkYCrtZpQ1Jz7KqX6ds8cEFqaeWEBshb5KQ@mail.gmail.com> (Samuel Wales's message of "Fri, 16 Jan 2015 18:23:44 -0700")

Hello,

Samuel Wales <samologist@gmail.com> writes:

> i think i found one of the bugs in org.el's org-show-context.  is
> anybody willing to confirm and fix it?
>
> On 8/5/13, Samuel Wales <samologist@gmail.com> wrote:
>>   ;; bug 1: when point is in entry text, the first child of that
>>   ;; entry shows, but its siblings (i.e. the other children) do

Siblings are other headlines at the same level, not children.

>>   ;; not show, even though i have org-show-siblings and
>>   ;; org-show-hierarchy-above both set to t.
>
>     (when following-p
>       ;; Show next sibling, or heading below text
>       (save-excursion
> 	(and (if heading-p (org-goto-sibling) (outline-next-heading))
> 	     (org-flag-heading nil))))
>     (when siblings-p (org-show-siblings))
>
> the part in the save-excursion needs to check for siblings-p also.

I don't understand why it should. SIBLINGS-P means "show all siblings".
This is handled later in the function.


Regards,

-- 
Nicolas Goaziou

  reply	other threads:[~2015-01-17  8:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-05 22:50 three bugs/misfeatures in org-reveal (or is org-reveal the wrong way to reveal around point?) Samuel Wales
2013-08-06  7:41 ` Sebastien Vauban
2013-08-07  3:37   ` Samuel Wales
2015-01-17  1:23 ` Samuel Wales
2015-01-17  8:54   ` Nicolas Goaziou [this message]
2015-01-17 19:46     ` Samuel Wales
2015-01-18  9:16       ` Nicolas Goaziou
2015-01-18 20:26         ` Samuel Wales
2015-01-21 21:24           ` Nicolas Goaziou
2015-01-23 21:52             ` Samuel Wales

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h9vpss6a.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=samologist@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).