emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Alan Schmitt <alan.schmitt@polytechnique.org>
Cc: emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] make options available for custom source environment in ox-latex
Date: Thu, 14 Jan 2016 11:47:10 +0100	[thread overview]
Message-ID: <87h9igphe9.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <m2mvs8xxjo.fsf@charm-ecran.irisa.fr> (Alan Schmitt's message of "Thu, 14 Jan 2016 11:31:07 +0100")

Hello,

Alan Schmitt <alan.schmitt@polytechnique.org> writes:

> Here is a small addition to the custom source environments for
> ox-latex.

Thank you. Some comments follow.

> +			   (?o .
> +			       ,(let ((local-options (plist-get attributes :options)))
> +				  (if local-options local-options ""))))))))

Shorter:

  (?o . ,(or (plist-get attributes :options) ""))

I think this should also be documented in
`org-latex-custom-lang-environments' docstring.

Could you send an updated patch?


Regards,

-- 
Nicolas Goaziou

  reply	other threads:[~2016-01-14 10:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-14 10:31 [PATCH] make options available for custom source environment in ox-latex Alan Schmitt
2016-01-14 10:47 ` Nicolas Goaziou [this message]
2016-01-14 13:40   ` Alan Schmitt
2016-01-16 14:11     ` Nicolas Goaziou
2016-01-18  8:59       ` Alan Schmitt
2016-01-18 11:28         ` Rasmus
2016-01-18 14:15           ` Alan Schmitt
2016-01-18 14:21             ` Rasmus
2016-01-18 14:30               ` Alan Schmitt
2016-01-18 14:31                 ` Rasmus
2016-01-18 14:41                   ` Alan Schmitt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h9igphe9.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=alan.schmitt@polytechnique.org \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).