From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: Bug: Write file while editing babel code block doesn't work as expected [8.3.4 (release_8.3.4-778-g8127b3 @ /usr/local/share/emacs/site-lisp/org/)] Date: Sun, 15 May 2016 09:40:03 +0200 Message-ID: <87h9dzwyzw.fsf@saiph.selenimh> References: <87vb2ki8vl.fsf@saiph.selenimh> <87eg969697.fsf@gmail.com> <87d1oq9mxn.fsf@saiph.selenimh> <20160515041152.GA1188@smoon.vl-lomov.ru> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50396) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b1qeo-0004hz-JA for emacs-orgmode@gnu.org; Sun, 15 May 2016 03:40:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b1qen-0007tc-MC for emacs-orgmode@gnu.org; Sun, 15 May 2016 03:40:10 -0400 Received: from relay4-d.mail.gandi.net ([2001:4b98:c:538::196]:49101) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b1qen-0007tR-GW for emacs-orgmode@gnu.org; Sun, 15 May 2016 03:40:09 -0400 In-Reply-To: <20160515041152.GA1188@smoon.vl-lomov.ru> (Vladimir Lomov's message of "Sun, 15 May 2016 12:11:52 +0800") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Vladimir Lomov Cc: emacs-orgmode@gnu.org Hello, Vladimir Lomov writes: > I have small example that worked before the commit, please see attached > Org document. While it's true this worked before, I don't consider it to be a regression. There was no guarantee that `save-buffer' would save the source buffer. In fact, I think instrumenting `save-buffer' is not a good idea, because it is surprising. Usually, minor modes change bindings instead of altering functions. You can bind `org-edit-src-save' to F2 in this case. Regards, -- Nicolas Goaziou