Re: [patch] more robust footnotes

[Rasmus <rasmus@gmx.us>]

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Hello,
>
> Rasmus <rasmus@gmx.us> writes:
>
>> Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
>>>
>>> I suggest to avoid calling repeatedly
>>> `org-export-get-footnote-definition'. Also, if the footnote reference is
>>> anonymous, there is no point in calling `org-element-map'. The following
>>> is more efficient:
>>>
>>>   (format "\\footnote{%s%s}"
>>>           (org-trim (org-export-data def info))
>>>           ;; Only insert a label if there exist another reference to def.
>>>           (cond
>>>            ((not label) "")
>>>            ((org-element-map (plist-get info :parse-tree) 'footnote-reference
>>>               (lambda (f)
>>>                 (and (not (eq f footnote-reference))
>>>                      (equal (org-element-property :label f) label)
>>>                      (org-latex--label def info t t)))
>>>               info t))
>>>            (t "")))
>>
>> Thanks.
>>
>> I have pushed the change.
>
> Thank you. 
>
> However, the patch you committed doesn't short-circuit on anonymous
> footnotes, per above (the (not label) part). As a consequence, every
> anonymous footnote (as long as there is more than one) gets a label,
> AFAICT.

You are right.  I missed that case.  I've pushed your suggested fix.

Rasmus

-- 
Spil noget med Slayer!