From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: [PATCH] org-mime supports emacs24
Date: Sat, 03 Sep 2016 10:41:03 +0200
Message-ID: <87h99xz880.fsf@saiph.selenimh>
References: <874m6edi8j.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45304)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1bg6Vf-0005rO-JB
	for emacs-orgmode@gnu.org; Sat, 03 Sep 2016 04:41:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1bg6Vc-0001iE-Ci
	for emacs-orgmode@gnu.org; Sat, 03 Sep 2016 04:41:07 -0400
Received: from relay4-d.mail.gandi.net ([217.70.183.196]:33205)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1bg6Vc-0001iA-5O
	for emacs-orgmode@gnu.org; Sat, 03 Sep 2016 04:41:04 -0400
In-Reply-To: <874m6edi8j.fsf@gmail.com> (Chen Bin's message of "Sun, 21 Aug
	2016 11:27:08 +1000")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Chen Bin <chenbin.sh@gmail.com>
Cc: emacs-orgmode@gnu.org

Hello,

Chen Bin <chenbin.sh@gmail.com> writes:

> I got one patch to make org-mime.el usable at Emacs24.

Thank you. Note that I don't think "org-mime.el" has an active
maintainer anymore. If you want to get maintainership, we could as well
remove "org-mime.el" from contrib/ directory and let your repository be
the official one.

> I also clean out the obsolete code to make it not dependent on ascii
> and org export backend any more.

Why is it an issue ?

> +(eval-when-compile
> +  (require 'cl))

I suggest to (require 'cl-lib) instead and use "cl-" prefix accordingly.

>      ('semi (concat

"'semi" is probably a typo, assuming it is a `case' branch. It should be
simply "semi".

>              "--" "<<alternative>>-{\n"
>              "--" "[[text/plain]]\n" plain
> -	    (if (and images (> (length images) 0))
> -		(concat "--" "<<related>>-{\n"
> -			"--" "[[text/html]]\n"  html
> -			images
> -			"--" "}-<<related>>\n")
> -	      (concat "--" "[[text/html]]\n"  html
> -		      images))
> +	    (when images (concat "--" "<<alternative>>-{\n"))
> +            "--" "[[text/html]]\n"  html
> +	    images
> +	    (when images (concat "--" "}-<<alternative>>\n"))
>              "--" "}-<<alternative>>\n"))
>      ('vm "?")))

Ditto.


Regards,

-- 
Nicolas Goaziou