From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: [PATCH] Fix clocktable scope parameter
Date: Thu, 15 Dec 2016 21:56:39 +0100
Message-ID: <87h9646hdk.fsf@nicolasgoaziou.fr>
References: <8760ml2q30.fsf@gmail.com> <87y3zh5iu0.fsf@nicolasgoaziou.fr>
	<87eg19uqji.fsf@gmail.com> <m2oa0dnk62.fsf@tsdye.com>
	<87d1gtuhou.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49690)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1cHd4v-0004yS-Uj
	for emacs-orgmode@gnu.org; Thu, 15 Dec 2016 15:56:38 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1cHd4v-0007U4-7I
	for emacs-orgmode@gnu.org; Thu, 15 Dec 2016 15:56:38 -0500
Received: from relay3-d.mail.gandi.net ([2001:4b98:c:538::195]:54736)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mail@nicolasgoaziou.fr>)
	id 1cHd4v-0007TQ-0o
	for emacs-orgmode@gnu.org; Thu, 15 Dec 2016 15:56:37 -0500
In-Reply-To: <87d1gtuhou.fsf@gmail.com> (Eduardo Bellani's message of "Thu, 15
	Dec 2016 17:16:01 -0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Eduardo Bellani <ebellani@gmail.com>
Cc: Org Mode <emacs-orgmode@gnu.org>

Hello,

Eduardo Bellani <ebellani@gmail.com> writes:

> org-clock.el: Fix clocktable scope parameter

Thank you. However, this is not a "fix" per se.

> * lisp/org-clock.el (org-dblock-write:clocktable): Make sure to eval
>   the scope if it is a lisp expression, or to return the scope if it
>   is just a list.

This comment is no longer accurate.

> +             (function-name) @r{scan the list of files returned by calling this function.}

Why should the function be within a list? I suggest something like

  function @r{list of files returned by calling the function with no argument}

> -		    ((pred consp) scope)
> +                    ((and (pred #'listp) (pred (lambda (scope) (symbolp (car scope)))))
> +		     (funcall (car scope)))

Per above, it should be

  ((pred functionp) (funcall scope))

Regards,

-- 
Nicolas Goaziou