Re: [PATCH] Fix clocktable scope parameter

[Nicolas Goaziou <mail@nicolasgoaziou.fr>]

Hello,

Eduardo Bellani <ebellani@gmail.com> writes:

> org-clock.el: Fix clocktable scope parameter

Thank you. However, this is not a "fix" per se.

> * lisp/org-clock.el (org-dblock-write:clocktable): Make sure to eval
>   the scope if it is a lisp expression, or to return the scope if it
>   is just a list.

This comment is no longer accurate.

> +             (function-name) @r{scan the list of files returned by calling this function.}

Why should the function be within a list? I suggest something like

  function @r{list of files returned by calling the function with no argument}

> -		    ((pred consp) scope)
> +                    ((and (pred #'listp) (pred (lambda (scope) (symbolp (car scope)))))
> +		     (funcall (car scope)))

Per above, it should be

  ((pred functionp) (funcall scope))

Regards,

-- 
Nicolas Goaziou