From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Ian Dunn <dunni@gnu.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: Bug in org-mobile-get-outline-path-link
Date: Fri, 07 Apr 2017 18:12:40 +0200 [thread overview]
Message-ID: <87h920yz5z.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87pogq8g23.fsf@escafil> (Ian Dunn's message of "Wed, 05 Apr 2017 21:45:24 -0400")
Hello,
Ian Dunn <dunni@gnu.org> writes:
> I recently tried turning off 'org-mobile-force-id-on-agenda-items', only
> to find that there were problems updating agenda tasks. I poked around
> in the code and found that 'org-mobile-locate-entry' looks for an OLP in
> the form olp:file:/path/to/heading, and
> 'org-mobile-get-outline-path-link' stores it as
> olp:file/path/to/heading.
>
> I've attached a patch to fix the latter function.
>
> --
> Ian Dunn
>
> diff --git a/lisp/org-mobile.el b/lisp/org-mobile.el
> index f6ef18f10..12e6c84b3 100644
> --- a/lisp/org-mobile.el
> +++ b/lisp/org-mobile.el
> @@ -648,7 +648,7 @@ The table of checksums is written to the file mobile-checksums."
> (org-with-point-at pom
> (concat "olp:"
> (org-mobile-escape-olp (file-name-nondirectory buffer-file-name))
> - "/"
> + ":"
> (mapconcat 'org-mobile-escape-olp
> (org-get-outline-path)
> "/")
It looks good. Could you provide the same patch using git format-patch,
along with a proper commit message?
Thank you.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2017-04-07 16:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-06 1:45 Bug in org-mobile-get-outline-path-link Ian Dunn
2017-04-07 16:12 ` Nicolas Goaziou [this message]
2017-04-07 22:58 ` [PATCH] Fix bug in mobile outline path handling Ian Dunn
2017-04-10 19:17 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h920yz5z.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=dunni@gnu.org \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).