``make test'' failure

[Nick Dokos <ndokos@gmail.com>]

I get one failure in test-org-publish/resolve-external-link.
Bisecting fingers this commit:

,----
| $ git bisect good
| 007bbddbccfd06ab9c97d51bf833a068cb1b07a2 is the first bad commit
| commit 007bbddbccfd06ab9c97d51bf833a068cb1b07a2
| Author: Nicolas Goaziou <mail@nicolasgoaziou.fr>
| Date:   Sun Sep 10 00:16:12 2017 +0200
| 
|     ox-html: Prevent spurious target below headlines
|     
|     * lisp/ox-html.el (org-html-headline):
|     (org-html-link): Do not insert an additional target.
|     
|     * lisp/ox-publish.el (org-publish-resolve-external-link): Add an
|       optional argument.
|     
|     * lisp/ox.el (org-export-get-reference): Improve docstring.
|     
|     * testing/examples/pub/a.org:
|     * testing/examples/pub/b.org: New files.
|     * testing/lisp/test-ox-publish.el (test-org-publish/resolve-external-link):
|       New test.
| 
| :040000 040000 fda080e0db653c9049448200be5ad03369379cc3 ec0eb8a5cd9b3c3b204fd7134e515fb360b85c79 M	etc
| :040000 040000 39afe6514335e2ccd549fc5b7fafcac344cbb471 a0fdf6967cc3ab95b046f81dab08095fe0d302de M	lisp
| :040000 040000 120e098640643a963336d77d65929ef5863eeba5 679329e78a4bbc04f6f84bb176821a3084732ab3 M	testing
`----

which *introduced* this test, but of course the test may be at fault,
rather than the code.

The failure looks like this:

,----
|    passed  571/765  test-org-publish/get-project-from-filename
| Publishing file /home/nick/src/emacs/org/org-mode/testing/examples/pub/b.org using ‘(closure ((backend . #s(org-export-backend nil nil ((headline lambda (h c i) (concat (org-export-get-reference h i)   c)) (paragraph lambda (p c i) c) (section lambda (s c i) c) (link lambda (l c i) (let ((option (org-element-property :search-option l)) (path (org-element-property :path l))) (and option (org-publish-resolve-external-link option path))))) nil nil nil nil)) (ids) (fn-14501 . apply) t) (plist filename pub-dir) (org-publish-org-to backend filename .test plist pub-dir))’
| Publishing file /home/nick/src/emacs/org/org-mode/testing/examples/pub/a.org using ‘(closure ((backend . #s(org-export-backend nil nil ((headline lambda (h c i) (concat (org-export-get-reference h i)   c)) (paragraph lambda (p c i) c) (section lambda (s c i) c) (link lambda (l c i) (let ((option (org-element-property :search-option l)) (path (org-element-property :path l))) (and option (org-publish-resolve-external-link option path))))) nil nil nil nil)) (ids) (fn-14501 . apply) t) (plist filename pub-dir) (org-publish-org-to backend filename .test plist pub-dir))’
| Publishing file /home/nick/src/emacs/org/org-mode/testing/examples/pub/b.org using ‘(closure ((backend . #s(org-export-backend nil nil ((headline lambda (h c i) c) (paragraph lambda (p c i) c) (section lambda (s c i) c) (link lambda (l c i) (let ((option (org-element-property :search-option l)) (path (org-element-property :path l))) (when option (throw :exit (org-publish-resolve-external-link option path t)))))) nil nil nil nil)) (ids) (fn-14506 . equal) t) (plist filename pub-dir) (setq ids (cons (catch :exit (org-publish-org-to backend filename .test plist pub-dir)) ids)))’
| Publishing file /home/nick/src/emacs/org/org-mode/testing/examples/pub/a.org using ‘(closure ((backend . #s(org-export-backend nil nil ((headline lambda (h c i) c) (paragraph lambda (p c i) c) (section lambda (s c i) c) (link lambda (l c i) (let ((option (org-element-property :search-option l)) (path (org-element-property :path l))) (when option (throw :exit (org-publish-resolve-external-link option path t)))))) nil nil nil nil)) (ids a1) (fn-14506 . equal) t) (plist filename pub-dir) (setq ids (cons (catch :exit (org-publish-org-to backend filename .test plist pub-dir)) ids)))’
| Test test-org-publish/resolve-external-link backtrace:
|   signal(ert-test-failed (((should (equal "a1" (let* ((ids nil) (backe
|   ert-fail(((should (equal "a1" (let* ((ids nil) (backend (org-export-
|   (if (unwind-protect (setq value-14508 (apply fn-14506 args-14507)) (
|   (let (form-description-14510) (if (unwind-protect (setq value-14508 
|   (let ((value-14508 'ert-form-evaluation-aborted-14509)) (let (form-d
|   (let* ((fn-14506 (function equal)) (args-14507 (condition-case err (
|   (closure (t) nil (let* ((fn-14501 (function apply)) (args-14502 (con
|   ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
|   ert-run-test(#s(ert-test :name test-org-publish/resolve-external-lin
|   ert-run-or-rerun-test(#s(ert--stats :selector "\\(org\\|ob\\)" :test
|   ert-run-tests("\\(org\\|ob\\)" #f(compiled-function (event-type &res
|   ert-run-tests-batch("\\(org\\|ob\\)")
|   ert-run-tests-batch-and-exit("\\(org\\|ob\\)")
|   (let ((org-id-track-globally t) (org-test-selector (if org-test-sele
|   org-test-run-batch-tests("\\(org\\|ob\\)")
|   eval((org-test-run-batch-tests org-test-select-re))
|   command-line-1(("--eval" "(setq vc-handled-backends nil org-startup-
|   command-line()
|   normal-top-level()
| Test test-org-publish/resolve-external-link condition:
|     (ert-test-failed
|      ((should
|        (equal "a1"
| 	      (let* ... ... ...)))
|       :form
|       (equal "a1" "org44ee821")
|       :value nil :explanation
|       (arrays-of-different-length 2 10 "a1" "org44ee821" first-mismatch-at 0)))
|    FAILED  572/765  test-org-publish/resolve-external-link
`----

-- 
Nick