From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Jay Kamat <jaygkamat@gmail.com>
Cc: Org Mode <emacs-orgmode@gnu.org>
Subject: Re: [patch] fix error when using org-notify with no agenda files
Date: Tue, 10 Apr 2018 20:11:33 +0200 [thread overview]
Message-ID: <87h8ojrkx6.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87muyb2577.fsf@gmail.com> (Jay Kamat's message of "Mon, 09 Apr 2018 22:02:47 -0400")
Hello,
Jay Kamat <jaygkamat@gmail.com> writes:
> Hi,
>
> Previously, when `org-agenda-files' was nil, and `org-notify-start' had
> been called (org-notify running), I got the following error every time
> `org-notify-process' would run.
>
> Wrong type argument: stringp, nil
>
> This patch fixes this so `org-notify' won't throw errors if no agenda
> files are present.
Applied. Thank you.
>
> Please let me know if you spot any issues. I thought about adding a
> one-time message warning the user, would this be a good idea (or should
> we just stay out of their way)? I would be happy to implement it if that
> would be preferable.
I think the current state is good enough.
Regards,
--
Nicolas Goaziou
prev parent reply other threads:[~2018-04-10 18:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 2:02 [patch] fix error when using org-notify with no agenda files Jay Kamat
2018-04-10 18:11 ` Nicolas Goaziou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h8ojrkx6.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=jaygkamat@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).