Re: [PATCH] ob-emacs-lisp: Set `lexical-binding' in source editing buffers

[Nicolas Goaziou <mail@nicolasgoaziou.fr>]

Hello,

Sebastian Miele <sebastian.miele@gmail.com> writes:

> * lisp/ob-emacs-lisp.el (org-babel-execute:emacs-lisp,
>   org-babel-emacs-lisp-lexical): Factor out the conversion of the
>   :lexical source block argument to a form that is appropriate for
>   `lexical-binding' and the LEXICAL argument to `eval'.
>
> * lisp/ob-emacs-lisp.el (org-babel-edit-prep:emacs-lisp): Set
>   `lexical-binding'.
>
> * lisp/ob-emacs-lisp.el (org-babel-default-header-args:emacs-lisp):
>   Update docstring.

Thank you! Some comments follow.

> -`eval', which see.")
> +`eval', which see. And it is used as the value for
> +`lexical-binding' in buffers created by `org-edit-src-code'.")

You need to add two spaces after full stops.

> +(defun org-babel-emacs-lisp-lexical (lexical)
> +  "Convert :lexical source block argument LEXICAL into the form
> +appropriate for `lexical-binding' and the LEXICAL argument to
> +`eval'."

The first sentence in a docstring needs to fit on a single line.

Could you add a test or two for that feature? Could you also add an
ORG-NEWS entry?

Regards,

-- 
Nicolas Goaziou