From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pierre Neidhardt <mail@ambrevar.xyz>
Subject: org-notmuch: Improved tree support
Date: Tue, 19 Mar 2019 11:07:13 +0100
Message-ID: <87h8bzb2jy.fsf@bababa.i-did-not-set--mail-host-address--so-tickle-me>
Mime-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha256; protocol="application/pgp-signature"
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([209.51.188.92]:40140)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@ambrevar.xyz>) id 1h6Bej-0007He-1l
	for emacs-orgmode@gnu.org; Tue, 19 Mar 2019 06:07:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@ambrevar.xyz>) id 1h6Bei-00039u-Aw
	for emacs-orgmode@gnu.org; Tue, 19 Mar 2019 06:07:37 -0400
Received: from relay7-d.mail.gandi.net ([217.70.183.200]:52489)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mail@ambrevar.xyz>) id 1h6Beh-0002oG-Ts
	for emacs-orgmode@gnu.org; Tue, 19 Mar 2019 06:07:36 -0400
Received: from bababa (lfbn-1-12225-33.w90-92.abo.wanadoo.fr [90.92.41.33])
	(Authenticated sender: pierre@atlas.engineer)
	by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id AB4FF20021
	for <emacs-orgmode@gnu.org>; Tue, 19 Mar 2019 10:07:13 +0000 (UTC)
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: emacs-orgmode@gnu.org

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

1. `org-notmuch-store-link' does not allow to store links to email at
point in tree view.  Easy fix:

=2D-8<---------------cut here---------------start------------->8---
(defun org-notmuch-store-link ()
  "Store a link to a notmuch search or message."
=2D  (when (eq major-mode 'notmuch-show-mode)
+  (when (or (eq major-mode 'notmuch-show-mode)
+            (eq major-mode 'notmuch-tree-mode))
    (let* ((message-id (notmuch-show-get-message-id t))
=2D-8<---------------cut here---------------end--------------->8---

2. A while back
https://lists.gnu.org/archive/html/emacs-orgmode/2014-07/msg00380.html
was merged.  I think using a defcustom here is not very intuitive for
people who use both the tree view and the thread view.  I would expect
the following:

=2D Opening a tree link will open the tree view.
=2D Opening a search link will open the search view.

It's easy to implement:

=2D Deprecate the former defcustom.
=2D Copy/paste the org-notmuch-search* code to org-notmuch-tree*.

Thoughts?

=2D-=20
Pierre Neidhardt
https://ambrevar.xyz/

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAlyQv1EACgkQm9z0l6S7
zH+hrwgAl9fHa1IaKXE2sULFL6MQzHrBqTtQtFUZ/4/ZwodnSP62gFhxrAzuWN0Q
ZSg9PffG1VIsr4UBOwDyIq5xmVLlckMd8zJL5ytl8cbOtr4K9FqCBzAOx5JX9SyE
0qab79LueKIPeo1vlErcXU16jK/v0vnFm0gk2Dj5+spjsLNmTxtYHo2OXer3RUtF
TtcZKH1O/9rMoUC39KYg4YOx+fZFMo9aLawdwr7YmsbdAFxgBaDxx1cdUg1EnTTR
vmiP+tpd0P1f9qet+BEnrvcERysCasZEvG5suNuWYw2ahng/M5bQxd8GVx1P3o6+
BPMIXGTODkoSiw7PmYDHP9TCeUP8ng==
=6N3t
-----END PGP SIGNATURE-----
--=-=-=--