emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: stardiviner <numbchild@gmail.com>
To: Bastien <bzg@gnu.org>
Cc: emacs-orgmode@gnu.org
Subject: [SOLVED] Re: [PATCH] ob-sql.el support auto set sql-product in editing sql-mode src block buffer
Date: Wed, 12 Feb 2020 16:41:49 +0800	[thread overview]
Message-ID: <87h7zww62a.fsf@gmail.com> (raw)
In-Reply-To: <87pnekp6uw.fsf@bzg.fr>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256


Bastien <bzg@gnu.org> writes:

> Hi Stardiviner,
>
> stardiviner <numbchild@gmail.com> writes:
>
>> Hmmm.. Just a gentle ping ... This might is been missed .... Let me
>> resume this thread.
>
> I've seen this suggestion and the previous ping but did not really
> understand the change.
>
> I have edited your patch a little bit to avoid redundant lines and
> pushed it in master :
>
> https://code.orgmode.org/bzg/org-mode/commit/7cd9ad8f75
>
> Let me know if it looks good to you.
>
> Thanks for your contribution,

This is great. I don't know ~cl-case~'s KEYLIST can be a list. This solved my
problem totally. Still have more to learn. Thanks Bastien. :)

- -- 
[ stardiviner ]
       I try to make every word tell the meaning what I want to express.

       Blog: https://stardiviner.github.io/
       IRC(freenode): stardiviner, Matrix: stardiviner
       GPG: F09F650D7D674819892591401B5DF1C95AE89AC3
      
-----BEGIN PGP SIGNATURE-----

iQFIBAEBCAAyFiEE8J9lDX1nSBmJJZFAG13xyVromsMFAl5Duk0UHG51bWJjaGls
ZEBnbWFpbC5jb20ACgkQG13xyVromsMiZQf/TO/2Bn6xmX8txp8icgb1zRX7f9z0
DFSKhlY782ihdWUKLuPpwJdV1zo0sAhoDRTkZSPyaa+8V2zwISyYmVrH72uxyfWV
vGBQOtTT7t68xPqdRAGlM10OZISE9xAISDjxB/HX6RRi3byg9z+15CyjMQTqSbW3
3beeEY+HZf9Rmhcxr8RXqiXgL37Cxk2zVSZwOyeNFZzjTXhJOnb6BEXg+lsUv/vo
/pGjOliFE12fshF0Rox9jX7HmA7fxNnq//CL7afh4zrolYYlJ79VA5Tixrv94M56
O15dPW/O6W0wBz7/ItGSTD3vxgPYx+ZDE5Q/WtHbFH00SV0NoqfxAIlwyw==
=16GH
-----END PGP SIGNATURE-----

      reply	other threads:[~2020-02-12  8:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-30  6:21 [QUESTION] A decision about matching ob-sql.el's :engine header argument match sql-mode product name stardiviner
2020-01-30  7:29 ` Tim Cross
2020-01-30 12:32   ` stardiviner
2020-01-31 10:53     ` Bastien
2020-02-04 16:29       ` [PATCH] ob-sql.el support auto set sql-product in editing sql-mode src block buffer stardiviner
2020-02-05 15:46         ` stardiviner
2020-02-12  7:11         ` stardiviner
2020-02-12  8:06           ` Bastien
2020-02-12  8:41             ` stardiviner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h7zww62a.fsf@gmail.com \
    --to=numbchild@gmail.com \
    --cc=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).