From: Bastien <bzg@gnu.org>
To: Terje Larsen <terlar@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] ob-plantuml: Support for plantuml as well as the current java+jar solution
Date: Wed, 12 Feb 2020 18:30:56 +0100 [thread overview]
Message-ID: <87h7zvpvan.fsf@gnu.org> (raw)
In-Reply-To: <874kzeijnz.fsf@gmail.com> (Terje Larsen's message of "Fri, 08 Nov 2019 14:26:08 +0100")
Hi Terje,
Terje Larsen <terlar@gmail.com> writes:
> I have been missing this feature for a while and noticed it had already
> been requested before (2014), See:
> https://lists.gnu.org/archive/html/emacs-orgmode/2016-08/msg00105.html
>
> With this patch you can switch between using jar or plantuml. The idea
> partly stemmed from plantuml-mode and my inability to use the default
> implementation. You can see the implementation for plantuml-mode here:
> https://github.com/skuro/plantuml-mode/pull/102/files
>
> My patch is available here:
> https://code.orgmode.org/terlar/org-mode/commit/fbe245c0b09513ee5a6d3b189e112708b9d08da0
Thanks for the patch -- I see you're already on the list of committers
with TINYCHANGE: https://orgmode.org/worg/org-contribute.html#orgcd077ac
Would you like to sign the FSF papers and resubmit your patch on top
of current master?
https://orgmode.org/request-assign-future.txt
Thanks a lot,
--
Bastien
next prev parent reply other threads:[~2020-02-12 17:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 13:26 [PATCH] ob-plantuml: Support for plantuml as well as the current java+jar solution Terje Larsen
2019-11-24 9:22 ` Nicolas Goaziou
2019-11-24 22:29 ` Terje Larsen
2020-02-12 17:30 ` Bastien [this message]
2020-02-16 13:20 ` Terje Larsen
2020-02-16 23:29 ` Bastien
2020-05-26 19:29 ` Terje Larsen
2020-06-01 13:59 ` Bastien
2020-06-09 6:53 ` Terje Larsen
2020-08-30 19:49 ` Terje Larsen
2020-09-04 10:38 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7zvpvan.fsf@gnu.org \
--to=bzg@gnu.org \
--cc=emacs-orgmode@gnu.org \
--cc=terlar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).