From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id EJdFIkQNsl7geAAA0tVLHw (envelope-from ) for ; Wed, 06 May 2020 01:05:08 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id CGJuCVANsl6nFgAAB5/wlQ (envelope-from ) for ; Wed, 06 May 2020 01:05:20 +0000 Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:470:142::17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 52CB49400BF for ; Wed, 6 May 2020 01:05:16 +0000 (UTC) Received: from localhost ([::1]:44450 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jW8Ut-0005Kz-8Q for larch@yhetil.org; Tue, 05 May 2020 21:05:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37636) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jW8UP-0005Ke-69 for emacs-orgmode@gnu.org; Tue, 05 May 2020 21:04:46 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:45055) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jW8UM-0007lg-EG for emacs-orgmode@gnu.org; Tue, 05 May 2020 21:04:44 -0400 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 432E2FF803; Wed, 6 May 2020 01:04:38 +0000 (UTC) From: Nicolas Goaziou To: Ferdinand Pieper Subject: Re: Additonal slashes in URI sent to org-protocol References: <87zhbq7zin.fsf@pie.tf> Mail-Followup-To: Ferdinand Pieper , emacs-orgmode@gnu.org Date: Wed, 06 May 2020 03:04:37 +0200 In-Reply-To: <87zhbq7zin.fsf@pie.tf> (Ferdinand Pieper's message of "Sun, 05 Apr 2020 16:55:44 +0200") Message-ID: <87h7wtc1qy.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=217.70.183.199; envelope-from=mail@nicolasgoaziou.fr; helo=relay9-d.mail.gandi.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/05 21:04:39 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 X-Spam-Score: -1.01 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 2001:470:142::17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Scan-Result: default: False [-1.01 / 13.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; GENERIC_REPUTATION(0.00)[-0.4958804502991]; HAS_XOIP(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2001:470:142::/48:c]; IP_REPUTATION_HAM(0.00)[asn: 22989(0.12), country: US(-0.00), ip: 2001:470:142::17(-0.50)]; DWL_DNSWL_BLOCKED(0.00)[2001:470:142::17:from]; MX_GOOD(-0.50)[cached: eggs.gnu.org]; RCPT_COUNT_TWO(0.00)[2]; MAILLIST(-0.20)[mailman]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:22989, ipnet:2001:470:142::/48, country:US]; TAGGED_FROM(0.00)[larch=yhetil.org]; FROM_NEQ_ENVFROM(0.00)[mail@nicolasgoaziou.fr,emacs-orgmode-bounces@gnu.org]; ARC_NA(0.00)[]; RCVD_COUNT_FIVE(0.00)[5]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; URIBL_BLOCKED(0.00)[pie.tf:email]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[nicolasgoaziou.fr]; HAS_LIST_UNSUB(-0.01)[]; DNSWL_BLOCKED(0.00)[2001:470:142::17:from]; FORGED_SENDER_MAILLIST(0.00)[] X-TUID: EmZzCsYBI9Fg Hello, Ferdinand Pieper writes: > Subject: [PATCH] org-protocol: Allow slashes after sub-protocol Thank you. Please add the function modified in the commit message. Also, if you haven't signed FSF papers for copyright, you need to insert TINYCHANGE. > This change lets org-protocol handle URIs with additional slashes > before the start of the query string, e.g. > > org-protocol:/capture/?template=... > > instead of > > org-protocol:/capture?template=... > --- > lisp/org-protocol.el | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lisp/org-protocol.el b/lisp/org-protocol.el > index 55a534d0d..8fbff9611 100644 > --- a/lisp/org-protocol.el > +++ b/lisp/org-protocol.el > @@ -617,13 +617,13 @@ CLIENT is ignored." > (let ((proto > (concat the-protocol > (regexp-quote (plist-get (cdr prolist) :protocol)) > - "\\(:/+\\|\\?\\)"))) > + "\\(:/+\\|/*\\?\\)"))) > (when (string-match proto fname) > (let* ((func (plist-get (cdr prolist) :function)) > (greedy (plist-get (cdr prolist) :greedy)) > (split (split-string fname proto)) > (result (if greedy restoffiles (cadr split))) > - (new-style (string= (match-string 1 fname) "?"))) > + (new-style (string-match (match-string 1 fname) "/*?"))) I don't understand this line. Aren't you calling string-match backwards? I think you mean: (new-style (string-match "?" (match-string 1 fname))) Could you also insert a comment explaining why this workaround is required? Regards, -- Nicolas Goaziou