From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id arCzHd/A0l4iVAAA0tVLHw (envelope-from ) for ; Sat, 30 May 2020 20:23:59 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id qKNZGd/A0l7nTQAAB5/wlQ (envelope-from ) for ; Sat, 30 May 2020 20:23:59 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9AA21940539 for ; Sat, 30 May 2020 20:23:58 +0000 (UTC) Received: from localhost ([::1]:37456 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jf81N-00079Q-Gw for larch@yhetil.org; Sat, 30 May 2020 16:23:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56278) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jf80g-00079F-DS for emacs-orgmode@gnu.org; Sat, 30 May 2020 16:23:14 -0400 Received: from pb-smtp1.pobox.com ([64.147.108.70]:50646) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jf80e-0003EQ-PB for emacs-orgmode@gnu.org; Sat, 30 May 2020 16:23:13 -0400 Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id F2BD46D421; Sat, 30 May 2020 16:23:10 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:in-reply-to:date:message-id:mime-version:content-type :content-transfer-encoding; s=sasl; bh=x0/mI5Ir2rwaFXjF5quVamvZ3 3E=; b=yYa3yaE99a11P5ZygsTYBlMPY1SRxfd9EZwn3+Rqe+lT0AZQAsu085gmy 0NXMmRMM7N2YQb2ZWTblOEpN9htwCygkmkSkNA6Ip9NZ2WrWGi5oPxQ8Cp5qpmNA lLVXIB0vx5R9QSCz2Itk1rurA/3DFR8IuXoRKRjd6MlP1X2TUc= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id EAC746D420; Sat, 30 May 2020 16:23:10 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=kyleam.com; h=from:to:cc:subject:in-reply-to:date:message-id:mime-version:content-type:content-transfer-encoding; s=mesmtp; bh=YIqaHysWschAOITqMBjZZRnOulBUYsKU3Vxn/b0B0ac=; b=k4y0MYTmv81n9XapXYlgwSOoUYKYKpSYHKGKBkiY7ZMZRcnLJGbfugweh8xoCBux1Uj9fa9k7f2pl+mkwxzYZatdXEtkehtALUyxBWgOi/vhBEv/kzTtEBXrieCNAtwi0cS+L7jiczEaXOnj4nmOK1fgnadng1MZtpB8FeCAgEs= Received: from localhost (unknown [45.33.91.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 5BFA56D41F; Sat, 30 May 2020 16:23:10 -0400 (EDT) (envelope-from kyle@kyleam.com) From: Kyle Meyer To: Mario Frasca Subject: Re: `with` as a list. In-Reply-To: Date: Sat, 30 May 2020 20:23:09 +0000 Message-ID: <87h7vxuq8i.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Pobox-Relay-ID: 615335CE-A2B3-11EA-BD4C-C28CBED8090B-24757444!pb-smtp1.pobox.com Received-SPF: pass client-ip=64.147.108.70; envelope-from=kyle@kyleam.com; helo=pb-smtp1.pobox.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/30 16:23:11 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=pobox.com header.s=sasl header.b=yYa3yaE9; dkim=pass header.d=kyleam.com header.s=mesmtp header.b=k4y0MYTm; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.21 X-TUID: SPpYPkoqdC+x Mario Frasca writes: > btw. are you on irc.freenode.net?=C2=A0 I'm `mariotomo' there.=C2=A0 and = I just=20 > joined `#org-mode'.=C2=A0 I don't think that my terminal will ring a bell= if=20 > I'm mentioned there. No, sorry, I'm not. > On 30/05/2020 01:22, Kyle Meyer wrote: >> Mario Frasca writes: > >> Two meta-comments: >> >> * Please provide a patch with a commit message. See >> for more information. >> >> * The link above also explains the copyright assignment requirement >> for contributions. Please consider assigning copyright to the FSF. > > I'm editing in my cloned repository, and committing often, so I do not=20 > have a single commit, consequently also not a single commit message. There are various ways to get those fixups into a single commit. Here's one that assumes that you're working from the command line and on a topic branch rather than directly on master. Do an interactive rebase (`git rebase -i master'). When the editor pops up, replace "pick" with "fixup" in all of the lines but the first. (If any of the "fixup" commits have message bits that you want to keep in the final message, you can use "squash" instead.) For later fixups, you can do the same process. You could also use git-commit's --amend. (Again, there are lots of possible workflows, and of course once you're working on a series of commits rather than a single one, the process changes a bit.) > I just sent my form request to assign@gnu.org. Thank you! Please let us know when the process is complete. I see you already sent an updated patch, so I'll just respond to one more point from this message. >> I haven't looked at this bit too closely (and I know the handling around >> col-labels changed a bit in the last message you sent), but I did try >> out a few org-plot invocations and things seemed to work as I expected. >> I'll plan to take a closer when you send a reroll. > > the whole org-plot.el has (had) no unit tests, so if you share a couple=20 > of your org-plot invocations, I can convert them to regression tests. I don't use org-plot.el, so to try this out, I just copied an example from the Worg tutorial, stripped the table down a bit, and tried a few `deps' and `with' values. So there's nothing too useful, but here's is the last one I had: --8<---------------cut here---------------start------------->8--- #+PLOT: title:"example table" ind:1 deps:(2 3) type:2d with:(lines points) #+PLOT: labels:("xlab" "ylab" "zlab") #+TBLNAME:org-plot-example-1 | x | y | z | |-----+------+------| | 0.1 | 0.42 | 0.37 | | 0.2 | 0.31 | 0.33 | | 0.3 | 0.24 | 0.28 | | 0.4 | 0.27 | 0.23 | --8<---------------cut here---------------end--------------->8--- Thanks for your interest in adding tests. Of course it'd be good for org-plot.el to have some, and there are existing spots where I think it should be easy enough to hook into and test (in particular generating the script file and data file). However, that doesn't necessarily have to be tacked on to this series.