emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: Leo Vivier <leo.vivier+dev@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org: Update example in docstring to accommodate new name and new format
Date: Wed, 22 Jul 2020 00:27:50 -0400	[thread overview]
Message-ID: <87h7u0yy0p.fsf@kyleam.com> (raw)
In-Reply-To: <87ft9mgckh.fsf@hidden>

Leo Vivier writes:

> I’ve spotted an example in a docstring that wasn’t updated when the
> command was renamed and moved to another file in
> d34786f2279d0fd02e7d0484e36bc22adc760de2.

Thanks for the patch and for digging back to the commit that moved
org-find-olp.  Looking at that commit, I'm a bit confused because the
example was introduced with that commit (i.e. it didn't just go stale
with the move).  Also the function has the same name, org-find-olp, both
before and after that commit.

Anyway, in my view the example doesn't really add much value.  What do
you think about just removing it?


  parent reply	other threads:[~2020-07-22  4:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-20 20:23 [PATCH] org: Update example in docstring to accommodate new name and new format Leo Vivier
2020-07-21  5:41 ` Leo Vivier
2020-07-22  4:27 ` Kyle Meyer [this message]
2020-07-22  6:43   ` Leo Vivier
2020-07-23  3:40     ` Kyle Meyer
2020-07-23  5:48       ` Leo Vivier
2020-07-23 23:27         ` Kyle Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h7u0yy0p.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=leo.vivier+dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).