From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id qHeXAvTl32AUJwEAgWs5BA (envelope-from ) for ; Sat, 03 Jul 2021 06:22:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id eELjOfPl32A9RQAA1q6Kng (envelope-from ) for ; Sat, 03 Jul 2021 04:22:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 32F7CEC34 for ; Sat, 3 Jul 2021 06:22:11 +0200 (CEST) Received: from localhost ([::1]:42416 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lzXAP-0006DG-3h for larch@yhetil.org; Sat, 03 Jul 2021 00:22:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34540) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lzX9p-0006D7-NI for emacs-orgmode@gnu.org; Sat, 03 Jul 2021 00:21:33 -0400 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]:43778) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lzX9n-0002Sy-TJ for emacs-orgmode@gnu.org; Sat, 03 Jul 2021 00:21:33 -0400 Received: by mail-pl1-x633.google.com with SMTP id i13so6899144plb.10 for ; Fri, 02 Jul 2021 21:21:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=pg8x6iwsaD3ytk2XwHnkEwbW5y+faIuQAcMiaoQgtyQ=; b=rHT3h0N7FbbO74Fsap58Nq5OcqqgTPHD2O0ErxjndOae5BtYkY9+uAxU/+H9J5tof6 toNMNJe3TggIvx+GIS8J6+Sn/3y5rwcvVNgch2IupxTWO29pSy1DbdtqjnZ6L0sh9CTM JVZ4UzOLBDkQvhzYIvf21LC9iqHhaK3Kg50vaKGV3QfrsjUjyWKZ8yF+0GzxCho1KQyr feo13mXDssIc7h1e8sbopPRlv3BoBlxhUL2vTLBi6YoeDAtqGqBhLbKOvFaJE6KEpyX+ VaZMXOYZvAxJmU6WMz4ChWCzXBIyE2Z4i4lIpYw9H2C2hIXS++dE/dsq6pxOnsNKwJRp y67w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=pg8x6iwsaD3ytk2XwHnkEwbW5y+faIuQAcMiaoQgtyQ=; b=Emgr0WFh10h3EmH7UTzoxtciLqtt8/1dmP87CvssmFBm+MMvBg7V8KpNep+rPAefMp fRvfhErQrP9Er2xeR0l7QzskbWTriCF5ICPUZd5mzKdmgHRFN29IWQarg6exxRqfC0hP gMdghqPvFT2pA7guIyWtJhI0sb0J3iZ7kQ7xyjZ3TGoLeRoVDQs2SYNEwSKT7xoJ7AO6 d5YEYPUONW1Jr94zn2B9eVN77S00gEonXKmlAtO0iFfhLzijX5cCT8kWbYSBfNBuV9F4 ylmpFGrct4SDSI+enR6AN13N6ab6gQ4828Xjs1PG66XyqI8sbVFAD+23yc7M71Nma7uv Gj9A== X-Gm-Message-State: AOAM531Mpk9vubz7RqGDTSeYGzYZPCKeEo5Yq53FH06YgL2d2kgShKwY 7Ez+thPbCxaQ2c1vB9T3ils= X-Google-Smtp-Source: ABdhPJyIabc2Pg+YbIQhWLSado9fl6QL8uMtN2UYYKhmOT05aYRYh9rFiMIVCZJmt1jDXTnhmnmEgw== X-Received: by 2002:a17:90a:8b0e:: with SMTP id y14mr2860699pjn.191.1625286090000; Fri, 02 Jul 2021 21:21:30 -0700 (PDT) Received: from localhost ([198.27.182.161]) by smtp.gmail.com with ESMTPSA id j4sm14226377pjv.7.2021.07.02.21.21.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Jul 2021 21:21:29 -0700 (PDT) From: Jack Kamm To: Jeremie Juste Subject: Re: [PATCH] ob-R output file with graphics parameter In-Reply-To: <87o8bpbqp3.fsf@gmail.com> References: <8735t8nqlf.fsf@gmail.com> <87pmwbty75.fsf@yandex.com> <871r8n1ban.fsf@gmail.com> <87o8bpbqp3.fsf@gmail.com> Date: Fri, 02 Jul 2021 21:21:28 -0700 Message-ID: <87h7hcowmv.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::633; envelope-from=jackkamm@gmail.com; helo=mail-pl1-x633.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Colin Baxter , "Berry, Charles" , Org Mode Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1625286131; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=pg8x6iwsaD3ytk2XwHnkEwbW5y+faIuQAcMiaoQgtyQ=; b=JFbO2vJ2kD3ngfjzpCl481EP8iZEQCrvfEA3TU4GT85HtydJiOppDOdvIu7Jzhvv91lV15 dfZvpYrP7tT3RjxGiEXja3KdFp6cHKJ/u9O1iLgpKVtnm8GLOrCYrbF8MwZjtZZzCKRT0o vQ2cf9haRoIZ8tC7LPj2Q2EOwTDF/mCyOGHVmRikq0lKaWFpXYgxGNfNf3O2LzrgbzDTkL 4X7ocKp7ajXZ4syLd1fnE/kWGXqBtddkJ/LOcnqa8Qf/sGtJQMEcAOcydWXu4Xjg1Ft3S3 dr8PMnXAW1SFJpumOXbIHMtNxSUzunOwnhcXMf4aijpSIEMbScw4IZ7JiPHmRQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1625286131; a=rsa-sha256; cv=none; b=m4cu1M6uGjFvcfH/clCofmczT7+9yx5ejApNfijt4I4Wk4OB9oq5XBPEMOx9cRC6NowGMm JD6o7yqtWTleRqYa2HcaIsiCa+u4fd6OrID1aeHDE3kgNhsdQSZNySuWg3IcLxgeOJWLtb oC5o41p89Y1VTGmL2mEZYMLUizH2rinOrillCFyQQWQsn0gYrS991uyTt1CRjOLBPp+c/5 Z3tdJvfGrlb9Ose2PpMgS96RtwUSkk3MvYLmVp+pOGYsqlsQwqjq70r0KLQbNjht0ytXlX 863mRTbXT3rypDTbGSjYw8/p/pDLFK0Wa/ubjVxGR7+aO6Tk9OUDQUfsHL2ybw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=rHT3h0N7; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -1.31 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=rHT3h0N7; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 32F7CEC34 X-Spam-Score: -1.31 X-Migadu-Scanner: scn0.migadu.com X-TUID: i+yjh5iqjNm9 Hi Jeremie, >> The requirement for a second file parameter was added in Org 9.3 to >> support the use case in this thread: >> >> https://orgmode.org/list/3ac2f42a-8ff2-1464-fa36-451e2ef0eacd@pressure.to/ >> >> But this syntax is annoyingly verbose for ob-R users, and also broke >> lots of ob-R examples prior to Org 9.3. >> >> A simple fix might be to have the "graphics" flag implicitly add the >> "file" flag as well. But we would need to first check that this doesn't >> break other use cases. > > I do agree with this solution. If the current specification works, we > could make it easy for ob-R user by implicitly adding a file flag. But > as far as I understand, the change will have to be made in ob-core.el. Hmm, I think you're right -- this would have to be done in ob-core.el. I think it would still make sense though, and would be beneficial beyond ob-R. According to [1], the "graphics" and "link" arguments don't do anything unless used with "file", so it would make sense for them to automatically add the "file" argument. [1] https://orgmode.org/manual/Results-of-Evaluation.html#Results-of-Evaluation