From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 0IRLMjNJXGF5hgEAgWs5BA (envelope-from ) for ; Tue, 05 Oct 2021 14:46:43 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id EMnLLTNJXGFEBwAAbx9fmQ (envelope-from ) for ; Tue, 05 Oct 2021 12:46:43 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3E628AAFE for ; Tue, 5 Oct 2021 14:46:43 +0200 (CEST) Received: from localhost ([::1]:45784 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mXjqD-0003B8-Q6 for larch@yhetil.org; Tue, 05 Oct 2021 08:46:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52696) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mXjo0-00038q-T9 for emacs-orgmode@gnu.org; Tue, 05 Oct 2021 08:44:24 -0400 Received: from mail-pf1-x436.google.com ([2607:f8b0:4864:20::436]:35523) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mXjny-0001Rl-Og for emacs-orgmode@gnu.org; Tue, 05 Oct 2021 08:44:24 -0400 Received: by mail-pf1-x436.google.com with SMTP id c29so6931437pfp.2 for ; Tue, 05 Oct 2021 05:44:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=3qQq8c00ltdsmjstYSJL4iTeZHerpCePZAOCl8LgI4E=; b=aTlbLsGSr4VX7jO1Mdpe2QwxodTKUf+yiaIILdUIGdh+2uOm7Fj/42zohp3EKWHdIH Hc6TFZeUwbPHIvTNdf/uswPuHP7Ty3zTzuxLH0LmDSAFXu6CrjhtqtGXBWHF0lnhFxh/ cXDRbxRyPhgI+8tGiJDvEz59pbNj0NTbmZ0oiZBDQBRdxZPyILS+qXwM3Jcg7F7uaD6k KeLVHI+6njsR1ket2ZAQqpM6ZBA2i5kesq4TiWiq6Sm/V8RRxLIFyegT7kRBGDD3pgh3 CulzQ+0kAxnV1YKi1vwi9Hc6vDZtdBNFTbwTZPjGS/tJHndp7kHnkusxZSuM/VKqpXbg fiGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=3qQq8c00ltdsmjstYSJL4iTeZHerpCePZAOCl8LgI4E=; b=SF4+DDVNH8eIDgWmOuu/1agUvVL4wIbHEycTu/IkXoleXK8phSudoaDhjwLv/CkpK6 3ZVD9aynRsnKK18c8YEd1uCBYzW3rUPsXU52bq/NZxW/KANSt7phoBh8DjceWrYqzCfo RBy6drJIIvz8B0KRxi+P4hJ+G7bLAFJ5N278tfPWiz/bKYN9JfvMJh4wFv7bG5ajDkEq gHNSsb42buaTTaYKPKmBB7H6dyKt0siOgm+bLgbR9VL7CD8Y1t7qvNR2+ZEanX2ywbvx vhGacS99XFcMqEnaHEuxvxy8NIR8X/7F8VlMqk0YgfCXbj1d8cE0XGfljNalP716lieB OJVg== X-Gm-Message-State: AOAM532ctQEFLsxnRUOjlHvPKvs1z96ry1bqIlOVcAvXjHTNsoPOotn9 5IKut8lBOMPfR2Rn7iJ/2gA= X-Google-Smtp-Source: ABdhPJw9lx9M39HfQZowUT6ZcLZgExbv7mFZpp+yE0P+d762oRDLNVWKITSFqkFHqoAIYsj4rjjfwA== X-Received: by 2002:a63:ec0f:: with SMTP id j15mr10432679pgh.476.1633437861356; Tue, 05 Oct 2021 05:44:21 -0700 (PDT) Received: from localhost (61-219-114-7.hinet-ip.hinet.net. [61.219.114.7]) by smtp.gmail.com with ESMTPSA id v7sm17349299pff.195.2021.10.05.05.44.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Oct 2021 05:44:20 -0700 (PDT) From: Ihor Radchenko To: Max Nikulin Subject: [PATCH] [BUG] Org 9.5: org-goto UI seems broken In-Reply-To: References: <87mtnovv7f.fsf@alphapapa.net> Date: Tue, 05 Oct 2021 20:45:38 +0800 Message-ID: <87h7dvy70t.fsf@localhost> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2607:f8b0:4864:20::436; envelope-from=yantar92@gmail.com; helo=mail-pf1-x436.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Adam Porter , emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1633438003; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=3qQq8c00ltdsmjstYSJL4iTeZHerpCePZAOCl8LgI4E=; b=CHH+O5jhRHrv+1SUtcMglHcHexVRr7NWSzY58Y1Dx7bre/0sbGxPE6OtcAI5bb+GiNRIId Z2MOsKyhxWppNfelgBbwk7zwKHHx2yTzA54XIYxVN4JjEtNdBQXw5S1DkoVORakEaA0Bl8 92AHUvEI1hIOaacjmy8eevD8I0rO9cmoO7Kpnvg+IrvU8DrVn+t4lE632ckKPH5fnihIjF vA8eDTb+jcCVpmPGJrn6PEqxtkw1RpWp2nMA+9OokeQKx34oa3XPq6plhprZN9aYku30pc 3KSUhHda6qeUtnjWGu4MlszsUYqAVRZn5fvObIh5I0FRLQdjvU+um4JdzG42vw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1633438003; a=rsa-sha256; cv=none; b=pAdxaOBIbF2gMFQRtXZDzxTOZ3QqUtbixyM55FXnS4xWI7RYtovRNXt5DM7M/Usa2DELua Sm+SvfxAr32iVbKhEin6ErddUb9FAAFeYf8ygjBELKnVsousiE96UzyTdt5HHpRpRgEbSM 5NbEpWo6b58j0WSLGMDf54HyBS4kClvY2oORXdW+lbvCgyomcMy53//VylDz/SSVtX3kR5 0bUlEfMQvFkKZVtIxeIPOtaJth6LccAdNXofaufxfHpb2cPHTTu1Hvwgw41DUsrLXv5ePk sbGDRbYuQ0EJH32TiyK89GcivDRI+vhd16q5PTo5WhlUiTyulrSibRbvGlsICg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=aTlbLsGS; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -3.51 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=aTlbLsGS; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 3E628AAFE X-Spam-Score: -3.51 X-Migadu-Scanner: scn1.migadu.com X-TUID: Gvpp/lvY7OSC --=-=-= Content-Type: text/plain Max Nikulin writes: > Regression is caused by > > commit 399481bad10845a77f210c9320ff1efee9a312c8 > Author: Ihor Radchenko > Date: Mon May 31 20:47:45 2021 +0800 > > Do not ignore user-defined display-buffer-alist in org-insert-link See the attached fix. The fix looks reasonable, though I fail to understand why org-no-popup was even used in org-goto-location. We kind of want a popup there. git blame did not reveal anything useful either. Adam, can you test the fix in different scenarios first? I do not use org-goto interface, so I only did a light testing. Best, Ihor --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-org-goto-Fix-window-broken-arrangement-after-399481b.patch >From 72d62d9f54a356273b2fa8ccf4f71b9faccf280c Mon Sep 17 00:00:00 2001 Message-Id: <72d62d9f54a356273b2fa8ccf4f71b9faccf280c.1633437697.git.yantar92@gmail.com> From: Ihor Radchenko Date: Tue, 5 Oct 2021 20:37:02 +0800 Subject: [PATCH] org-goto: Fix window broken arrangement after 399481bad * lisp/org-goto.el (org-goto-location): Do not wrap code into `org-no-popups' macro. The macro prevents popup windows and we do want *Org Help* window as a popup herein. Fixes https://list.orgmode.org/e169a2f9-72b1-02bb-96c1-6e7368f646da@gmail.com/T/#t --- lisp/org-goto.el | 67 ++++++++++++++++++++++++------------------------ 1 file changed, 33 insertions(+), 34 deletions(-) diff --git a/lisp/org-goto.el b/lisp/org-goto.el index 0a3470f54..352bf9f2e 100644 --- a/lisp/org-goto.el +++ b/lisp/org-goto.el @@ -203,40 +203,39 @@ (defun org-goto-location (&optional _buf help) "Let the user select a location in current buffer. This function uses a recursive edit. It returns the selected position or nil." - (org-no-popups - (let ((isearch-mode-map org-goto-local-auto-isearch-map) - (isearch-hide-immediately nil) - (isearch-search-fun-function - (lambda () #'org-goto--local-search-headings)) - (help (or help org-goto-help))) - (save-excursion - (save-window-excursion - (delete-other-windows) - (and (get-buffer "*org-goto*") (kill-buffer "*org-goto*")) - (pop-to-buffer-same-window - (condition-case nil - (make-indirect-buffer (current-buffer) "*org-goto*" t) - (error (make-indirect-buffer (current-buffer) "*org-goto*" t)))) - (let (temp-buffer-show-function temp-buffer-show-hook) - (with-output-to-temp-buffer "*Org Help*" - (princ (format help (if org-goto-auto-isearch - " Just type for auto-isearch." - " n/p/f/b/u to navigate, q to quit."))))) - (org-fit-window-to-buffer (get-buffer-window "*Org Help*")) - (org-overview) - (setq buffer-read-only t) - (if (and (boundp 'org-goto-start-pos) - (integer-or-marker-p org-goto-start-pos)) - (progn (goto-char org-goto-start-pos) - (when (org-invisible-p) - (org-show-set-visibility 'lineage))) - (goto-char (point-min))) - (let (org-special-ctrl-a/e) (org-beginning-of-line)) - (message "Select location and press RET") - (use-local-map org-goto-map) - (recursive-edit))) - (kill-buffer "*org-goto*") - (cons org-goto-selected-point org-goto-exit-command)))) + (let ((isearch-mode-map org-goto-local-auto-isearch-map) + (isearch-hide-immediately nil) + (isearch-search-fun-function + (lambda () #'org-goto--local-search-headings)) + (help (or help org-goto-help))) + (save-excursion + (save-window-excursion + (delete-other-windows) + (and (get-buffer "*org-goto*") (kill-buffer "*org-goto*")) + (pop-to-buffer-same-window + (condition-case nil + (make-indirect-buffer (current-buffer) "*org-goto*" t) + (error (make-indirect-buffer (current-buffer) "*org-goto*" t)))) + (let (temp-buffer-show-function temp-buffer-show-hook) + (with-output-to-temp-buffer "*Org Help*" + (princ (format help (if org-goto-auto-isearch + " Just type for auto-isearch." + " n/p/f/b/u to navigate, q to quit."))))) + (org-fit-window-to-buffer (get-buffer-window "*Org Help*")) + (org-overview) + (setq buffer-read-only t) + (if (and (boundp 'org-goto-start-pos) + (integer-or-marker-p org-goto-start-pos)) + (progn (goto-char org-goto-start-pos) + (when (org-invisible-p) + (org-show-set-visibility 'lineage))) + (goto-char (point-min))) + (let (org-special-ctrl-a/e) (org-beginning-of-line)) + (message "Select location and press RET") + (use-local-map org-goto-map) + (recursive-edit))) + (kill-buffer "*org-goto*") + (cons org-goto-selected-point org-goto-exit-command))) ;;;###autoload (defun org-goto (&optional alternative-interface) -- 2.32.0 --=-=-=--