From: Ihor Radchenko <yantar92@gmail.com>
To: Mikhail Skorzhinskii <mskorzhinskiy@eml.cc>
Cc: Org Mode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] org-refile.el: show refile targets with doc. title
Date: Sun, 26 Dec 2021 21:59:29 +0800 [thread overview]
Message-ID: <87h7avsbzy.fsf@localhost> (raw)
In-Reply-To: <80f7d99b0cf16fefbcdd2db62c35f53946895162.camel@eml.cc>
Mikhail Skorzhinskii <mskorzhinskiy@eml.cc> writes:
> * lisp/org-refile.el (org-refile-use-outline-path): add an option
> 'title
This is an interesting idea. However, your patch may break things quite
badly. Look at `org-refile-get-location'. It expects a very specific
format for the refile targets and treats 'file/'full-file-path values
specially.
Can you add tests for your new value of org-refile-use-outline-path and
make sure that they do not fail after applying your patch?
Best,
Ihor
next prev parent reply other threads:[~2021-12-26 13:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-25 15:23 [PATCH] org-refile.el: show refile targets with doc. title Mikhail Skorzhinskii
2021-12-26 13:59 ` Ihor Radchenko [this message]
2021-12-28 11:59 ` Mikhail Skorzhinskii
2022-05-28 2:33 ` Ihor Radchenko
2022-08-30 13:53 ` Mikhail Skorzhisnkii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7avsbzy.fsf@localhost \
--to=yantar92@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=mskorzhinskiy@eml.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).