bug#52587: 29.0.50; Wrong block header/footer background in Org

bug#52587: 29.0.50; Wrong block header/footer background in Org

[Rudolf Adamkovič via General discussions about Org-mode.]

Protesilaos Stavrou <info@protesilaos.com> writes:

> [ I will sync with emacs.git as soon as I publish the next tagged
>   version (2.0.0).  It is a big one and the change log will take some
>   time to prepare...  Maybe this week. ]

I noticed "Update modus-themes to version 2.0.0" in the Git log.  Yet, I
compiled Emacs today (2021-12-26), and the gray area extends
edge-to-edge while modus-themes-org-blocks equals nil.  Perhaps I
misunderstood your intention?

Rudy
-- 
"Logic is a science of the necessary laws of thought, without which no employment of the understanding and the reason takes place." -- Immanuel Kant, 1785

Rudolf Adamkovič <salutis@me.com> [he/him]
Studenohorská 25
84103 Bratislava
Slovakia

bug#52587: 29.0.50; Wrong block header/footer background in Org

[Protesilaos Stavrou]

[-- Attachment #1: Type: text/plain, Size: 1152 bytes --]

On 2021-12-26, 11:22 +0100, Rudolf Adamkovič <salutis@me.com> wrote:

> Protesilaos Stavrou <info@protesilaos.com> writes:
>
>> [ I will sync with emacs.git as soon as I publish the next tagged
>>   version (2.0.0).  It is a big one and the change log will take some
>>   time to prepare...  Maybe this week. ]
>
> I noticed "Update modus-themes to version 2.0.0" in the Git log.  Yet, I
> compiled Emacs today (2021-12-26), and the gray area extends
> edge-to-edge while modus-themes-org-blocks equals nil.  Perhaps I
> misunderstood your intention?

No, you did not misunderstand my intention.  Maybe something else is
going on, as I am getting the expected results.  Check the attached
screenshot.

Steps to reproduce the screenshot:

- Create a file with demo content, such as ~/test-org-block.org:

    * Testing

    This is a test

    #+begin_src emacs-lisp
    (message "Hello world")
    #+end_src

    * Test

- Execute 'emacs -Q' on the command-line.
- C-x C-f test-org-block.org RET
- M-x load-theme RET modus-operandi

Do you get the same results?

-- 
Protesilaos Stavrou
https://protesilaos.com

[-- Attachment #2: screenshot_region_2021-12-26-13:18:19.png --]
[-- Type: image/png, Size: 25281 bytes --]

bug#52587: 29.0.50; Wrong block header/footer background in Org

[Rudolf Adamkovič via General discussions about Org-mode.]

[-- Attachment #1: Type: text/plain, Size: 344 bytes --]

Protesilaos Stavrou <info@protesilaos.com> writes:

> Do you get the same results?

Oh, I do!  That said, if I reverse last two steps, I do not:

> - Create a file with demo content, such as ~/test-org-block.org
> - Execute 'emacs -Q' on the command-line.
> - M-x load-theme RET modus-operandi
> - C-x C-f test-org-block.org RET

Then, I get:


[-- Attachment #2: Bug --]
[-- Type: image/png, Size: 372296 bytes --]

[-- Attachment #3: Type: text/plain, Size: 296 bytes --]


Rudy
-- 
"'Contrariwise,' continued Tweedledee, 'if it was so, it might be; and
if it were so, it would be; but as it isn't, it ain't. That's logic.'"
-- Lewis Carroll, Through the Looking Glass

Rudolf Adamkovič <salutis@me.com> [he/him]
Studenohorská 25
84103 Bratislava
Slovakia

bug#52587: 29.0.50; Wrong block header/footer background in Org

[Protesilaos Stavrou]

On 2021-12-26, 22:04 +0100, Rudolf Adamkovič <salutis@me.com> wrote:

> Protesilaos Stavrou <info@protesilaos.com> writes:
>
>> Do you get the same results?
>
> Oh, I do!  That said, if I reverse last two steps, I do not:
>
>> - Create a file with demo content, such as ~/test-org-block.org
>> - Execute 'emacs -Q' on the command-line.
>> - M-x load-theme RET modus-operandi
>> - C-x C-f test-org-block.org RET

Gotcha!  I can reproduce that.  It is not a theme issue.  I checked the
Org code a bit.  There is a function in org-compat.el called
'org--set-faces-extend' and in org.el we see it being used in the
(define-derived-mode org-mode ... part.

In other words, M-x org-mode wants those faces to have ':extend t'.

I must investigate this further, though my first impression is that we
need to notify the Org folks about it.

-- 
Protesilaos Stavrou
https://protesilaos.com

bug#52587: 29.0.50; Wrong block header/footer background in Org

[Kévin Le Gouguec]

Protesilaos Stavrou <info@protesilaos.com> writes:

> On 2021-12-26, 22:04 +0100, Rudolf Adamkovič <salutis@me.com> wrote:
>
>>> - Create a file with demo content, such as ~/test-org-block.org
>>> - Execute 'emacs -Q' on the command-line.
>>> - M-x load-theme RET modus-operandi
>>> - C-x C-f test-org-block.org RET
>
> Gotcha!  I can reproduce that.  It is not a theme issue.  I checked the
> Org code a bit.  There is a function in org-compat.el called
> 'org--set-faces-extend' and in org.el we see it being used in the
> (define-derived-mode org-mode ... part.
>
> In other words, M-x org-mode wants those faces to have ':extend t'.

Only when org-fontify-whole-block-delimiter-line is set (which it is, by
default, I think).