From: Ihor Radchenko <yantar92@gmail.com>
To: "David Lukeš" <dafydd.lukes@gmail.com>
Cc: Bruce D'Arcus <bdarcus@gmail.com>,
org-mode-email <emacs-orgmode@gnu.org>
Subject: Re: oc-basic: CSL-JSON year as number vs. string (nativecomp?)
Date: Tue, 21 Jun 2022 11:28:34 +0800 [thread overview]
Message-ID: <87h74esnj1.fsf@localhost> (raw)
In-Reply-To: <CAEPTPExAz6TDiZQ24kobh1jQ9Jfd-BYgpz3nknFV-hUziic8QA@mail.gmail.com>
David Lukeš <dafydd.lukes@gmail.com> writes:
>> Would you mind creating a patch and possibly supplying a test
>> that will make sure that the example file and similar are correctly
>> parsed?
>
> I'm attaching a patch (just the patch for now, no commit message), let
> me know what you think, in particular the error message. What would be
> an acceptable way to wrap the format string?
LGTM! There is no need to wrap the format string.
> As for tests -- if `oc-basic.el` already had some, I'd try to see if I
> can come up with something by analogy. But as it stands, I know too
> little about Elisp, nothing about Elisp testing, and have too little
> spare time, sorry :(
No problem. Your patch is already helpful.
Best,
Ihor
next prev parent reply other threads:[~2022-06-21 3:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-18 6:34 oc-basic: CSL-JSON year as number vs. string (nativecomp?) David Lukeš
2022-06-19 1:44 ` Ihor Radchenko
2022-06-19 1:55 ` Bruce D'Arcus
2022-06-19 3:31 ` David Lukeš
2022-06-19 13:39 ` Bruce D'Arcus
2022-06-20 12:06 ` Ihor Radchenko
2022-06-20 13:11 ` Bruce D'Arcus
2022-06-20 14:13 ` David Lukeš
2022-06-20 14:24 ` Bruce D'Arcus
2022-06-21 3:28 ` Ihor Radchenko [this message]
2022-06-21 12:02 ` David Lukeš
2022-07-31 4:05 ` Ihor Radchenko
2022-06-20 12:04 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h74esnj1.fsf@localhost \
--to=yantar92@gmail.com \
--cc=bdarcus@gmail.com \
--cc=dafydd.lukes@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).