emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@gmail.com>
To: Bruno Barbier <brubar.cs@gmail.com>, Bastien <bzg@gnu.org>
Cc: Felix Freeman <libsys@hacktivista.org>,  emacs-orgmode@gnu.org
Subject: Re: [BUG] ob-shell: cmdline and stdin broken when used with TRAMP
Date: Sun, 04 Sep 2022 17:49:08 +0800	[thread overview]
Message-ID: <87h71nxyej.fsf@localhost> (raw)
In-Reply-To: <E1oUWlR-0000jc-G0@lists.gnu.org>

Bruno Barbier <brubar.cs@gmail.com> writes:

>> You patch is >15LOC so we do need your copyright assignment before
>> merging. Let me know if you face any difficulties with the copyright
>> process. Note that FSF should reply within 5 working days.
> Done. I just learnt a few days ago the process is done.


Bastien, could you please check the FSF record.

>> > +                          (list shell-command-switch
>> > +                                (concat (file-local-name script-file)  " " cmdline)))
>> Probably you do not need concat here.
>> AFAIU, (list shell-command-switch (file-local-name script-file) cmdline)
>> should be good enough as ARGS argument of `process-file'.
> The shell process should receive 2 arguments: the switch and the
> command to execute.  I think the 'concat' is mandatory here.
> Am I missing something?

You are probably right. `concat' does not heart anyway.

>>> +(defconst org-test-tramp-remote-dir "/mock::/tmp/"
>>> +  "Remote tramp directory.
>>> +We really should use 'tramp-test-temporary-file-directory', but that would require TRAMP sources.")
>> Since TRAMP sources are not normally available, we can add this variable
>> as defined in tramp-tests.el somewhere into testing/org-test.el, for
>> example.
> I've copy/pasted the logic used in GNU Emacs Tramp and added a macro.
> I've added (require 'tramp) in the body; should I move it to the top
> of the file ?

Should not be a big deal to keep the require inside.

> From d9abfb423bff620dee15d204f4bab48e2ec8dc4e Mon Sep 17 00:00:00 2001
> From: Bruno BARBIER <brubar.cs@gmail.com>
> Date: Sat, 18 Jun 2022 09:48:01 +0200
> Subject: [PATCH] ob-shell: Use 'process-file' when stdin or cmdline

'->` :: `process-file' 

> lib/ob-shell.el (org-babel-sh-evaluate): Use `process-file' (instead


> +                (with-connection-local-variables

I tried to test your patch on various Emacs versions.
`with-connection-local-variables' is not yet available in Emacs 26.
Emacs 26 has `with-connection-local-profiles' though I am not sure if it
is a full equivalent. If not, you may need to create a compatibility
wrapper for Emacs 26.

Ihor Radchenko,
Org mode contributor,
Learn more about Org mode at https://orgmode.org/.
Support Org development at https://liberapay.com/org-mode,
or support my work at https://liberapay.com/yantar92

  reply	other threads:[~2022-09-04  9:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-10 18:42 [BUG] ob-shell: cmdline and stdin broken when used with TRAMP Felix Freeman via General discussions about Org-mode.
2022-06-18 18:54 ` Bruno Barbier
2022-06-23 12:46   ` Ihor Radchenko
2022-09-03 17:20     ` Bruno Barbier
2022-09-04  9:49       ` Ihor Radchenko [this message]
2022-09-04 17:08         ` Bruno Barbier
2022-09-05 10:33           ` Ihor Radchenko
2022-09-06 17:04             ` Bruno Barbier
2022-09-05  8:16         ` Bastien Guerry
2022-09-06 17:03           ` Bruno Barbier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h71nxyej.fsf@localhost \
    --to=yantar92@gmail.com \
    --cc=brubar.cs@gmail.com \
    --cc=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=libsys@hacktivista.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).