From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id OAHLN7j2H2OwrQAAbAwnHQ (envelope-from ) for ; Tue, 13 Sep 2022 05:19:20 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id KPjFN7j2H2O9OwAA9RJhRA (envelope-from ) for ; Tue, 13 Sep 2022 05:19:20 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7B76527F86 for ; Tue, 13 Sep 2022 05:19:20 +0200 (CEST) Received: from localhost ([::1]:38244 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oXwSE-0004HP-RC for larch@yhetil.org; Mon, 12 Sep 2022 23:19:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59684) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oXwR0-0004HH-1C for emacs-orgmode@gnu.org; Mon, 12 Sep 2022 23:18:02 -0400 Received: from mail-pl1-x635.google.com ([2607:f8b0:4864:20::635]:45808) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oXwQv-0006S1-D2 for emacs-orgmode@gnu.org; Mon, 12 Sep 2022 23:18:01 -0400 Received: by mail-pl1-x635.google.com with SMTP id u22so10450093plq.12 for ; Mon, 12 Sep 2022 20:17:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date; bh=AKFo1nY9l85hY+fawZmFce0fBH3/Jc2VKLVnqRfujm8=; b=iMGBPe2KhhtEM54iwz/eA2mweYys09tYmrGxxFX9QVYXNLBCSUs1xrKy4UYVWwYmSw sDrv2vTTTZAkAwfY86fp5IRHkWSGAvugktHgJhE6DZ9thQNFd/t19pca0czjQdaA8vpo Y5TrHBEYiGaTBFmbQq6rspulrgsBLOg7xQ2ojspV0CcjrHdJGGPqj801oFxgEMNBLh3e 2IxWRHLZui4PvR1GNcQ39fMisfXDMnsCWeNkNWTAQAq1saEKL0225VtyNFOhwWWBmcrO 9fSrPXHvJB/KFjRRevE0V4PbYM6nU/hiTy3rAfyXzvKxG3NgJpDJk6PeWyVeGirE+41u +P+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=AKFo1nY9l85hY+fawZmFce0fBH3/Jc2VKLVnqRfujm8=; b=6WBmMwWcJjH8g+eFiQgFlXko0N2qjbzUHI9Nkqezgj3r+odngUOzr6cgsRCf802yV0 tcp0Prp3ytypdFCiejXMFIXvG9fGp0IgLVpc1OHB+9Nozzylno5Exw9BvPftMis6+i4B Bd+b0PyzsJx2fGxXeOJ+qgfTepEna+O8RcyZamMYfIOAe7HdC9d/MMDhpE954dfz6Yfa fqd3H8M93CdoYTAObLCPbKogUGOiE7vORXEyxU5bJI53kp2GO3b0M9+qwKTvytc82s4O xz8/VA+hMKGS2d4Uys3GWWOXR0qReo44XL+gqybUYPkZlwhXyi8N4BznwTvBssTQD07S pVmA== X-Gm-Message-State: ACgBeo2xk73OftX3sFk/WvRivymtx1w2reNDcMvaWYjkkWNr1gBb8Vdl gkFthEr4o/YTU21feCmfWXQXG0XXi3afxg== X-Google-Smtp-Source: AA6agR7JXn1D+Z7Eni9h3SLSnFYlP6KeCT9Xug2cbOhruQ7HvWw72854Dfo297NQp+nguvPs8IeVjg== X-Received: by 2002:a17:90b:4b88:b0:202:e381:e643 with SMTP id lr8-20020a17090b4b8800b00202e381e643mr1691453pjb.148.1663039075410; Mon, 12 Sep 2022 20:17:55 -0700 (PDT) Received: from localhost ([2409:8970:a81:48f7:8ec6:81ff:fe70:339d]) by smtp.gmail.com with ESMTPSA id u14-20020a170902e80e00b0017685f53537sm6943151plg.186.2022.09.12.20.17.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Sep 2022 20:17:54 -0700 (PDT) From: Ihor Radchenko To: Stefan Monnier Cc: emacs-orgmode@gnu.org Subject: Re: org-assert-version considered harmful In-Reply-To: References: <875yhsujkq.fsf@localhost> Date: Tue, 13 Sep 2022 11:18:48 +0800 Message-ID: <87h71ct10n.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::635; envelope-from=yantar92@gmail.com; helo=mail-pl1-x635.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1663039160; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=AKFo1nY9l85hY+fawZmFce0fBH3/Jc2VKLVnqRfujm8=; b=V4p5WRT++xXl92Any2l240o29baMexRW772yCemvp9SOGKiWQXjgwNLhsYvyyB9bsnusPY nO1vBkP9t/xwdHZ+4+isRPMHm9yiqmcSaVRjjJw8i+eMLlD41SBbPuw6easYGbfLokHecK +udA8ovdKv5R7WKZJMJ2WoRmvMMC1zDUKaYZam6AsnB35WMbizQ6Iq48sOQk4KLGsyyaAW P6y4NrdgpSZcSeyPm5HSfAu9QjL6mp0uHqYHpVJq8l63D3Qk+icoWHrJ4v4++EoBNmmJU1 KjKM4D8+U5XYnLAfJ0XBGcLCvLC3esGfuu+9zLhf2Rbby+Y4kBPFkQNhGm8vFw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1663039160; a=rsa-sha256; cv=none; b=nPX4ruKYgSI2dHDbxAMlxKQZrMI81CN2YifHJENUIFKZQRIuvtuNkzZws+jPLfP05WUAna nS1SgYVAo+3zKb+4oKdq95/DAgXGJfvriolpJyBfiUpHJ888JJtcT6OGwrzgZ66Q7FqnAb SkFul81cYllIuTYF3UCVKhBSfJTr0N/bSK/VjoIeU+4WW/HBjghxrfNR4K0Zvp+iC3lyQt Jvi5p1zNBjFeM11fv/q5XyXGnAfsQbYvaB0tvCPnx9G+pNXwHhv7ydEgaNRLVfdAodZBJP DVV4pf7M9iwE0BOcHLnjwu+4COdlHaxFBTc6Rhtsub07E4tF3k9ZPoTgbQamog== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=iMGBPe2K; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.81 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=iMGBPe2K; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 7B76527F86 X-Spam-Score: -1.81 X-Migadu-Scanner: scn1.migadu.com X-TUID: 8vtokwk/fEe3 Stefan Monnier writes: >> Does it help if you run make autoloads after git fetch? > > Not that I can tell, no. But note that I'm not using Org's makefile to > compile the files, I'm using the elpa.git scripts instead, which don't > take into account dependencies between files. > > So the situation is simply something like: > > - git pull =3D> switches to 9.5.5, but several .el files are left uncha= nged. > - make autoloads =3D> this refreshes the autoloads, but the .elc files > of those .el files which didn't change still won't be recompiled. Isn't it a bug in the elpa scripts then? If a macro definition is changed and the .elc file using that macro is not changed, it still needs to be re-compiled. Otherwise, all kinds of unexpected side effects may appear. > I'm not really reporting a bug; I'm not sure how to solve the problem > without throwing away the benefits of `org-assert-version`. But I just > wanted to mention that it has unintended side effects :-) I understand. As Timothy proposed, we can make less strict checks for Org version consistency. But the question is whether we really need to make a more lax assertion or maybe it is better to keep the assertion as is and use it to catch potential issues e.g. in Elpa. > PS: BTW, I notice that when Org is installed as a normal `package.el` > package, in Emacs=E2=89=A528 it will be activated before the `.emacs`= file > is loaded, which should prevent occurrence of the problems that > `org-assert-version` aims to catch (unless you use, say, an > org-babel file for the `early-init.el` :-) Indeed. Version mismatch issue has been fixed in package.el years back. But it is starting to pop up again as alternative package managers are getting traction. There is a constant influx of bug reports caused by mixed installation. Especially by users of Doom Emacs and straight.el. Unfortunately, the problem cannot be easily solved, say, on straight.el side --- straight.el basic design is causing the issue to appear. > PPS: Maybe instead of calling `org-assert-version` everywhere, the > `org-autoloads.el` (i.e. the file that sets up the `load-path` and > the autoloads) could look for traces of Org files in the > `load-history` and signal an error if such files are found coming > from a different directory. No, unfortunately. org-autoloads, when loaded from built-in Emacs version will not help to catch newer Org libraries being loaded after built-in Org version is loaded. Moreover, I consider loading personal forks of built-in Org libraries a valid use-case. Demanding all the org libraries to be loaded from the same directory will limit this possibility. --=20 Ihor Radchenko, Org mode contributor, Learn more about Org mode at https://orgmode.org/. Support Org development at https://liberapay.com/org-mode, or support my work at https://liberapay.com/yantar92