[BUG] org-timer-start doesn't seem to take the timer string at point [9.5.5 (release_9.5.5 @ z:/emacs-i686/share/emacs/28.2/lisp/org/)]

[BUG] org-timer-start doesn't seem to take the timer string at point [9.5.5 (release_9.5.5 @ z:/emacs-i686/share/emacs/28.2/lisp/org/)]

[Ypo]

[-- Attachment #1: Type: text/plain, Size: 5149 bytes --]

In the manual, it says:

> C-c C-x 0 (|org-timer-start|)
>
>     ... If there is a timer string at point, this is taken as the
>     default, providing a convenient way to restart taking notes after
>     a break in the process...
>     https://orgmode.org/manual/Timers.html
>

I am trying it, but the timer starts at 0:00:00



> Emacs  : GNU Emacs 28.2 (build 2, x86_64-w64-mingw32)
>  of 2022-09-13
> Package: Org mode version 9.5.5 (release_9.5.5 @ 
> z:/emacs-i686/share/emacs/28.2/lisp/org/)
>
> current state:
> ==============
> (setq
>  org-link-elisp-confirm-function 'yes-or-no-p
>  org-bibtex-headline-format-function #[257 "\300\x01\236A\207" [:title] 3 
> "\n\n(fn ENTRY)"]
>  org-export-before-parsing-hook '(org-attach-expand-links)
>  org-archive-hook '(org-attach-archive-delete-maybe)
>  org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers
>           org-cycle-show-empty-lines
>           org-optimize-window-after-visibility-change)
>  org-mode-hook '(#[0 "\300\301\302\303\304$\207"
>            [add-hook change-major-mode-hook org-show-all append local]
>            5]
>          #[0 "\300\301\302\303\304$\207"
>            [add-hook change-major-mode-hook org-babel-show-result-all
>             append local]
>            5]
>          org-babel-result-hide-spec org-babel-hide-all-hashes)
>  org-confirm-shell-link-function 'yes-or-no-p
>  outline-isearch-open-invisible-function 'outline-isearch-open-invisible
>  org-agenda-before-write-hook '(org-agenda-add-entry-text)
>  org-src-mode-hook '(org-src-babel-configure-edit-buffer
>              org-src-mode-configure-edit-buffer)
>  org-confirm-elisp-link-function 'yes-or-no-p
>  org-speed-command-hook '(org-speed-command-activate
>               org-babel-speed-command-activate)
>  org-tab-first-hook '(org-babel-hide-result-toggle-maybe
>               org-babel-header-arg-expand)
>  org-link-shell-confirm-function 'yes-or-no-p
>  org-babel-pre-tangle-hook '(save-buffer)
>  org-agenda-loop-over-headlines-in-active-region nil
>  org-occur-hook '(org-first-headline-recenter)
>  org-metadown-hook '(org-babel-pop-to-session-maybe)
>  org-link-parameters '(("attachment" :follow org-attach-follow :complete
>             org-attach-complete-link)
>                ("id" :follow org-id-open)
>                ("eww" :follow org-eww-open :store org-eww-store-link)
>                ("rmail" :follow org-rmail-open :store
>             org-rmail-store-link)
>                ("mhe" :follow org-mhe-open :store org-mhe-store-link)
>                ("irc" :follow org-irc-visit :store org-irc-store-link
>             :export org-irc-export)
>                ("info" :follow org-info-open :export org-info-export
>             :store org-info-store-link)
>                ("gnus" :follow org-gnus-open :store
>             org-gnus-store-link)
>                ("docview" :follow org-docview-open :export
>             org-docview-export :store org-docview-store-link)
>                ("bibtex" :follow org-bibtex-open :store
>             org-bibtex-store-link)
>                ("bbdb" :follow org-bbdb-open :export org-bbdb-export
>             :complete org-bbdb-complete-link :store
>             org-bbdb-store-link)
>                ("w3m" :store org-w3m-store-link)
>                ("doi" :follow org-link-doi-open :export
>             org-link-doi-export)
>                ("file+sys") ("file+emacs")
>                ("shell" :follow org-link--open-shell)
>                ("news" :follow
>             #[514 "\301\300\302\x04Q\x02\"\207"
>               ["news" browse-url ":"] 6 "\n\n(fn URL ARG)"]
>             )
>                ("mailto" :follow
>             #[514 "\301\300\302\x04Q\x02\"\207"
>               ["mailto" browse-url ":"] 6 "\n\n(fn URL ARG)"]
>             )
>                ("https" :follow
>             #[514 "\301\300\302\x04Q\x02\"\207"
>               ["https" browse-url ":"] 6 "\n\n(fn URL ARG)"]
>             )
>                ("http" :follow
>             #[514 "\301\300\302\x04Q\x02\"\207"
>               ["http" browse-url ":"] 6 "\n\n(fn URL ARG)"]
>             )
>                ("ftp" :follow
>             #[514 "\301\300\302\x04Q\x02\"\207" ["ftp" browse-url ":"]
>               6 "\n\n(fn URL ARG)"]
>             )
>                ("help" :follow org-link--open-help :store
>             org-link--store-help)
>                ("file" :complete org-link-complete-file)
>                ("elisp" :follow org-link--open-elisp))
>  org-metaup-hook '(org-babel-load-in-session-maybe)
>  )





[-- Attachment #2: Type: text/html, Size: 7007 bytes --]

Re: [BUG] org-timer-start doesn't seem to take the timer string at point [9.5.5 (release_9.5.5 @ z:/emacs-i686/share/emacs/28.2/lisp/org/)]

[Ihor Radchenko]

Ypo <ypuntot@gmail.com> writes:

> In the manual, it says:
>
>> C-c C-x 0 (|org-timer-start|)
>>
>>     ... If there is a timer string at point, this is taken as the
>>     default, providing a convenient way to restart taking notes after
>>     a break in the process...
>>     https://orgmode.org/manual/Timers.html
>>
>
> I am trying it, but the timer starts at 0:00:00

You missed the previous sentence in the manual.

    When called with a ‘C-u’ prefix, prompt the user for a starting
    offset.  If there is a timer string at point, this is taken as the
    default, ...

The value at point is only taken into account with prefix argument.

-- 
Ihor Radchenko (yantar92),
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: [BUG] org-timer-start doesn't seem to take the timer string at point [9.5.5 (release_9.5.5 @ z:/emacs-i686/share/emacs/28.2/lisp/org/)]

[Ypo]

[-- Attachment #1: Type: text/plain, Size: 1177 bytes --]

Oh! Thanks

I didn't understand. Maybe this would be more understandable?:

>   When called with a ‘C-u’ prefix, prompt the user for a starting
>      offset or, if there is a timer string at point, this is taken as the
>      default, ...
Or:

>   When called with a ‘C-u’ prefix, there are 2 options: prompt the user for a starting
>      offset.  Or, if there is a timer string at point, this is taken as the
>      default, ...


El 02/10/2022 a las 15:37, Ihor Radchenko escribió:
> Ypo<ypuntot@gmail.com>  writes:
>
>> In the manual, it says:
>>
>>> C-c C-x 0 (|org-timer-start|)
>>>
>>>      ... If there is a timer string at point, this is taken as the
>>>      default, providing a convenient way to restart taking notes after
>>>      a break in the process...
>>>      https://orgmode.org/manual/Timers.html
>>>
>> I am trying it, but the timer starts at 0:00:00
> You missed the previous sentence in the manual.
>
>      When called with a ‘C-u’ prefix, prompt the user for a starting
>      offset.  If there is a timer string at point, this is taken as the
>      default, ...
>
> The value at point is only taken into account with prefix argument.
>

[-- Attachment #2: Type: text/html, Size: 2442 bytes --]

Re: [BUG] org-timer-start doesn't seem to take the timer string at point [9.5.5 (release_9.5.5 @ z:/emacs-i686/share/emacs/28.2/lisp/org/)]

[Ihor Radchenko]

[-- Attachment #1: Type: text/plain, Size: 581 bytes --]

Ypo <ypuntot@gmail.com> writes:

> Oh! Thanks
>
> I didn't understand. Maybe this would be more understandable?:
>
>>   When called with a ‘C-u’ prefix, prompt the user for a starting
>>      offset or, if there is a timer string at point, this is taken as the
>>      default, ...
> Or:
>
>>   When called with a ‘C-u’ prefix, there are 2 options: prompt the user for a starting
>>      offset.  Or, if there is a timer string at point, this is taken as the
>>      default, ...

Your versions still feel a bit confusing.
What about the attached patch?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-org-manual-Clarify-org-timer-start-command-descripti.patch --]
[-- Type: text/x-patch, Size: 1928 bytes --]

From 1efdf049475dfa9d4cdf219d665c4afcb32ed7cc Mon Sep 17 00:00:00 2001
Message-Id: <1efdf049475dfa9d4cdf219d665c4afcb32ed7cc.1664765817.git.yantar92@gmail.com>
From: Ihor Radchenko <yantar92@gmail.com>
Date: Mon, 3 Oct 2022 10:55:33 +0800
Subject: [PATCH] org-manual: Clarify `org-timer-start' command description

* doc/org-manual.org (Taking Notes with a Relative Timer): Emphasize
that timer at point is only taken into account when called with prefix
argument.

Reported-by: Ypo <ypuntot@gmail.com>
Link: https://orgmode.org/list/ae3befcf-1f62-fc84-e63c-16cd45bbaf78@gmail.com
---
 doc/org-manual.org | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/doc/org-manual.org b/doc/org-manual.org
index d249f32d6..618feb5fd 100644
--- a/doc/org-manual.org
+++ b/doc/org-manual.org
@@ -7126,12 +7126,12 @@ ** Taking Notes with a Relative Timer
   #+findex: org-timer-start
   Start or reset the relative timer.  By default, the timer is set
   to 0.  When called with a {{{kbd(C-u)}}} prefix, prompt the user for
-  a starting offset.  If there is a timer string at point, this is
-  taken as the default, providing a convenient way to restart taking
-  notes after a break in the process.  When called with a double
-  prefix argument {{{kbd(C-u C-u)}}}, change all timer strings in the
-  active region by a certain amount.  This can be used to fix timer
-  strings if the timer was not started at exactly the right moment.
+  a starting offset.  The prompt will default to a timer string at
+  point (if any), providing a convenient way to restart taking notes
+  after a break in the process.  When called with a double prefix
+  argument {{{kbd(C-u C-u)}}}, change all timer strings in the active
+  region by a certain amount.  This can be used to fix timer strings
+  if the timer was not started at exactly the right moment.
 
 - {{{kbd(C-c C-x ;)}}} (~org-timer-set-timer~) ::
 
-- 
2.35.1


[-- Attachment #3: Type: text/plain, Size: 225 bytes --]



-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: [BUG] org-timer-start doesn't seem to take the timer string at point [9.5.5 (release_9.5.5 @ z:/emacs-i686/share/emacs/28.2/lisp/org/)]

[Ypo]

[-- Attachment #1: Type: text/plain, Size: 942 bytes --]

Sorry for my delayed answer. But I don't see it either :/

"The prompt will default to a timer string at
+  point (if any),"

I can't see it well related to the C-u prefix. For example why the "(if 
any)"? It should be unnecessary, since it is the previous explained 
general case.

Best regards


El 03/10/2022 a las 4:57, Ihor Radchenko escribió:
> Ypo<ypuntot@gmail.com>  writes:
>
>> Oh! Thanks
>>
>> I didn't understand. Maybe this would be more understandable?:
>>
>>>    When called with a ‘C-u’ prefix, prompt the user for a starting
>>>       offset or, if there is a timer string at point, this is taken as the
>>>       default, ...
>> Or:
>>
>>>    When called with a ‘C-u’ prefix, there are 2 options: prompt the user for a starting
>>>       offset.  Or, if there is a timer string at point, this is taken as the
>>>       default, ...
> Your versions still feel a bit confusing.
> What about the attached patch?
>
>
>

[-- Attachment #2: Type: text/html, Size: 2149 bytes --]

Re: [BUG] org-timer-start doesn't seem to take the timer string at point [9.5.5 (release_9.5.5 @ z:/emacs-i686/share/emacs/28.2/lisp/org/)]

[Ihor Radchenko]

Ypo <ypuntot@gmail.com> writes:

> Sorry for my delayed answer. But I don't see it either :/
>
> "The prompt will default to a timer string at
> +  point (if any),"
>
> I can't see it well related to the C-u prefix. For example why the "(if 
> any)"? It should be unnecessary, since it is the previous explained 
> general case.

I feel that you missed the context by reading only the diff in the commit.
The full text in the manual after applying the patch reads like:

- {{{kbd(C-c C-x 0)}}} (~org-timer-start~) ::

  #+kindex: C-c C-x 0
  #+findex: org-timer-start
  Start or reset the relative timer.  By default, the timer is set
  to 0.  When called with a {{{kbd(C-u)}}} prefix, prompt the user for
  a starting offset.  The prompt will default to a timer string at
  point (if any), providing a convenient way to restart taking notes
  after a break in the process.  When called with a double prefix
  argument {{{kbd(C-u C-u)}}}, change all timer strings in the active
  region by a certain amount.  This can be used to fix timer strings
  if the timer was not started at exactly the right moment.



-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: [BUG] org-timer-start doesn't seem to take the timer string at point [9.5.5 (release_9.5.5 @ z:/emacs-i686/share/emacs/28.2/lisp/org/)]

[Ihor Radchenko]

Ihor Radchenko <yantar92@gmail.com> writes:

> From 1efdf049475dfa9d4cdf219d665c4afcb32ed7cc Mon Sep 17 00:00:00 2001
> Message-Id: <1efdf049475dfa9d4cdf219d665c4afcb32ed7cc.1664765817.git.yantar92@gmail.com>
> From: Ihor Radchenko <yantar92@gmail.com>
> Date: Mon, 3 Oct 2022 10:55:33 +0800
> Subject: [PATCH] org-manual: Clarify `org-timer-start' command description

Applied onto main.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=cce846e5f7a4900cc97d2c10b16abf3cf7f9056c

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>