From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id oA8AADk4sGMDHwEAbAwnHQ (envelope-from ) for ; Sat, 31 Dec 2022 14:25:13 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id kPc7ADk4sGP5ZAAAauVa8A (envelope-from ) for ; Sat, 31 Dec 2022 14:25:13 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CFA212EB66 for ; Sat, 31 Dec 2022 14:25:11 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pBbqY-0001R0-Q7; Sat, 31 Dec 2022 08:24:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBbqR-0001Qg-04 for emacs-orgmode@gnu.org; Sat, 31 Dec 2022 08:24:15 -0500 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBbqM-000898-SR for emacs-orgmode@gnu.org; Sat, 31 Dec 2022 08:24:13 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 0770D24023D for ; Sat, 31 Dec 2022 14:24:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1672493046; bh=dnSUh6bKU0MQ0PAOWNAPDzuIZczhc45/eXtqQNSR18g=; h=From:To:Cc:Subject:Date:From; b=Z3v/Z31z5IkqN5rAVaGq3azmxTcKbiI7l3aT8uELWCylq6/vJz1BdR9JtIUNpg2uI VzZY0hCERYlyXDC0ms7XjIKPqLPzp51CpDwRyr0vYiUp4iOtPLgq8zOeqJEspCxb1h hYWvTh1R6mar93KuBw+tJpkLcp7vILhHnqkEbWLDlLSAJOUw42WNhFnGiZTL/HD759 K9ZzEwUfmwnw1s4stJ2zojKgUGsR4QEyF7N3KUj7kadO5I6jKUj+jemVSc0wLOi9Xd QsZm/dRd+cXqHoQ0RyKmT5HAdN7zqd0u83NS3NI9FS920YbJAsWKCmTd2B/mKh0Q63 kGPlXElSFtI/A== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NkjWn2Kstz9rxG; Sat, 31 Dec 2022 14:24:05 +0100 (CET) From: Ihor Radchenko To: Marc =?utf-8?Q?Nieper-Wi=C3=9Fkirchen?= Cc: Rudolf =?utf-8?Q?Adamkovi=C4=8D?= , emacs-orgmode@gnu.org Subject: Re: Babel (scheme): Evaluation errors are not shown In-Reply-To: References: <87k02o7uki.fsf@localhost> <87fscvc379.fsf@localhost> <87bknjbwtw.fsf@localhost> Date: Sat, 31 Dec 2022 13:24:36 +0000 Message-ID: <87h6xbaep7.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1672493111; a=rsa-sha256; cv=none; b=KdB4oiabONebC6v9wEPgFO8DUoiFaQStoaH/5hooTIwt9f1WLAUHsPDbtUji/Qr2nn+kmD wMHig4WMgxv4jmiYL/cnvgF2YS6NYtWfwX21UFOZd9zNtG6e2/GsaDJcyCg1WyRBgFlojQ FJW0DlG5vl4VFUvW9Z+r15arBjgy4FDhyoKz5PxZSViIBm4cdByd5dtQ0BxgL1+lJ57QB+ qUEcrOa66sJek2VLOEioqsr9G8HE6Ja1pTk7jxsJRdn/28yfCrUKKckh817EJh8NkXPC3h I+b0Da4DB/cNlAnt0iF+XlmEhED0u5FsG7vuCdL/GlY83VIqT/SrGIQCoNuNfQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b="Z3v/Z31z"; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1672493111; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=F4VnHRpvLwLEyBgGqU5xFkD6pz5hBPrZQyTZdUD4Uko=; b=OM1nXXwdo6QCFO4vSJjI6lhLIlLpKL7Q9JIx9Jhr8qATy2IjIQugJibIaKlefrox+EpbRT yK8n13HVxn0vtzKIrMMMH4Gd2clWFJW7J5NcFrfDoKH4QouktJ2Pso8NiwC2gZC8zq7EZy B20yT1FwnNxiV6U5f3615NS+qSzy7pJLDLOifeOQlOkeorCDHF8feoukFAJz7MCClAfraz pJ5b7mIlSC12pBszWoZu81eEKbuH5fJUnEDLnKyztSL/Nqe8TBXdXTKIf7soBAVJ3zb6Rx hlqrZPXaGbDSOkaJzjI6k54Y0/0Qj0QTPvICbXAKG5uv0c2wgSSnLd0LRmEb1w== X-Spam-Score: -7.97 X-Migadu-Queue-Id: CFA212EB66 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b="Z3v/Z31z"; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -7.97 X-TUID: a48CjWsTgNNr Marc Nieper-Wi=C3=9Fkirchen writes: > Please find the patch file attached to this email. Thanks! I will give some general comments and leave the ob-scheme changes for Rudolf. > Subject: [PATCH] Display evaluation errors for Scheme code blocks. If you can, please provide changelog entries explaining each change. See https://orgmode.org/worg/org-contribute.html#commit-messages > (let ((buf (get-buffer-create org-babel-error-buffer-name))) > (with-current-buffer buf > (goto-char (point-max)) > (save-excursion > (unless (bolp) (insert "\n")) > (insert stderr) > - (insert (format "[ Babel evaluation exited with code %S ]" exit-= code)))) > + (when exit-code > + (insert (format "[ Babel evaluation exited with code %S ]" exi= t-code))))) I think it will be more consistent to do something like (if exit-code ... (insert " [ Babel evaluation exited abnormally ] ")) --=20 Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at