[BUG] Org-9.6 declares compatibility with Emacs-25.1

[BUG] Org-9.6 declares compatibility with Emacs-25.1

[Max Nikulin]

Hi,

Notice emacs-25.1 in the elpa package description:

      Status: Available Obsolete from gnu -- Install
     Archive: gnu
     Version: 9.6
      Commit: b3da427ebb1c401355aa4cba9baeaa92f87ccb2f
     Summary: Outline-based notes management and organizer
    Requires: emacs-25.1
    Homepage: https://orgmode.org
    Keywords: outlines hypermedia calendar wp
  Maintainer: Bastien Guerry <bzg@gnu.org>
      Author: Carsten Dominik <carsten.dominik@gmail.com>
Other versions: 9.6 (installed), 9.5.2 (installed), 9.3 (builtin).

and

lisp/org.el:10:;; Package-Requires: ((emacs "25.1"))

Attempt to use Org with emacs-25.2.2 (Ubuntu-18.04 LTS bionic) causes an 
error
> File mode specification error: (void-function temporary-file-directory)
and the buffer remains in the fundamental mode.

My expectations:
- either Package-Requires is updated to emacs-26.1
- or Org is modified to be usable at least with limited set of features 
and it is clarified why Package-Requires may be less than the version 
declared by 
https://orgmode.org/worg/org-maintenance.html#emacs-compatibility.

> Debugger entered--Lisp error: (void-function temporary-file-directory)
>   (temporary-file-directory)
>   (expand-file-name (format "babel-stable-%d" (random 1000)) (temporary-file-directory))
>   (setq dir (expand-file-name (format "babel-stable-%d" (random 1000)) (temporary-file-directory)))
>   (while (or (not dir) (file-exists-p dir)) (setq dir (expand-file-name (format "babel-stable-%d" (random 1000)) (temporary-file-directory))))
>   (let (dir) (while (or (not dir) (file-exists-p dir)) (setq dir (expand-file-name (format "babel-stable-%d" (random 1000)) (temporary-file-directory)))) (make-directory dir) dir)
>   (if noninteractive nil (let (dir) (while (or (not dir) (file-exists-p dir)) (setq dir (expand-file-name (format "babel-stable-%d" (random 1000)) (temporary-file-directory)))) (make-directory dir) dir))
>   (defvar org-babel-temporary-stable-directory (if noninteractive nil (let (dir) (while (or (not dir) (file-exists-p dir)) (setq dir (expand-file-name (format "babel-stable-%d" (random 1000)) (temporary-file-directory)))) (make-directory dir) dir)) "Directory to hold temporary files created to execute code blocks.\nUsed by `org-babel-temp-file'.  This directory will be removed on\nEmacs shutdown.")
>   eval-buffer(#<buffer  *load*-215051> nil "/home/ubuntu/org-mode/lisp/ob-core.el" nil t)  ; Reading at buffer position 128878
>   load-with-code-conversion("/home/ubuntu/org-mode/lisp/ob-core.el" "/home/ubuntu/org-mode/lisp/ob-core.el" nil t)
>   require(ob-core)
>   eval-buffer(#<buffer  *load*-363988> nil "/home/ubuntu/org-mode/lisp/ob-emacs-lisp.el" nil t)  ; Reading at buffer position 1072
>   load-with-code-conversion("/home/ubuntu/org-mode/lisp/ob-emacs-lisp.el" "/home/ubuntu/org-mode/lisp/ob-emacs-lisp.el" nil t)
>   require(ob-emacs-lisp)
>   (if active (require (intern (concat "ob-" lang))) (fmakunbound (intern (concat "org-babel-execute:" lang))) (fmakunbound (intern (concat "org-babel-expand-body:" lang))))
>   (let ((active (cdr pair)) (lang (symbol-name (car pair)))) (if active (require (intern (concat "ob-" lang))) (fmakunbound (intern (concat "org-babel-execute:" lang))) (fmakunbound (intern (concat "org-babel-expand-body:" lang)))))
>   (let ((pair (car --dolist-tail--))) (let ((active (cdr pair)) (lang (symbol-name (car pair)))) (if active (require (intern (concat "ob-" lang))) (fmakunbound (intern (concat "org-babel-execute:" lang))) (fmakunbound (intern (concat "org-babel-expand-body:" lang))))) (setq --dolist-tail-- (cdr --dolist-tail--)))
>   (while --dolist-tail-- (let ((pair (car --dolist-tail--))) (let ((active (cdr pair)) (lang (symbol-name (car pair)))) (if active (require (intern (concat "ob-" lang))) (fmakunbound (intern (concat "org-babel-execute:" lang))) (fmakunbound (intern (concat "org-babel-expand-body:" lang))))) (setq --dolist-tail-- (cdr --dolist-tail--))))
>   (let ((--dolist-tail-- org-babel-load-languages)) (while --dolist-tail-- (let ((pair (car --dolist-tail--))) (let ((active (cdr pair)) (lang (symbol-name (car pair)))) (if active (require (intern (concat "ob-" lang))) (fmakunbound (intern (concat "org-babel-execute:" lang))) (fmakunbound (intern (concat "org-babel-expand-body:" lang))))) (setq --dolist-tail-- (cdr --dolist-tail--)))))
>   org-babel-do-load-languages(org-babel-load-languages ((emacs-lisp . t)))
>   custom-initialize-reset(org-babel-load-languages (funcall (function (closure (crm-separator org-babel-load-languages org-id-overriding-file-name org-indent-indentation-per-level org-element--timestamp-regexp org-element-cache-map-continue-from org-element-paragraph-separate org-agenda-buffer-name org-inlinetask-min-level t) nil (quote ((emacs-lisp . t)))))))
>   custom-declare-variable(org-babel-load-languages (funcall (function (closure (crm-separator org-babel-load-languages org-id-overriding-file-name org-indent-indentation-per-level org-element--timestamp-regexp org-element-cache-map-continue-from org-element-paragraph-separate org-agenda-buffer-name org-inlinetask-min-level t) nil (quote ((emacs-lisp . t)))))) "Languages which can be evaluated in Org buffers.\n\\<org-mode-map>\nThis list can be used to load support for any of the available\nlanguages with babel support (see info node `(org) Languages').  Each\nlanguage will depend on a different set of system executables and/or\nEmacs modes.\n\nWhen a language is \"loaded\", code blocks in that language can\nbe evaluated with `org-babel-execute-src-block', which is bound\nby default to \\[org-ctrl-c-ctrl-c].\n\nThe `org-babel-no-eval-on-ctrl-c-ctrl-c' option can be set to\nremove code block evaluation from \\[org-ctrl-c-ctrl-c].  By\ndefault, only Emacs Lisp is loaded, since it has no specific\nrequirement." :group org-babel :set org-babel-do-load-languages :version "24.1" :type (alist :tag "Babel Languages" :key-type (choice (const :tag "Awk" awk) (const :tag "C" C) (const :tag "R" R) (const :tag "Calc" calc) (const :tag "Clojure" clojure) (const :tag "CSS" css) (const :tag "Ditaa" ditaa) (const :tag "Dot" dot) (const :tag "Emacs Lisp" emacs-lisp) (const :tag "Forth" forth) (const :tag "Fortran" fortran) (const :tag "Gnuplot" gnuplot) (const :tag "Haskell" haskell) (const :tag "Java" java) (const :tag "Javascript" js) (const :tag "LaTeX" latex) (const :tag "Lilypond" lilypond) (const :tag "Lisp" lisp) (const :tag "Makefile" makefile) (const :tag "Maxima" maxima) (const :tag "Matlab" matlab) (const :tag "Ocaml" ocaml) (const :tag "Octave" octave) (const :tag "Org" org) (const :tag "Perl" perl) (const :tag "Pico Lisp" picolisp) (const :tag "PlantUML" plantuml) (const :tag "Python" python) (const :tag "Ruby" ruby) (const :tag "Sass" sass) (const :tag "Scala" scala) (const :tag "Scheme" scheme) (const :tag "Screen" screen) (const :tag "Shell Script" shell) (const :tag "Sql" sql) (const :tag "Sqlite" sqlite) (const :tag "Stan" stan)) :value-type (boolean :tag "Activate" :value t)))
>   eval-buffer(#<buffer  *load*> nil "/home/ubuntu/org-mode/lisp/org.el" nil t)  ; Reading at buffer position 15758
>   load-with-code-conversion("/home/ubuntu/org-mode/lisp/org.el" "/home/ubuntu/org-mode/lisp/org.el" nil t)
>   org-mode()
>   set-auto-mode-0(org-mode nil)
>   set-auto-mode()
>   normal-mode(t)
>   after-find-file(nil t)
>   find-file-noselect-1(#<buffer emphasis.org> "~/examples-org/emphasis.org" nil nil "~/examples-org/emphasis.org" (3448399 2068))
>   find-file-noselect("~/examples-org/emphasis.org" nil nil t)
>   find-file("~/examples-org/emphasis.org" t)
>   funcall-interactively(find-file "~/examples-org/emphasis.org" t)
>   call-interactively(find-file nil nil)
>   command-execute(find-file)

Re: [BUG] Org-9.6 declares compatibility with Emacs-25.1

[Timothy]

[-- Attachment #1: Type: text/plain, Size: 407 bytes --]

Hi Max,

> Notice emacs-25.1 in the elpa package description:

Yea, I’m pretty sure this is just an oversight. This should be bumped to 26.

All the best,
Timothy

-- 
Timothy (‘tecosaur’/‘TEC’), Org mode contributor.
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/tec>.

Re: [BUG] Org-9.6 declares compatibility with Emacs-25.1

[Tim Cross]

Timothy <orgmode@tec.tecosaur.net> writes:

> Hi Max,
>
>> Notice emacs-25.1 in the elpa package description:
>
> Yea, I’m pretty sure this is just an oversight. This should be bumped to 26.
>

Yep, that would be my assumption as well. Support is for the two
previous releases i.e. 27.x and 26.x.

Re: [BUG] Org-9.6 declares compatibility with Emacs-25.1

[Ihor Radchenko]

Max Nikulin <manikulin@gmail.com> writes:

> lisp/org.el:10:;; Package-Requires: ((emacs "25.1"))

We should indeed bump the minimal required Emacs version.
Should we use Emacs 26.3 as the minimal version?

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: [BUG] Org-9.6 declares compatibility with Emacs-25.1

[Ihor Radchenko]

Ihor Radchenko <yantar92@posteo.net> writes:

> Max Nikulin <manikulin@gmail.com> writes:
>
>> lisp/org.el:10:;; Package-Requires: ((emacs "25.1"))
>
> We should indeed bump the minimal required Emacs version.
> Should we use Emacs 26.3 as the minimal version?

We should fix this before Org 9.6.1.
I will leave the decision about exact Emacs version to Bastien.

One notable fact is that Debian oldstable we use on CI [1] appears to
use Emacs 26.1. So, we are probably safe to declare Emacs 26.1
compatibility.

[1] https://builds.sr.ht/api/jobs/915058/manifest

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: [BUG] Org-9.6 declares compatibility with Emacs-25.1

[Ihor Radchenko]

Ihor Radchenko <yantar92@posteo.net> writes:

> We should fix this before Org 9.6.1.
> I will leave the decision about exact Emacs version to Bastien.
>
> One notable fact is that Debian oldstable we use on CI [1] appears to
> use Emacs 26.1. So, we are probably safe to declare Emacs 26.1
> compatibility.
>
> [1] https://builds.sr.ht/api/jobs/915058/manifest

Given that we have started getting some bug reports about Org not
working in Emacs 25, I just bumped the version requirement on bugfix.
This will prevents Emacs 25 installing incompatible versions of Org.

https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=c7b976a05

Bastien, please let me know if you have any objections.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: [BUG] Org-9.6 declares compatibility with Emacs-25.1

[Bastien Guerry]

Ihor Radchenko <yantar92@posteo.net> writes:

> Bastien, please let me know if you have any objections.

None, thanks for taking action here.

-- 
 Bastien