From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id mDVbLBnEzmMFLAAAbAwnHQ (envelope-from ) for ; Mon, 23 Jan 2023 18:30:01 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id MKyLKxnEzmPadgEAG6o9tA (envelope-from ) for ; Mon, 23 Jan 2023 18:30:01 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5BF6936AEA for ; Mon, 23 Jan 2023 18:30:01 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pK0cq-0005AM-Aa; Mon, 23 Jan 2023 12:28:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pK0ci-00059q-8Z for emacs-orgmode@gnu.org; Mon, 23 Jan 2023 12:28:48 -0500 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pK0cg-0005xd-BE for emacs-orgmode@gnu.org; Mon, 23 Jan 2023 12:28:47 -0500 Received: by mail-wr1-x430.google.com with SMTP id r9so11528962wrw.4 for ; Mon, 23 Jan 2023 09:28:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=Jtl3FBMQrkFU7wptSB4RNgK/0kFHQ0MLXsqxP6i8U9k=; b=HDjN+ccTEP06EeNI+oC5L42xOdyM23oeFtayclxRKer4C4QE+vLSHcXjkqD4mzBofJ to/bBpOgHaEZ6snzQBPxGpWwnaX575/1pFN9OnXs5UeIyq/hQ5TIjgAjTnaWgWeRNiwc Te+CSE7EqVgloghgRjMwdsOItkVvmd4zDKnsxMwHR6yb+yDvCzDcE2npRfFGrePoMDOY t/tVyTsHqk8LbPxHMFHOkSX+HQsvH8l3Rp0psCP9aNAxRoA7Sh5GEXYHliQucXngloLa pPvZ6VIvJRUj56HtrrUO/yWF1FuJFbOwX3FpGX3RBTh7APgPVovgJNWoEFaSpGaapepD Lvvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Jtl3FBMQrkFU7wptSB4RNgK/0kFHQ0MLXsqxP6i8U9k=; b=bx+Jqq705OI7ugZ8WHrZ1TLOsi9WElLGMnqjF5H3E4KbE9V9+bTWwL8OURKkC6fm4l pBF2WgD5icbCVqO9ItWQFi8rEF46sJS6t8n0egiwemdqPe83lHtbMveHEySnYJLEP99+ wdNE5WYjylHUDWuDWtuD20VJLSAkW/Ls2rOLzwDvFNef9/hkB3L9KVunkwELs1UfEZRU dXNjyKq9xFTt5/cYX1FAJbjA1Ij+bkZELKqGjvMlUSphPsr3TVHuxI/BWuX2zUXMpA+f 5EuiRCJEzFiL1oO96kRLPznq8BdejVrCAU5i0V5ZWZglf1Gz71RoUIi5x65wjWy6vZrt SsHA== X-Gm-Message-State: AFqh2kqEy+2dye2I6yCKKeHfqzdOYuP2YZVJWGPFEDFn8P8plzIP1iOv ikLCf2uS5httsBEVuA96QsZ+0Sv7ICs= X-Google-Smtp-Source: AMrXdXv2Luo4A7zUdVWW69JU9ERgjfUtU4ab+zGrW2tT4skoH7yUFZd7jYTfcGZPBil3uFMNQRTODQ== X-Received: by 2002:a05:6000:a03:b0:2b9:9e7b:be6b with SMTP id co3-20020a0560000a0300b002b99e7bbe6bmr23997172wrb.45.1674494924142; Mon, 23 Jan 2023 09:28:44 -0800 (PST) Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id n13-20020a5d67cd000000b002bdcce37d31sm33684568wrw.99.2023.01.23.09.28.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Jan 2023 09:28:43 -0800 (PST) From: Robert Pluim To: Ihor Radchenko Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] Fix some emacs-30 byte-compile warnings In-Reply-To: <87pmb5e491.fsf@localhost> (Ihor Radchenko's message of "Mon, 23 Jan 2023 14:04:42 +0000") References: <87pmb51hgh.fsf@gmail.com> <87pmb5e491.fsf@localhost> Date: Mon, 23 Jan 2023 18:28:42 +0100 Message-ID: <87h6wh17p1.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::430; envelope-from=rpluim@gmail.com; helo=mail-wr1-x430.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=HDjN+ccT; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=key1; d=yhetil.org; t=1674495001; a=rsa-sha256; cv=none; b=Ckz/63oZ09OAK607DY23okZVO8xFuFxQU7zNBYbY/4mX16lNmEnuXk/LCMSj5nnQsQkZd4 BIYobs7ED8DqKlmaKutgOdu5/ApXAHAWMQb1DG/U2ZfnGX8IovV/BfDj7m/q/jhEVMmGam V57ifYzB44vX4tYqpepnRSpAN+npi1SQDB0Q923mFj6rHDo+dTQCpIK28LHIElQ9H6qpjL 7lM1NgH77JZj6NVI6GlmMq8RBweBiOd82CkT98PM8dn7sT0iLszVzblJevrZ007ZzNZVgB i1CZ1xKqB5KdPT9wa7h/ADKOS+pPQU1nQ57XCP/AZdLJbqbmKrt2U3kfiUVtjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1674495001; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=Jtl3FBMQrkFU7wptSB4RNgK/0kFHQ0MLXsqxP6i8U9k=; b=JxC6Hdf/dZwNW/sVsxs67NrVzT6TKZNU6KeklPbs/Do0fLt0Ju6kEnt/eivfSXXfL9FjeF 8uBcR4fjPEWcaIAEDdnlUyzhNi6471b02W2DuICDjlDsE/NxsU7bWQUcRPiI2LhGJ+qcWF q01LxYuYtX3d8EhLsiqp31Xw7FDsFphMf/ON9NoAbfszmSeKOZSBS0EJX05aRXDRVYfnyy DJUDs6zdBKvp2tI5muedmtZvzoYhW1YFMVZyWKqkngtcmWymv4TDfprWiD+jaKvmYUOKml rzIdvbKW9FxEEcF1otJS3lvTbpa2/EVOp7RV1lrP0cO7UoJSpnCt5xIMj/tvaQ== X-Spam-Score: -7.85 X-Migadu-Queue-Id: 5BF6936AEA X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=HDjN+ccT; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com X-Migadu-Spam-Score: -7.85 X-TUID: b3OYeEBQj1EV >>>>> On Mon, 23 Jan 2023 14:04:42 +0000, Ihor Radchenko said: Ihor> Robert Pluim writes: >> The emacs 30 byte-compiler warns about uses of `eq' >> and similar with constant strings which might have unintended >> semantics. Patch is against emacs master. Ihor> Thanks, but it will break some tests: Ihor> 3 unexpected results: Ihor> FAILED test-org-table/copy-field Ihor> FAILED test-org-table/references/mode-string-N Ihor> FAILED test-org-table/references/mode-string-none Hmm, at least the first one is because the code in the 't' branch of (if (and (eq elements "") (not keep-empty)) in org-table-make-reference now runs, and it results in (eval '(identity))' Of course fixing that causes other problems I=CA=BCll get back to this maybe tomorrow. Robert --=20