From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id YKLQCafyGmTDpgAASxT56A (envelope-from ) for ; Wed, 22 Mar 2023 13:20:55 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id cFjUCKfyGmREeQEAG6o9tA (envelope-from ) for ; Wed, 22 Mar 2023 13:20:55 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DC8322FCB8 for ; Wed, 22 Mar 2023 13:20:54 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=gbKAY0KF; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1679487654; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Bf45NjGQHtJxkmhfEoPAZ0y3j8mf40d0UcSOAHa4e1Q=; b=TNiujPWM3YlJ7PJJ//yR8Iz24fFZow6trnbKGcm1p8iq3McEJ55vbnIYpMZ22SLU5no/W4 pzgvUfWtISlI496uSy9A7ZekuL7nBqwiFubs2UIw8PaI0/9vo4NkWnk6+U0Azgke8xMQnx QPPbi2ofWQk2w/aiPORQHTwE4b/BL/I54RgK2HXVnIer1xjxGL+WqpOVFeBCxp9EoUQJ9D UofiI2oTHSSHUpA7EiWWc8A5jQI2/8PQLfyEt7VxgYtCu04C8EgMjyw9MCgMIxYyfdV2i7 euObtswWAtbzc89y9uOWCGV7ccmhrm1mjN/Qk0lY1swqV98DBxVMlMqh8hi5Tw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1679487654; a=rsa-sha256; cv=none; b=gF78lfpop89CBVYcrcn7Xx6l/vgHEeK+cq03SzFBEBuH3SPP/NSh4t+sjIM0nexNlwp4zZ IE9z61Za7sZPwXBv1TQBGUYr5RxRmWICjCrnjpBbyCkyx9BdN2soBglipRwPHle4BAjSV/ nzGADnVBAwaP3pKdtwgMlAJxgNb1tehh28LkoUFJGeKxdn0myeorz/6MZ+SXA/xRUDJd7F 8afiNv+M8QZ5C9RHvO4Jy0xexxfDmorDlWgZahYFnYIw2IF6h7OYTCRnDJBYRVNGLewnu9 Ko4nw8VariFKoEFaDQNMPxW5qWIdJfyfbJYVehrrLWXp4NjjPsyOfWVmMFITnw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=gbKAY0KF; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pexSF-0008Bp-5q; Wed, 22 Mar 2023 08:20:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pexSD-0008A2-F8 for emacs-orgmode@gnu.org; Wed, 22 Mar 2023 08:20:33 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pexSB-0002ha-GJ for emacs-orgmode@gnu.org; Wed, 22 Mar 2023 08:20:33 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 9DF6524032A for ; Wed, 22 Mar 2023 13:20:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1679487629; bh=wJ4VyMLWDMyacvdN4KcBt2g9ihWZcSU23vkhEgcSQ/o=; h=From:To:Cc:Subject:Date:From; b=gbKAY0KFkzw0EBennJHeQlshcKkze09XaZPMgp67ViB9amlwvVVun3O+kn3fEtrXH wNCycgmT/anZn21I6unUbiKxxYlHnZxZ6nfzDWNCfSUuDuNdkxCW+kLwC+sJeDbY9s Ztf1qrkNHGzxq1pb3pd3bUUacK6enp3shE2OLlfF3Ho/+sPVdYIPjkz4bRLzI7D01X hBa45BLy3OO2mw0B3Cj/lEwIvhnib/V5Q8dYabLfjlRz+mNkKkVoqjZ8WaKxrki5vM qW9zieTRPX/EVU1LacsO19slTw9ERakqVueWhZUGDd7dUfwNlTGxJx6xjHSJR49Ey9 urg3Qxua5DmNQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4PhSGy3Q1hz6tqB; Wed, 22 Mar 2023 13:20:26 +0100 (CET) From: Ihor Radchenko To: Nathaniel Nicandro , Bastien Cc: emacs-orgmode Subject: Re: [PATCH] org-user-idle-seconds: Add support for logind In-Reply-To: <87a606njvc.fsf@gmail.com> References: <87a606njvc.fsf@gmail.com> Date: Wed, 22 Mar 2023 12:22:29 +0000 Message-ID: <87h6udnfga.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: X-Migadu-Scanner: scn0.migadu.com List-Post: X-Migadu-Queue-Id: DC8322FCB8 X-Spam-Score: -6.57 X-Migadu-Spam-Score: -6.57 List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-TUID: obmuqhI/Gl3H Nathaniel Nicandro writes: > I would like to submit a patch that adds support for logind to > `org-user-idle-seconds`. This patch has been working for me for a long > while now and I thought it time for me to submit it. I've contributed > to Emacs in the past so my paperwork should be on file. Thanks! Though I do not see any commits associated with Nathaniel Nicandro or your email in Emacs git repo. Bastien, may you check FSF records? > Let me know if any changes should be made. > > lisp/org-clock.el | 29 +++++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) Please provide the commit message. See https://orgmode.org/worg/org-contribute.html#commit-messages > +(defvar org-logind-dbus-session-path > + (when (and (boundp 'dbus-runtime-version) > + (require 'dbus nil t) > + (member "org.freedesktop.login1" (dbus-list-activatable-names))) > + (dbus-call-method > + :system "org.freedesktop.login1" > + "/org/freedesktop/login1" > + "org.freedesktop.login1.Manager" > + "GetSessionByPID" (emacs-pid)))) Please provide a docstring for the new variable. Also, this new feature is worth documenting in ORG-NEWS. Otherwise, the patch looks good. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at