From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <emacs-orgmode-bounces+larch=yhetil.org@gnu.org> Received: from mp2.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id GDZBObDI6WWOJwEAe85BDQ:P1 (envelope-from <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>) for <larch@yhetil.org>; Thu, 07 Mar 2024 15:01:21 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id GDZBObDI6WWOJwEAe85BDQ (envelope-from <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>) for <larch@yhetil.org>; Thu, 07 Mar 2024 15:01:21 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=OjNR58Ta; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1709820080; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=pX5X8Me+/Kfs6LDwp6IfuDoB6NHY6DgC+Jb3SuAjYKc=; b=f9YEjddTiVP2X8F8Hw+osLq6ArelaKwh4BHCriPr2PWsxxYQr3CSVogud5FWLiO+lTxd5d w8HH4WDIpHGPfIKqzDLIXVjSZh6MVovaiznUU5F9yzzjvkrFCBjK9jAbTkA7z8lAPpDN4O y3qJ0C2P5HER7W/Ir6KOrz6Yj+oDQbSp/F2rNerqry5AYjP2PT3XOXse+zc1a8/9iCTtGT uxoxrIdJstTjt2UfgK/AtdwUrai/XqVuODY9MVV3fFMykps/wgv9PJgW/4FtPz5qNqLuXG dzNcmNASZhu9rZdVIyANbo69awjPOYJqfejhwiIxmx66khOztAEgxsHllvv07Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=OjNR58Ta; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Seal: i=1; s=key1; d=yhetil.org; t=1709820080; a=rsa-sha256; cv=none; b=RioVHlOfZVMZo7SKs5QdxqSnN1aIwlESmkhu1YwWfT7HQLiB479UUxMO/7M5og6LbMYRzZ D2M9RhVWCuNBJr0zGYGH8t0nfvnuY0NbkoU6qHxj+NRDqAcZTCiUkrsH8A7uZ9eaA3r7c1 eQMl7Bv8SGRkYlk7hbBb4mqwEzD1Jr6rB0RbcNLqpwkx50HhW1+/1KLRUdP1G4ZZYoXu8Z 6L3BtHRGUgk/Fyl4LS0C840TOc2G1jOrkebYPXXLcNy4DPB3rBCtgpljI/SOoiL6kmEzTK vwMVm0YWE1N4X4tX4J2Ql7Jk399fLheIKe0bnMcvctUsivW0t4q0QFlFgbp2mw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CA0CC56130 for <larch@yhetil.org>; Thu, 7 Mar 2024 15:01:20 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <emacs-orgmode-bounces@gnu.org>) id 1riEID-0005yf-7e; Thu, 07 Mar 2024 09:00:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <yantar92@posteo.net>) id 1riEI1-0005us-R8 for emacs-orgmode@gnu.org; Thu, 07 Mar 2024 09:00:08 -0500 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <yantar92@posteo.net>) id 1riEHx-0000ue-MN for emacs-orgmode@gnu.org; Thu, 07 Mar 2024 09:00:04 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 5489A240104 for <emacs-orgmode@gnu.org>; Thu, 7 Mar 2024 14:59:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1709819998; bh=Oqc2UmeJ92lHZwOtGlq9593Ejt9uerFLQdHENI1137M=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=OjNR58TaPlrxxbi2KDVpassR5ZNyinxJ64eAg5Ma2PK1TaZh0v5KWdWf/pfSamt8q XsYw5j8ncImSUheAZhVPh46mctqJA/knxXtTKcXuXV3/7mtbLI3ox7tD+K4+7w5Rln wAR9ihys8AxC9VkW/Lmhrp27UAwhgaJI2MUK49VnTxD0S4fWRPbWjj6Z1FIccRmREs fw11LkrNuEpt64iNOOBf10ucY4RJbDp9HD24+IrWw8b3coUrqfLrHIuwByQC2afTK3 iVbTw8P1v/YAp7f99AZE2f1dkqBVSs2ttf8teA4rE7VpmDMcNIK+56brMxXDplW5m6 E7pGoKMb2DYwQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Tr9sn45Z0z6tyW; Thu, 7 Mar 2024 14:59:57 +0100 (CET) From: Ihor Radchenko <yantar92@posteo.net> To: Amy Grinn <grinn.amy@gmail.com> Cc: emacs-orgmode@gnu.org Subject: Re: noweb-start and noweb-end header args In-Reply-To: <s31cys8xz4w.fsf@gmail.com> References: <s31cys8xz4w.fsf@gmail.com> Date: Thu, 07 Mar 2024 14:04:03 +0000 Message-ID: <87h6hixhnw.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org> List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>, <mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe> List-Archive: <https://lists.gnu.org/archive/html/emacs-orgmode> List-Post: <mailto:emacs-orgmode@gnu.org> List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help> List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>, <mailto:emacs-orgmode-request@gnu.org?subject=subscribe> Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -7.08 X-Spam-Score: -7.08 X-Migadu-Queue-Id: CA0CC56130 X-Migadu-Scanner: mx13.migadu.com X-TUID: I8tT/7B9P8p9 Amy Grinn <grinn.amy@gmail.com> writes: > Here is a simple way to implement this feature. > ... > -(defun org-babel-noweb-wrap (&optional regexp) > +(defun org-babel-noweb-wrap (&optional regexp info) > "Return regexp matching a Noweb reference. > > Match any reference, or only those matching REGEXP, if non-nil. > > When matching, reference is stored in match group 1." INFO argument needs to be documented. > - (org-babel-noweb-wrap))))) > + (org-babel-noweb-wrap nil info))))) Please, also update all other cases when `org-babel-noweb-wrap' is called. Also, `org-babel-goto-named-src-block' uses org-babel-noweb-wrap-start/end directly. It should be adjusted. Since you are adding a new feature, it should have (1) test coverage; (2) be documented in the manual; (3) be announced in etc/ORG-NEWS. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>