emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: Pedro Andres Aranda Gutierrez <paaguti@gmail.com>
Cc: Org Mode List <emacs-orgmode@gnu.org>
Subject: Re: PATCH allow explicit style= in #+cite_export: biblatex
Date: Wed, 24 Apr 2024 17:06:12 +0000	[thread overview]
Message-ID: <87h6fqn117.fsf@localhost> (raw)
In-Reply-To: <CAO48Bk91MjUAi-AUbhKfKEZGQcJbb1yZWCNoM8U+cObUCH0bVw@mail.gmail.com>

Pedro Andres Aranda Gutierrez <paaguti@gmail.com> writes:

> Oops, you are right. My local copy got a bit messed up.
>
> Here is a hopefully clean patch. I have tried it out on a local test-patch
> branch of current main and it applied.

Thanks!
May you also add NEWS entry?

Also, a few comments inline.

> Subject: [PATCH] Allow biblatex package options natively

Please, prefix the first line with oc-biblatex library name.

> lisp/oc-biblatex.el: detect and allow biblatex package options
>   in key=val,key=val,... format. <style>,key=val,key=val,...
>   continues to be supported and both formats are distinguished
> doc/org-manual.org: mention that biblatex options in 'native'
>   format are also supported.  

The changelog entries are not correctly formatted. See
https://orgmode.org/worg/org-contribute.html#commit-messages

Also, please start sentences from capital letter.

> --- a/doc/org-manual.org
> +++ b/doc/org-manual.org
> @@ -17631,7 +17631,9 @@ your LaTeX installation, it won't export to anything but PDF.
>  specifies the =biblatex= export processor with the default =numeric=
>  style and the =bibtex= backend. Always define the style first and then
>  the rest of load-time options for the =biblatex=
> -package. Alternatively, use the ~org-cite-biblatex-options~ variable
> +package. Alternatively, you can use the ~key=val,key=val~ format for
> +the options as documented in the =biblatex= package documentation, which
> +is also used for  the ~org-cite-biblatex-options~ variable
>  in your Emacs configuration. It will only export to PDF, since it
>  relies on the ~biblatex~ processor of your LaTeX installation;

It would be nice to add an example demonstrating the described behaviour.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


  parent reply	other threads:[~2024-04-24 17:06 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-13  7:14 PATCH allow explicit style= in #+cite_export: biblatex Pedro Andres Aranda Gutierrez
2024-04-13 14:33 ` Ihor Radchenko
2024-04-14  5:22   ` Pedro Andres Aranda Gutierrez
2024-04-14  5:30     ` Pedro Andres Aranda Gutierrez
2024-04-14  7:16       ` Pedro Andres Aranda Gutierrez
2024-04-17  6:22         ` Pedro Andres Aranda Gutierrez
2024-04-17  7:00           ` Pedro Andres Aranda Gutierrez
2024-04-17 15:45             ` Pedro Andres Aranda Gutierrez
2024-04-21 13:21             ` Ihor Radchenko
2024-04-21 15:38               ` Pedro Andres Aranda Gutierrez
2024-04-22 19:46                 ` Ihor Radchenko
     [not found]                   ` <CAO48Bk_2xjGrN9Qgfe7hpnDnw=do5geKe3XnEA8wJr_dn8SZYg@mail.gmail.com>
     [not found]                     ` <87ttjspaor.fsf@localhost>
     [not found]                       ` <CAO48Bk91MjUAi-AUbhKfKEZGQcJbb1yZWCNoM8U+cObUCH0bVw@mail.gmail.com>
2024-04-24 17:06                         ` Ihor Radchenko [this message]
2024-04-25  5:34                           ` Pedro Andres Aranda Gutierrez
2024-04-26 12:24                             ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h6fqn117.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=emacs-orgmode@gnu.org \
    --cc=paaguti@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).