From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id +PAgCnjCi2eWOAEAe85BDQ:P1 (envelope-from ) for ; Sat, 18 Jan 2025 15:02:16 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id +PAgCnjCi2eWOAEAe85BDQ (envelope-from ) for ; Sat, 18 Jan 2025 16:02:16 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=PmX5ZvQe; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1737212535; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=d8EjAWB3qNObA0I5KHg/J9+grBSm/9CYPo+LbZJ+PAc=; b=hxt/gxfCmsvlB21BuTeHGvUZxBk85dqtt/WblBSVpf5TXIskirVjOfW4jyQasZur5zwZvo IFGjze88ON11rD0sbCQgaPf0aQFn3mByaP+DwReDpRuA9pK4t/P52rvW/fDIovQrTJcs29 hS1zlN0S65IG16XI6FmAANF4mHs3HgUp9BK3Qopmb804mrYwnNGwU9Uk3i3bphXzv6ip2D QzJAcXT28CwdW5Qr6RgxuZX1XaCokus7Q1ZKob2gYkquAPTK2hTsL6aOHS8SeQM8EvZU98 GoYNtirTE6mbbDV0jgMcTlaXWEaLrxGV0L0F2dFOXrKUyDrkzKp7noXQnicSFw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=PmX5ZvQe; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Seal: i=1; s=key1; d=yhetil.org; t=1737212535; a=rsa-sha256; cv=none; b=KNCnyjWjJzPC4JCvp1zM4NvBt5zxYqsUYV2xD+j8X9cbjCDR3GOKeV6WtRRQ3/hYOnzdVm 4GO4kJPlVX9f1Ox6VCYxjl9w25EfNxJj++V9r49wJi1pnI7LGamu8Q12HNERFBMtGTic+F RFESK8b4X65Rjna2vBcoeLW5gVhS2INq7CE7gw9o/26NF8FZQ8Dw+FA8T5+KBkOdXl1bBa fbWF8VbKFhl+JONLg9H5yGVn0dnD9Jb0Ujcy2vl3vJKhdqEz6k6Q2gyCzWAHv0ki56b/Wz E55DosSBwf3EfuYnf9kwu43UdxmghU7TfCBUwhh6AbuHck0SoM+nN46gOVGM/Q== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 104C11C200 for ; Sat, 18 Jan 2025 16:02:14 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tZAK8-0003wH-3j; Sat, 18 Jan 2025 10:01:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tZAK1-0003vt-CJ for emacs-orgmode@gnu.org; Sat, 18 Jan 2025 10:01:14 -0500 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tZAJy-0003lz-34 for emacs-orgmode@gnu.org; Sat, 18 Jan 2025 10:01:12 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id BA9B7240027 for ; Sat, 18 Jan 2025 16:01:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1737212468; bh=TgpVhON5XWnCuowT8nzhj8heCfIbHW5fYXAJsFTPu58=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: Content-Transfer-Encoding:From; b=PmX5ZvQe7QD7h6vRcouSPTM437iU/1RdSeOqcsNEImnCB1w1IDWe/7bjJ3sPtSTGt Y4uZwrnuKS71YsRbsxkeqz8LwbHwofcSHFgUoL33ovodb6TWeIV9W2UJmRWy/UJM9z Ik1et4mWMUGmHJynljr9wxO7DsgPiwXeOD/T1bP/X+Uv692Br4pwgXXW0UpvVKSUIp sk+5H6fycvg8460bZ9bvlGITANRGA4J4maqCJrF3bEUx/tnYmX7/LaCoTArownl8n5 q3nof8b3FTgfjlMv3kBbisyjPppWjS7AfXVqDw5MjfW6oajwVRAdT4kl2j2Y6HFfOS BTpzrnIPNAXgA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Yb0D41rjKz6twB; Sat, 18 Jan 2025 16:01:08 +0100 (CET) From: Ihor Radchenko To: =?utf-8?Q?Bj=C3=B6rn?= Bidar Cc: Karthik Chikmagalur , emacs-orgmode@gnu.org Subject: Re: Link preview generation with new link preview property In-Reply-To: <87ldv8chbs.fsf@> References: <6755f138.0c0a0220.40388.51fbSMTPIN_ADDED_BROKEN@mx.google.com> <874j382kue.fsf@gmail.com> <87pllug2y4.fsf@localhost> <87ldwfnff4.fsf@gmail.com> <874j328aym.fsf@localhost> <6764aa79.050a0220.23273b.09a5SMTPIN_ADDED_BROKEN@mx.google.com> <87y102mgdx.fsf@gmail.com> <87msgd2j9k.fsf@localhost> <877c7afz2y.fsf@localhost> Date: Sat, 18 Jan 2025 15:03:25 +0000 Message-ID: <87h65wdv0i.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -5.70 X-Spam-Score: -5.70 X-Migadu-Queue-Id: 104C11C200 X-TUID: 4FBbTt892JQ5 Bj=C3=B6rn Bidar writes: >> IMHO, it would be best to pass image file name/raw image data to >> `org-link-preview-image-data', not an image object and call >> `org--create-inline-image' from inside `org-link-preview-image-data'. >> That way, we can automatically obey Org customization wrt image >> alignment, image width, and image max width. > > For that case using org-link-preview-file should be sufficient?=20 Sorry, I am lost. AFAIU, your original motivation was: >> Would it be possible to also handle image data in the function or >> refactor the org-link-preview-file function in a way that the geometry >> handling is done in a helper function which can be reused by other >> handlers. Did it change? --=20 Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at . Support Org development at , or support my work at