From: Ihor Radchenko <yantar92@posteo.net>
To: "Björn Bidar" <bjorn.bidar@thaodan.de>
Cc: Karthik Chikmagalur <karthikchikmagalur@gmail.com>,
emacs-orgmode@gnu.org
Subject: Re: Link preview generation with new link preview property
Date: Sat, 18 Jan 2025 15:03:25 +0000 [thread overview]
Message-ID: <87h65wdv0i.fsf@localhost> (raw)
In-Reply-To: <87ldv8chbs.fsf@>
Björn Bidar <bjorn.bidar@thaodan.de> writes:
>> IMHO, it would be best to pass image file name/raw image data to
>> `org-link-preview-image-data', not an image object and call
>> `org--create-inline-image' from inside `org-link-preview-image-data'.
>> That way, we can automatically obey Org customization wrt image
>> alignment, image width, and image max width.
>
> For that case using org-link-preview-file should be sufficient?
Sorry, I am lost.
AFAIU, your original motivation was:
>> Would it be possible to also handle image data in the function or
>> refactor the org-link-preview-file function in a way that the geometry
>> handling is done in a helper function which can be reused by other
>> handlers.
Did it change?
--
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
next prev parent reply other threads:[~2025-01-18 15:02 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <6755f138.0c0a0220.40388.51fbSMTPIN_ADDED_BROKEN@mx.google.com>
2024-12-13 5:49 ` Link preview generation with new link preview property Karthik Chikmagalur
2024-12-14 0:03 ` Björn Bidar
2024-12-14 7:04 ` Ihor Radchenko
2024-12-17 2:46 ` Björn Bidar
2024-12-17 17:39 ` Ihor Radchenko
2024-12-19 21:55 ` Björn Bidar
2024-12-21 12:03 ` Ihor Radchenko
2024-12-17 3:42 ` Karthik Chikmagalur
2024-12-17 17:40 ` Ihor Radchenko
2024-12-19 23:20 ` Björn Bidar
2024-12-20 0:45 ` Karthik Chikmagalur
2024-12-21 12:05 ` Ihor Radchenko
2024-12-23 20:41 ` Björn Bidar
[not found] ` <6764aa79.050a0220.23273b.09a5SMTPIN_ADDED_BROKEN@mx.google.com>
2024-12-26 18:46 ` Karthik Chikmagalur
2024-12-29 15:44 ` Björn Bidar
2024-12-30 17:05 ` Ihor Radchenko
2025-01-04 2:01 ` Björn Bidar
2025-01-04 14:11 ` Ihor Radchenko
2025-01-18 14:44 ` Björn Bidar
2025-01-18 15:03 ` Ihor Radchenko [this message]
2024-12-18 6:21 ` stardiviner
2024-12-18 6:33 ` Karthik Chikmagalur
2024-12-19 23:26 ` Björn Bidar
2024-12-21 12:09 ` Ihor Radchenko
2024-12-08 19:18 Björn Bidar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h65wdv0i.fsf@localhost \
--to=yantar92@posteo.net \
--cc=bjorn.bidar@thaodan.de \
--cc=emacs-orgmode@gnu.org \
--cc=karthikchikmagalur@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).