emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Bernt Hansen <bernt@norang.ca>
To: Eric Schulte <schulte.eric@gmail.com>
Cc: Martyn Jago <martyn.jago@btinternet.com>, emacs-orgmode@gnu.org
Subject: Re: [babel][PATCH] ERT as external library deprecated.
Date: Wed, 02 Mar 2011 10:50:40 -0500	[thread overview]
Message-ID: <87fwr5mshb.fsf@norang.ca> (raw)
In-Reply-To: 87aahe68n7.fsf@gmail.com

Hi Eric and Martyn,

"Eric Schulte" <schulte.eric@gmail.com> writes:

> Hi Martyn,
>
> Thanks for the patch, I have just applied it.
>
> Best -- Eric
>
> Martyn Jago <martyn.jago@btinternet.com> writes:
>
>> Hi
>>
>> The ERT library is now a part of EMACS. As a result the ERT library
>> files currently loaded as a sub-module have been deleted on Github. 
>>
>> This change modifies .gitmodule to avoid attempting to load ERT.
>> Changes have been made to testing/README.org to suit.
>>
>> An insertion has been made to testing/README.org to point out that the
>> library-of-babel.org file needs ingesting (including a source block to
>> do so) to enable some tests to pass, and the "ERT reference" now points
>> to the included ERT info help pages.
>>
>> Broken dependencies in testing/org-test.el have been removed.
>>
>> I have also temporarily commented out a small number of broken tests
>> which between them cause ERT to go off into the weeds and delete a large
>> section of babel.org. This means that all tests currently pass.
>>
>> I will investigate the breakages and hopefully provide fixes.
>>
>> Hope this helps

Does this change still allow older Emacsen to use the testing library?
I have

    GNU Emacs 23.2.1 (i486-pc-linux-gnu, GTK+ Version 2.20.0)
    of 2010-12-11 on raven, modified by Debian

and I would still like to be able to run the test suite without
requiring an upgrade to Emacs 24.

Attempting to load the test library in my Emacs now gives the following
error:

--8<---------------cut here---------------start------------->8---
Loading /home/bernt/git/org-mode/testing/org-test.el (source)...
let*: Cannot open load file: ert-x
--8<---------------cut here---------------end--------------->8---

Regards,
Bernt

  reply	other threads:[~2011-03-02 15:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-01 10:46 [babel][PATCH] ERT as external library deprecated Martyn Jago
2011-03-01 17:01 ` Eric Schulte
2011-03-02 15:50   ` Bernt Hansen [this message]
2011-03-02 16:54     ` Martyn Jago
2011-03-02 16:58       ` Eric Schulte
2011-03-02 18:31         ` [babel][PATCH][tests] " Martyn Jago
2011-03-02 18:42           ` Eric Schulte
2011-03-01 18:02 ` [Accepted] [O,babel] " Bastien Guerry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fwr5mshb.fsf@norang.ca \
    --to=bernt@norang.ca \
    --cc=emacs-orgmode@gnu.org \
    --cc=martyn.jago@btinternet.com \
    --cc=schulte.eric@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).